ButterflyEffect/uniswap-interface-uncensored
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: bug where changing tabs can open the searchbar (#4607)

Browse Source 
* remove onFocus trigger

* typo on comment

Co-authored-by: Charlie <charlie@uniswap.org>
This commit is contained in:
Charles Bachmeier 2022-09-12 11:39:07 -07:00 committed by GitHub
parent 704ad222d9
commit 882c15dada
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/components/NavBar/SearchBar.tsx
View File

@ -186,7 +186,7 @@ export const SearchBarDropdown = ({ toggleOpen, tokens, collections, hasInput, i
(isNFTPage || !isTokenPage ? trendingCollections?.length ?? 0 : 0) + (isNFTPage || !isTokenPage ? trendingCollections?.length ?? 0 : 0) +
(isTokenPage || !isNFTPage ? trendingTokens?.length ?? 0 : 0) (isTokenPage || !isNFTPage ? trendingTokens?.length ?? 0 : 0)
// Close the modal on escape // Navigate search results via arrow keys
useEffect(() => { useEffect(() => {
const keyDownHandler = (event: KeyboardEvent) => { const keyDownHandler = (event: KeyboardEvent) => {
if (event.key === 'ArrowUp') { if (event.key === 'ArrowUp') {
@ -344,6 +344,7 @@ export const SearchBar = () => {
const [reducedTokens, reducedCollections] = organizeSearchResults(isNFTPage, tokens ?? [], collections ?? []) const [reducedTokens, reducedCollections] = organizeSearchResults(isNFTPage, tokens ?? [], collections ?? [])
// close dropdown on escape
useEffect(() => { useEffect(() => {
const escapeKeyDownHandler = (event: KeyboardEvent) => { const escapeKeyDownHandler = (event: KeyboardEvent) => {
if (event.key === 'Escape' && isOpen) { if (event.key === 'Escape' && isOpen) {
@ -394,7 +395,6 @@ export const SearchBar = () => {
borderTopRightRadius={isOpen && !isMobile ? '12' : undefined} borderTopRightRadius={isOpen && !isMobile ? '12' : undefined}
borderTopLeftRadius={isOpen && !isMobile ? '12' : undefined} borderTopLeftRadius={isOpen && !isMobile ? '12' : undefined}
borderBottomWidth={isOpen || isMobileOrTablet ? '0px' : '1px'} borderBottomWidth={isOpen || isMobileOrTablet ? '0px' : '1px'}
onFocus={() => !isOpen && toggleOpen()}
onClick={() => !isOpen && toggleOpen()} onClick={() => !isOpen && toggleOpen()}
gap="12" gap="12"
> >