From a726f6745375c7be9ed30b01c6ffbe65f4a995a9 Mon Sep 17 00:00:00 2001 From: Nate Wienert Date: Mon, 7 Aug 2023 14:14:41 -1000 Subject: [PATCH] fix: bring back flake retries for flaky test (only flakes ~33% of time) (#7063) --- cypress/e2e/universal-search.test.ts | 39 ++++++++++++++++++---------- 1 file changed, 25 insertions(+), 14 deletions(-) diff --git a/cypress/e2e/universal-search.test.ts b/cypress/e2e/universal-search.test.ts index 7a25cd262c..c58b02f041 100644 --- a/cypress/e2e/universal-search.test.ts +++ b/cypress/e2e/universal-search.test.ts @@ -34,20 +34,31 @@ describe('Universal search bar', () => { .should('exist') }) - it('should go to the selected result when recent results are shown', () => { - // Seed recent results with UNI. - openSearch() - getSearchBar().type('uni') - cy.get(getTestSelector('searchbar-token-row-UNI')) - getSearchBar().clear().type('{esc}') + it( + 'should go to the selected result when recent results are shown', + // this test is experiencing flake despite being correct, i can see the right value in DOM + // but for some reason cypress doesn't find it, so adding retries for now :/ + { + retries: { + runMode: 3, + openMode: 3, + }, + }, + () => { + // Seed recent results with UNI. + openSearch() + getSearchBar().type('uni') + cy.get(getTestSelector('searchbar-token-row-UNI')) + getSearchBar().clear().type('{esc}') - // Search a different token by name. - openSearch() - getSearchBar().type('eth') - cy.get(getTestSelector('searchbar-token-row-ETH')) + // Search a different token by name. + openSearch() + getSearchBar().type('eth') + cy.get(getTestSelector('searchbar-token-row-ETH')) - // Validate that we go to the searched/selected result. - getSearchBar().type('{enter}') - cy.url().should('contain', 'tokens/ethereum/NATIVE') - }) + // Validate that we go to the searched/selected result. + getSearchBar().type('{enter}') + cy.url().should('contain', 'tokens/ethereum/NATIVE') + } + ) })