chore: remove tokensNetworkFilter feature flag (#4679)

This commit is contained in:
vignesh mohankumar 2022-09-20 15:57:22 -04:00 committed by GitHub
parent 6f2d6e31c9
commit dbb62b613c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 2 additions and 23 deletions

@ -4,7 +4,6 @@ import { NftVariant, useNftFlag } from 'featureFlags/flags/nft'
import { RedesignVariant, useRedesignFlag } from 'featureFlags/flags/redesign' import { RedesignVariant, useRedesignFlag } from 'featureFlags/flags/redesign'
import { TokensVariant, useTokensFlag } from 'featureFlags/flags/tokens' import { TokensVariant, useTokensFlag } from 'featureFlags/flags/tokens'
import { TokenSafetyVariant, useTokenSafetyFlag } from 'featureFlags/flags/tokenSafety' import { TokenSafetyVariant, useTokenSafetyFlag } from 'featureFlags/flags/tokenSafety'
import { TokensNetworkFilterVariant, useTokensNetworkFilterFlag } from 'featureFlags/flags/tokensNetworkFilter'
import { TraceJsonRpcVariant, useTraceJsonRpcFlag } from 'featureFlags/flags/traceJsonRpc' import { TraceJsonRpcVariant, useTraceJsonRpcFlag } from 'featureFlags/flags/traceJsonRpc'
import { useAtomValue, useUpdateAtom } from 'jotai/utils' import { useAtomValue, useUpdateAtom } from 'jotai/utils'
import { Children, PropsWithChildren, ReactElement, ReactNode, useCallback, useState } from 'react' import { Children, PropsWithChildren, ReactElement, ReactNode, useCallback, useState } from 'react'
@ -226,12 +225,6 @@ export default function FeatureFlagModal() {
featureFlag={FeatureFlag.tokens} featureFlag={FeatureFlag.tokens}
label="Tokens" label="Tokens"
/> />
<FeatureFlagOption
variant={TokensNetworkFilterVariant}
value={useTokensNetworkFilterFlag()}
featureFlag={FeatureFlag.tokensNetworkFilter}
label="Tokens Network Filter"
/>
<FeatureFlagOption <FeatureFlagOption
variant={TokenSafetyVariant} variant={TokenSafetyVariant}
value={useTokenSafetyFlag()} value={useTokenSafetyFlag()}

@ -3,7 +3,6 @@ export enum FeatureFlag {
nft = 'nfts', nft = 'nfts',
redesign = 'redesign', redesign = 'redesign',
tokens = 'tokens', tokens = 'tokens',
tokensNetworkFilter = 'tokensNetworkFilter',
tokenSafety = 'tokenSafety', tokenSafety = 'tokenSafety',
traceJsonRpc = 'traceJsonRpc', traceJsonRpc = 'traceJsonRpc',
} }

@ -1,7 +0,0 @@
import { BaseVariant, FeatureFlag, useBaseFlag } from '../index'
export function useTokensNetworkFilterFlag(): BaseVariant {
return useBaseFlag(FeatureFlag.tokensNetworkFilter)
}
export { BaseVariant as TokensNetworkFilterVariant }

@ -8,7 +8,6 @@ import NetworkFilter from 'components/Tokens/TokenTable/NetworkFilter'
import SearchBar from 'components/Tokens/TokenTable/SearchBar' import SearchBar from 'components/Tokens/TokenTable/SearchBar'
import TimeSelector from 'components/Tokens/TokenTable/TimeSelector' import TimeSelector from 'components/Tokens/TokenTable/TimeSelector'
import TokenTable, { LoadingTokenTable } from 'components/Tokens/TokenTable/TokenTable' import TokenTable, { LoadingTokenTable } from 'components/Tokens/TokenTable/TokenTable'
import { TokensNetworkFilterVariant, useTokensNetworkFilterFlag } from 'featureFlags/flags/tokensNetworkFilter'
import { useResetAtom } from 'jotai/utils' import { useResetAtom } from 'jotai/utils'
import { useEffect } from 'react' import { useEffect } from 'react'
import { useLocation } from 'react-router-dom' import { useLocation } from 'react-router-dom'
@ -68,7 +67,6 @@ const FiltersWrapper = styled.div`
` `
const Tokens = () => { const Tokens = () => {
const tokensNetworkFilterFlag = useTokensNetworkFilterFlag()
const resetFilterString = useResetAtom(filterStringAtom) const resetFilterString = useResetAtom(filterStringAtom)
const location = useLocation() const location = useLocation()
useEffect(() => { useEffect(() => {
@ -86,15 +84,13 @@ const Tokens = () => {
<FiltersWrapper> <FiltersWrapper>
<FiltersContainer> <FiltersContainer>
<FavoriteButton /> <FavoriteButton />
{tokensNetworkFilterFlag === TokensNetworkFilterVariant.Enabled && <NetworkFilter />} <NetworkFilter />
<TimeSelector /> <TimeSelector />
</FiltersContainer> </FiltersContainer>
<SearchContainer> <SearchContainer>
<SearchBar /> <SearchBar />
</SearchContainer> </SearchContainer>
</FiltersWrapper> </FiltersWrapper>
<TokenTableContainer> <TokenTableContainer>
<TokenTable /> <TokenTable />
</TokenTableContainer> </TokenTableContainer>
@ -104,8 +100,6 @@ const Tokens = () => {
} }
export const LoadingTokens = () => { export const LoadingTokens = () => {
const tokensNetworkFilterFlag = useTokensNetworkFilterFlag()
return ( return (
<ExploreContainer> <ExploreContainer>
<TitleContainer> <TitleContainer>
@ -116,7 +110,7 @@ export const LoadingTokens = () => {
<FiltersWrapper> <FiltersWrapper>
<FiltersContainer> <FiltersContainer>
<FavoriteButton /> <FavoriteButton />
{tokensNetworkFilterFlag === TokensNetworkFilterVariant.Enabled && <NetworkFilter />} <NetworkFilter />
<TimeSelector /> <TimeSelector />
</FiltersContainer> </FiltersContainer>
<SearchContainer> <SearchContainer>