ButterflyEffect/uniswap-interface-uncensored
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

improvement(swap errors): show more information about the swap error

Browse Source
This commit is contained in:
Moody Salem 2020-08-10 12:05:35 -05:00
parent 0f91af1df2
commit e589c751d7
No known key found for this signature in database
GPG Key ID: 8CB5CD10385138DB
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/hooks/useSwapCallback.ts
View File

@ -104,8 +104,6 @@ function useSwapCallArguments(
}, [account, allowedSlippage, chainId, deadline, library, recipient, trade, v1Exchange]) }, [account, allowedSlippage, chainId, deadline, library, recipient, trade, v1Exchange])
} }
const DEFAULT_FAILED_SWAP_ERROR = 'Unexpected error. Please try again or contact support.'
// returns a function that will execute a swap, if the parameters are all valid // returns a function that will execute a swap, if the parameters are all valid
// and the user has approved the slippage adjusted input amount for the trade // and the user has approved the slippage adjusted input amount for the trade
export function useSwapCallback( export function useSwapCallback(
@ -161,17 +159,19 @@ export function useSwapCallback(
return contract.callStatic[methodName](...args, options) return contract.callStatic[methodName](...args, options)
.then(result => { .then(result => {
console.debug('Unexpected successful call after failed estimate gas', call, gasError, result) console.debug('Unexpected successful call after failed estimate gas', call, gasError, result)
return { call, error: new Error(DEFAULT_FAILED_SWAP_ERROR) } return { call, error: new Error('Unexpected issue with estimating the gas. Please try again.') }
}) })
.catch(callError => { .catch(callError => {
console.debug('Call threw error', call, callError) console.debug('Call threw error', call, callError)
let errorMessage: string = DEFAULT_FAILED_SWAP_ERROR let errorMessage: string
switch (callError.reason) { switch (callError.reason) {
case 'UniswapV2Router: INSUFFICIENT_OUTPUT_AMOUNT': case 'UniswapV2Router: INSUFFICIENT_OUTPUT_AMOUNT':
case 'UniswapV2Router: EXCESSIVE_INPUT_AMOUNT': case 'UniswapV2Router: EXCESSIVE_INPUT_AMOUNT':
errorMessage = errorMessage =
'This transaction will not succeed either due to price movement or fee on transfer. Try increasing your slippage tolerance.' 'This transaction will not succeed either due to price movement or fee on transfer. Try increasing your slippage tolerance.'
break break
default:
errorMessage = `The transaction cannot succeed due to error: ${callError.reason}. This is probably an issue with one of the tokens you are swapping.`
} }
return { call, error: new Error(errorMessage) } return { call, error: new Error(errorMessage) }
}) })
@ -188,7 +188,7 @@ export function useSwapCallback(
if (!successfulEstimation) { if (!successfulEstimation) {
const errorCalls = estimatedCalls.filter((call): call is FailedCall => 'error' in call) const errorCalls = estimatedCalls.filter((call): call is FailedCall => 'error' in call)
if (errorCalls.length > 0) throw errorCalls[errorCalls.length - 1].error if (errorCalls.length > 0) throw errorCalls[errorCalls.length - 1].error
throw new Error(DEFAULT_FAILED_SWAP_ERROR) throw new Error('Unexpected error. Please contact support: none of the calls threw an error')
} }
const { const {
@ -235,7 +235,7 @@ export function useSwapCallback(
} else { } else {
// otherwise, the error was unexpected and we need to convey that // otherwise, the error was unexpected and we need to convey that
console.error(`Swap failed`, error, methodName, args, value) console.error(`Swap failed`, error, methodName, args, value)
throw new Error(DEFAULT_FAILED_SWAP_ERROR) throw new Error(`Swap failed: ${error.message}`)
} }
}) })
}, },