fix: revise strings on token details + change privacy disclaimer edits to be enabled by phase 1 flag (#4856)

* init

* nft flag name change
This commit is contained in:
lynn 2022-10-10 21:58:42 -04:00 committed by GitHub
parent d8677d8a6d
commit e8d6235529
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 6 deletions

@ -143,7 +143,7 @@ export const MenuDropdown = () => {
<BarChartIcon width={24} height={24} /> <BarChartIcon width={24} height={24} />
</Icon> </Icon>
<PrimaryMenuRow.Text> <PrimaryMenuRow.Text>
<Trans>View token analytics</Trans> <Trans>View more analytics</Trans>
</PrimaryMenuRow.Text> </PrimaryMenuRow.Text>
</PrimaryMenuRow> </PrimaryMenuRow>
</Column> </Column>

@ -100,7 +100,7 @@ export function AboutSection({ address, description, homepageUrl, twitterName }:
</ThemedText.SubHeaderSmall> </ThemedText.SubHeaderSmall>
<ResourcesContainer> <ResourcesContainer>
<Resource name={'Etherscan'} link={`https://etherscan.io/address/${address}`} /> <Resource name={'Etherscan'} link={`https://etherscan.io/address/${address}`} />
<Resource name={'Protocol info'} link={`https://info.uniswap.org/#/tokens/${address}`} /> <Resource name={'More analytics'} link={`https://info.uniswap.org/#/tokens/${address}`} />
{homepageUrl && <Resource name={'Website'} link={homepageUrl} />} {homepageUrl && <Resource name={'Website'} link={homepageUrl} />}
{twitterName && <Resource name={'Twitter'} link={`https://twitter.com/${twitterName}`} />} {twitterName && <Resource name={'Twitter'} link={`https://twitter.com/${twitterName}`} />}
</ResourcesContainer> </ResourcesContainer>

@ -7,6 +7,7 @@ import { sendEvent } from 'components/analytics'
import { AutoColumn } from 'components/Column' import { AutoColumn } from 'components/Column'
import { AutoRow } from 'components/Row' import { AutoRow } from 'components/Row'
import { getConnection, getConnectionName, getIsCoinbaseWallet, getIsInjected, getIsMetaMask } from 'connection/utils' import { getConnection, getConnectionName, getIsCoinbaseWallet, getIsInjected, getIsMetaMask } from 'connection/utils'
import { NftVariant, useNftFlag } from 'featureFlags/flags/nft'
import { RedesignVariant, useRedesignFlag } from 'featureFlags/flags/redesign' import { RedesignVariant, useRedesignFlag } from 'featureFlags/flags/redesign'
import usePrevious from 'hooks/usePrevious' import usePrevious from 'hooks/usePrevious'
import { useCallback, useEffect, useState } from 'react' import { useCallback, useEffect, useState } from 'react'
@ -156,6 +157,7 @@ export default function WalletModal({
const redesignFlag = useRedesignFlag() const redesignFlag = useRedesignFlag()
const redesignFlagEnabled = redesignFlag === RedesignVariant.Enabled const redesignFlagEnabled = redesignFlag === RedesignVariant.Enabled
const nftFlagEnabled = useNftFlag() === NftVariant.Enabled
const [walletView, setWalletView] = useState(WALLET_VIEWS.ACCOUNT) const [walletView, setWalletView] = useState(WALLET_VIEWS.ACCOUNT)
const [lastActiveWalletAddress, setLastActiveWalletAddress] = useState<string | undefined>(account) const [lastActiveWalletAddress, setLastActiveWalletAddress] = useState<string | undefined>(account)
@ -307,9 +309,9 @@ export default function WalletModal({
) )
} }
function getTermsOfService(redesignFlagEnabled: boolean, walletView: string) { function getTermsOfService(nftFlagEnabled: boolean, walletView: string) {
if (redesignFlagEnabled && walletView === WALLET_VIEWS.PENDING) return null if (nftFlagEnabled && walletView === WALLET_VIEWS.PENDING) return null
return redesignFlagEnabled ? ( return nftFlagEnabled ? (
<AutoRow style={{ flexWrap: 'nowrap', padding: '4px 16px' }}> <AutoRow style={{ flexWrap: 'nowrap', padding: '4px 16px' }}>
<ThemedText.BodySecondary fontSize={16} lineHeight={'24px'}> <ThemedText.BodySecondary fontSize={16} lineHeight={'24px'}>
<Trans> <Trans>
@ -357,7 +359,7 @@ export default function WalletModal({
/> />
)} )}
{walletView !== WALLET_VIEWS.PENDING && <OptionGrid data-testid="option-grid">{getOptions()}</OptionGrid>} {walletView !== WALLET_VIEWS.PENDING && <OptionGrid data-testid="option-grid">{getOptions()}</OptionGrid>}
{!pendingError && getTermsOfService(redesignFlagEnabled, walletView)} {!pendingError && getTermsOfService(nftFlagEnabled, walletView)}
</AutoColumn> </AutoColumn>
</ContentWrapper> </ContentWrapper>
</UpperSection> </UpperSection>