From f5d0804c4629469323c07dfb81e6ebbc0f0b78a5 Mon Sep 17 00:00:00 2001
From: Jack Short <john.short.tj@gmail.com>
Date: Thu, 13 Apr 2023 15:43:14 -0400
Subject: [PATCH] feat: creating feature flag for details v2 page (#6359)

* feat: creating feature flag for details v2 page

* eslint ignore

* moving details v2 under trace
---
 .../FeatureFlagModal/FeatureFlagModal.tsx     |  7 +++++
 src/featureFlags/flags/featureFlags.ts        |  1 +
 src/featureFlags/flags/nftDetails.ts          | 11 ++++++++
 src/nft/components/details/NftDetails.tsx     | 14 ++++++++++
 src/nft/pages/asset/Asset.tsx                 | 26 ++++++++++++-------
 5 files changed, 49 insertions(+), 10 deletions(-)
 create mode 100644 src/featureFlags/flags/nftDetails.ts
 create mode 100644 src/nft/components/details/NftDetails.tsx

diff --git a/src/components/FeatureFlagModal/FeatureFlagModal.tsx b/src/components/FeatureFlagModal/FeatureFlagModal.tsx
index 3a099d2305..e47482152b 100644
--- a/src/components/FeatureFlagModal/FeatureFlagModal.tsx
+++ b/src/components/FeatureFlagModal/FeatureFlagModal.tsx
@@ -1,6 +1,7 @@
 import { BaseVariant, FeatureFlag, featureFlagSettings, useUpdateFlag } from 'featureFlags'
 import { MgtmVariant, useMgtmFlag } from 'featureFlags/flags/mgtm'
 import { useMiniPortfolioFlag } from 'featureFlags/flags/miniPortfolio'
+import { DetailsV2Variant, useDetailsV2Flag } from 'featureFlags/flags/nftDetails'
 import { NftGraphqlVariant, useNftGraphqlFlag } from 'featureFlags/flags/nftlGraphql'
 import { PayWithAnyTokenVariant, usePayWithAnyTokenFlag } from 'featureFlags/flags/payWithAnyToken'
 import { SwapWidgetVariant, useSwapWidgetFlag } from 'featureFlags/flags/swapWidget'
@@ -235,6 +236,12 @@ export default function FeatureFlagModal() {
         featureFlag={FeatureFlag.nftGraphql}
         label="Migrate NFT read endpoints to GQL"
       />
+      <FeatureFlagOption
+        variant={DetailsV2Variant}
+        value={useDetailsV2Flag()}
+        featureFlag={FeatureFlag.detailsV2}
+        label="Use the new details page for nfts"
+      />
       <FeatureFlagGroup name="Debug">
         <FeatureFlagOption
           variant={TraceJsonRpcVariant}
diff --git a/src/featureFlags/flags/featureFlags.ts b/src/featureFlags/flags/featureFlags.ts
index fc51623b60..d4517480fa 100644
--- a/src/featureFlags/flags/featureFlags.ts
+++ b/src/featureFlags/flags/featureFlags.ts
@@ -11,4 +11,5 @@ export enum FeatureFlag {
   nftGraphql = 'nft_graphql_migration',
   mgtm = 'web_mobile_go_to_market_enabled',
   miniPortfolio = 'miniPortfolio',
+  detailsV2 = 'details_v2',
 }
diff --git a/src/featureFlags/flags/nftDetails.ts b/src/featureFlags/flags/nftDetails.ts
new file mode 100644
index 0000000000..2de550d1eb
--- /dev/null
+++ b/src/featureFlags/flags/nftDetails.ts
@@ -0,0 +1,11 @@
+import { BaseVariant, FeatureFlag, useBaseFlag } from '../index'
+
+export function useDetailsV2Flag(): BaseVariant {
+  return useBaseFlag(FeatureFlag.detailsV2)
+}
+
+export function useDetailsV2Enabled(): boolean {
+  return useDetailsV2Flag() === BaseVariant.Enabled
+}
+
+export { BaseVariant as DetailsV2Variant }
diff --git a/src/nft/components/details/NftDetails.tsx b/src/nft/components/details/NftDetails.tsx
new file mode 100644
index 0000000000..4a9284e6c6
--- /dev/null
+++ b/src/nft/components/details/NftDetails.tsx
@@ -0,0 +1,14 @@
+import { CollectionInfoForAsset, GenieAsset } from 'nft/types'
+
+interface NftDetailsProps {
+  asset: GenieAsset
+  collection: CollectionInfoForAsset
+}
+
+export const NftDetails = ({ asset, collection }: NftDetailsProps) => {
+  return (
+    <div>
+      Details page for {asset.name} from {collection.collectionName}
+    </div>
+  )
+}
diff --git a/src/nft/pages/asset/Asset.tsx b/src/nft/pages/asset/Asset.tsx
index c87640eece..bd00ec2ac8 100644
--- a/src/nft/pages/asset/Asset.tsx
+++ b/src/nft/pages/asset/Asset.tsx
@@ -1,9 +1,11 @@
 import { Trace } from '@uniswap/analytics'
 import { InterfacePageName } from '@uniswap/analytics-events'
+import { useDetailsV2Enabled } from 'featureFlags/flags/nftDetails'
 import { useNftAssetDetails } from 'graphql/data/nft/Details'
 import { AssetDetails } from 'nft/components/details/AssetDetails'
 import { AssetDetailsLoading } from 'nft/components/details/AssetDetailsLoading'
 import { AssetPriceDetails } from 'nft/components/details/AssetPriceDetails'
+import { NftDetails } from 'nft/components/details/NftDetails'
 import { useParams } from 'react-router-dom'
 import styled from 'styled-components/macro'
 
@@ -37,11 +39,11 @@ const AssetPriceDetailsContainer = styled.div`
 const AssetPage = () => {
   const { tokenId = '', contractAddress = '' } = useParams()
   const { data, loading } = useNftAssetDetails(contractAddress, tokenId)
+  const detailsV2Enabled = useDetailsV2Enabled()
 
   const [asset, collection] = data
 
-  if (loading) return <AssetDetailsLoading />
-
+  if (loading && !detailsV2Enabled) return <AssetDetailsLoading />
   return (
     <>
       <Trace
@@ -49,14 +51,18 @@ const AssetPage = () => {
         properties={{ collection_address: contractAddress, token_id: tokenId }}
         shouldLogImpression
       >
-        {!!asset && !!collection && (
-          <AssetContainer>
-            <AssetDetails collection={collection} asset={asset} />
-            <AssetPriceDetailsContainer>
-              <AssetPriceDetails collection={collection} asset={asset} />
-            </AssetPriceDetailsContainer>
-          </AssetContainer>
-        )}
+        {!!asset && !!collection ? (
+          detailsV2Enabled ? (
+            <NftDetails asset={asset} collection={collection} />
+          ) : (
+            <AssetContainer>
+              <AssetDetails collection={collection} asset={asset} />
+              <AssetPriceDetailsContainer>
+                <AssetPriceDetails collection={collection} asset={asset} />
+              </AssetPriceDetailsContainer>
+            </AssetContainer>
+          )
+        ) : null}
       </Trace>
     </>
   )