2019-08-21 08:53:47 +03:00
|
|
|
<p>The ethers.js library is something that I've written out of necessity, and has grown somewhat organically over time.</p><p>Many things are the way they are for good (at the time, at least) reasons, but I always welcome criticism, and am completely willing to have my mind changed on things.</p><p>So, pull requests are always welcome, but please keep a few points in mind:</p><ul><li>Backwards-compatibility-breaking changes will not be accepted; they may be considered for the next major version</li><li>Security is important; adding dependencies require fairly convincing arguments as to why</li><li>The library aims to be lean, so keep an eye on the dist/ethers.min.js file size before and after your changes</li><li>Add test cases for both expected and unexpected input</li><li>Any new features need to be supported by me (future issues, documentation, testing, migration), so anything that is overly complicated or specific may not be accepted</li></ul><p>In general, <b>please start an issue <i>before</i> beginning a pull request</b>, so we can have a public discussion and figure out the best way to address to problem/feature. <b>:)</b></p>
|