2020-06-18 06:38:59 +03:00
|
|
|
_section: Contributing and Hacking @<contributing>
|
2019-08-21 08:53:47 +03:00
|
|
|
|
|
|
|
The ethers.js library is something that I've written out of necessity,
|
|
|
|
and has grown somewhat organically over time.
|
|
|
|
|
|
|
|
Many things are the way they are for good (at the time, at least) reasons,
|
|
|
|
but I always welcome criticism, and am completely willing to have my mind
|
|
|
|
changed on things.
|
|
|
|
|
|
|
|
So, pull requests are always welcome, but please keep a few points in mind:
|
|
|
|
|
|
|
|
- Backwards-compatibility-breaking changes will not be accepted; they may be
|
|
|
|
considered for the next major version
|
|
|
|
- Security is important; adding dependencies require fairly convincing
|
|
|
|
arguments as to why
|
|
|
|
- The library aims to be lean, so keep an eye on the dist/ethers.min.js
|
|
|
|
file size before and after your changes
|
|
|
|
- Add test cases for both expected and unexpected input
|
|
|
|
- Any new features need to be supported by me (future issues, documentation,
|
|
|
|
testing, migration), so anything that is overly complicated or specific
|
|
|
|
may not be accepted
|
|
|
|
|
|
|
|
In general, **please start an issue //before// beginning a pull request**, so we can
|
2020-11-23 07:03:50 +03:00
|
|
|
have a public discussion and figure out the best way to address the problem/feature.
|
2019-08-21 08:53:47 +03:00
|
|
|
**:)**
|
|
|
|
|
|
|
|
|
2020-06-18 06:38:59 +03:00
|
|
|
_subsection: Building @<contributing--building>
|
2019-08-21 08:53:47 +03:00
|
|
|
|
2020-06-18 06:38:59 +03:00
|
|
|
If you wish to modify the source code, there are a few steps involved in
|
|
|
|
setting up your environment.
|
2019-08-21 08:53:47 +03:00
|
|
|
|
2020-06-18 06:38:59 +03:00
|
|
|
Since the library uses a monorepo, you must install an initial required
|
|
|
|
set of libraries, which can then be used to install the remaining libraries
|
|
|
|
used within each package, as well as link all the packages within the repo
|
|
|
|
with each other.
|
2020-06-12 10:38:55 +03:00
|
|
|
|
2020-06-18 06:38:59 +03:00
|
|
|
_code: Preparing for builds @lang<shell>
|
|
|
|
|
|
|
|
# Clone the repository
|
2020-06-12 10:38:55 +03:00
|
|
|
/home/ricmoo> git clone git@github.com:ethers-io/ethers.js.git
|
|
|
|
/home/ricmoo> cd ethers.js
|
|
|
|
|
|
|
|
# Install the base dependencies
|
|
|
|
/home/ricmoo/ethers.js> npm install
|
|
|
|
|
|
|
|
# Install each module's dependencies and link the libraries
|
|
|
|
# internally, so they reference each other
|
|
|
|
/home/ricmoo/ethers.js> npm run bootstrap
|
|
|
|
|
|
|
|
|
2020-06-18 06:38:59 +03:00
|
|
|
_subsection: Making your changes @<contributing--updating>
|
|
|
|
|
|
|
|
TODO: Add more information here.
|
|
|
|
|
2020-06-12 10:38:55 +03:00
|
|
|
_code: Watching and Building @lang<shell>
|
|
|
|
|
|
|
|
# Begin watching the files and re-building whenever they change
|
|
|
|
/home/ricmoo/ethers.js> npm run auto-build
|
|
|
|
|
|
|
|
|
|
|
|
# Sometimes the issue only affects the ESM modules
|
|
|
|
/home/ricmoo/ethers.js> npm run auto-build-esm
|
|
|
|
|
|
|
|
|
|
|
|
# Or if you only need to run a single build
|
|
|
|
/home/ricmoo/ethers.js> npm run _build-cjs
|
|
|
|
/home/ricmoo/ethers.js> npm run _build-esm
|
|
|
|
|
|
|
|
|
|
|
|
_code: Testing @lang<shell>
|
|
|
|
|
|
|
|
# Rebuilds all files and bundles testcases up for testing
|
|
|
|
/home/ricmoo/ethers.js> npm test
|
|
|
|
|
|
|
|
# Often you don't need the full CI experience
|
|
|
|
/home/ricmoo/ethers.js> npm run _test-node
|
|
|
|
|
|
|
|
|
|
|
|
_code: Preparing the Distribution @lang<shell>
|
|
|
|
|
|
|
|
/home/ricmoo/ethers.js> npm run update-version
|
2019-08-21 08:53:47 +03:00
|
|
|
|
2020-06-18 06:38:59 +03:00
|
|
|
|
|
|
|
_subsection: Documentation @<contributing--documentation>
|
|
|
|
|
|
|
|
The documents are generated using [Flatworm](flatworm) documentation
|
|
|
|
generation tool, which was written for the purpose of writing the documentation
|
|
|
|
for ethers.
|
|
|
|
|
|
|
|
Style Guide (this section will have much more coming):
|
|
|
|
|
|
|
|
- Try to keep lines no longer than //around// 80 characters
|
|
|
|
- Avoid inline links in the source; use the ``externalLinks`` field in the config.js
|
|
|
|
- Prefix external links with ``link-``
|
|
|
|
- Changing an anchor name must be well justified, as it will break all existing links
|
2020-10-03 19:30:15 +03:00
|
|
|
to that section; flatworm will support symlinks in the future
|
2020-06-18 06:38:59 +03:00
|
|
|
- In general, I aim for xonsistency; look to similar situations throughout the documentation
|
|
|
|
|
|
|
|
|
|
|
|
_heading: Building
|
|
|
|
|
|
|
|
To build the documentation, you should first follow the
|
|
|
|
[above steps](contributing--building) to build the ethers library.
|
|
|
|
|
|
|
|
Building the docs will generate several types of output:
|
|
|
|
|
|
|
|
- A full set of HTML pages, linking across each other
|
|
|
|
- A single one-page HTML page with all pages linking to local anchors
|
|
|
|
- A full set of README.md pages organized to be browsable and linkable in GitHub
|
|
|
|
- A metadata dump for tool ingestion (still needs more work)
|
|
|
|
- (@TODO; only half done) The documentation as a LaTeX and generated PDF
|
|
|
|
|
|
|
|
_code: Building the Documentations @lang<shell>
|
|
|
|
|
|
|
|
/home/ricmoo/ethers.js> npm run build-docs
|
|
|
|
|
|
|
|
|
|
|
|
_heading: Evaluation
|
|
|
|
|
|
|
|
When building the documentation, all code samples are run through a JavaScript
|
|
|
|
VM to ensure there are no typos in the example code, as well the exact output
|
|
|
|
of results are injected into the output, so there is no need to keep the results
|
|
|
|
and code in-sync.
|
|
|
|
|
|
|
|
However, this can be a bit of a headache when making many small changes, so to
|
|
|
|
build the documentation faster, you can skip the evaluation step, which will
|
|
|
|
inject the code directly.
|
|
|
|
|
|
|
|
_code: Build docs skipping evaluation @lang<shell>
|
|
|
|
|
|
|
|
/home/ricmoo/ethers.js> npm run build-docs -- --skip-eval
|
|
|
|
|
|
|
|
|
|
|
|
_heading: Previewing Changes
|
|
|
|
|
|
|
|
To preview the changes locally, you can use any standard web server and run
|
|
|
|
from the ``/docs/`` folder, or use the built-in web server.
|
|
|
|
|
|
|
|
The same caveats as normal web development apply, such flushing browser
|
|
|
|
caches after changing (and re-building) the docs.
|
|
|
|
|
|
|
|
_code: Running a webserver @lang<shell>
|
|
|
|
|
|
|
|
/home/ricmoo/ethers.js> npm run serve-docs
|