tornado-packages/ethers.js
1
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fail early for ABI decoding that will obviously run out of data (#1486).

Browse Source
This commit is contained in:
Richard Moore 2021-04-19 20:26:05 -04:00
parent c086962302
commit 51f0e1a52f
No known key found for this signature in database
GPG Key ID: 665176BE8E9DC651
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
packages/abi/src.ts/coders/array.ts
View File

@ -212,8 +212,19 @@ export class ArrayCoder extends Coder {
let count = this.length;
if (count === -1) {
count = reader.readValue().toNumber();
}
// Check that there is *roughly* enough data to ensure
// stray random data is not being read as a length. Each
// slot requires at least 32 bytes for their value (or 32
// bytes as a link to the data). This could use a much
// tighter bound, but we are erroring on the side of safety.
if (count * 32 > reader._data.length) {
logger.throwError("insufficient data length", Logger.errors.BUFFER_OVERRUN, {
length: reader._data.length,
count: count
});
}
}
let coders = [];
for (let i = 0; i < count; i++) { coders.push(new AnonymousCoder(this.coder)); }