tornado-packages/ethers.js
1
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed empty transaction field bug.

Browse Source
This commit is contained in:
ricmoo 2016-08-07 15:18:42 -04:00
parent 3c67736cbb
commit 9c1d6051fb
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/wallet.js
View File

@ -76,7 +76,7 @@ function Wallet(privateKey, provider) {
value = utils.hexOrBuffer(utils.hexlify(value), fieldInfo.name);
// Fixed-width field
if (fieldInfo.length && value.length !== fieldInfo.length) {
if (fieldInfo.length && value.length !== fieldInfo.length && value.length > 0) {
var error = new Error('invalid ' + fieldInfo.name);
error.reason = 'wrong length';
error.value = value;

13
tests/test-transactions.js
View File

@ -75,6 +75,19 @@ module.exports = function(test) {
s: "0x29ae9893dac4f9afb1af743e25fbb6a63f7879a61437203cb48c997b0fcefc3a"
});
// Test all possible blank fields
var privateKey = new Buffer('0123456789012345678901234567890123456789012345678901234567890123', 'hex');
for (var i = 0; i < 64; i++) {
var transaction = {};
if (i & (1 << 0)) { transaction.nonce = '0x02'; }
if (i & (1 << 1)) { transaction.gasPrice = '0x03'; }
if (i & (1 << 2)) { transaction.gasLimit = '0x04'; }
if (i & (1 << 3)) { transaction.to = '0x0123456789012345678901234567890123456789'; }
if (i & (1 << 4)) { transaction.value = '0x05'; }
if (i & (1 << 5)) { transaction.data = '0x06'; }
testTransaction(privateKey, transaction);
}
test.done();
};