tornadocash/classic-ui
2
0
Fork 2
Code Issues 10 Pull Requests 1 Packages Projects Releases 5 Wiki Activity

Community build #002 #2

Closed
gozzy wants to merge 0 commits from staging into master
pull from: staging
merge into: tornadocash:master
Conversation 1 Commits - Files Changed -
gozzy commented 2022-09-19 08:40:05 +03:00 (Migrated from development.tornadocash.community)
Copy Link

  • Reduced event cache size by depreciating the unecessary "zip-local" package over the already existing "jszip" package, which wasn't being used for compression. It also allowed to maximising the compression ratio which resulted in a 1% compression gain over the legacy method.

  • Improved the deposit modal UI disclaimer about account recovery.

  • Resolved event caching detection issues, as the array.indexOf query was giving false positives since the bool condition only enforced !== 0. When in actually an incorrect query returns -1, decision was to replace it with array.includes.

  • Resolved RPC fetching conflicts, as the lastBlock reference from getEventsFromCache and getEventsFromDBincorrectly indexed the last value in the array as the last synced event. This was resolved by forcing sorting events in ascending order.

* Reduced event cache size by depreciating the unecessary "zip-local" package over the already existing "jszip" package, which wasn't being used for compression. It also allowed to maximising the compression ratio which resulted in a 1% compression gain over the legacy method. * Improved the deposit modal UI disclaimer about account recovery. ![](https://i.imgur.com/s7ut8pE.png) * Resolved event caching detection issues, as the `array.indexOf` query was giving false positives since the bool condition only enforced `!== 0`. When in actually an incorrect query returns `-1`, decision was to replace it with `array.includes`. * Resolved RPC fetching conflicts, as the `lastBlock` reference from `getEventsFromCache` and `getEventsFromDB`incorrectly indexed the last value in the array as the last synced event. This was resolved by forcing sorting events in ascending order.
gozzy commented 2022-09-20 22:00:33 +03:00 (Migrated from development.tornadocash.community)
Copy Link

Closed, too messy history.

Closed, too messy history.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
BUG
Something is not working
ENHANCEMENT
New feature
QUESTION
More information is needed
RESEARCH
Open design goal
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: tornadocash/classic-ui#2
No description provided.
Delete Branch "staging"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?