Community build #002 #3

anon · 2022-09-20T22:01:57+03:00

gozzy commented

2022-09-20 22:01:57 +03:00

(Migrated from development.tornadocash.community)

Reduced event cache size by depreciating the unecessary "zip-local" package over the already existing "jszip" package, which wasn't being used for compression. It also allowed to maximising the compression ratio which resulted in a 1% compression gain over the legacy method.
Improved the deposit modal UI disclaimer about note backups in place of suggesting on-chain note recovery - which in of itself is a privacy contingency.

Resolved event caching detection issues, as the array.indexOf query was giving false positives since the bool condition only enforced !== 0. When in actually an incorrect query returns -1, decision was to replace it with array.includes.
Resolved RPC fetching conflicts, as the lastBlock reference from getEventsFromDB is incorrectly indexed as IndexedDB does not maintain assortment. This was resolved by forcing sorting events as they are originally sorted each time it is queried, which isn't ideal but shall be improved in future updates.

* Reduced event cache size by depreciating the unecessary "zip-local" package over the already existing "jszip" package, which wasn't being used for compression. It also allowed to maximising the compression ratio which resulted in a 1% compression gain over the legacy method. * Improved the deposit modal UI disclaimer about note backups in place of suggesting on-chain note recovery - which in of itself is a privacy contingency. ![](https://i.imgur.com/hOS1yxq.png) * Resolved event caching detection issues, as the `array.indexOf` query was giving false positives since the bool condition only enforced `!== 0`. When in actually an incorrect query returns `-1`, decision was to replace it with `array.includes`. * Resolved RPC fetching conflicts, as the `lastBlock` reference from `getEventsFromDB` is incorrectly indexed as IndexedDB does not maintain assortment. This was resolved by forcing sorting events as they are originally sorted each time it is queried, which isn't ideal but shall be improved in future updates.

anon referenced this pull request

2023-07-04 20:15:42 +03:00

PR #3: Add timeout to fetching proving key #27

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: tornadocash/classic-ui#3