Community build #002 #2

Closed
gozzy wants to merge 0 commits from staging into master
  • Reduced event cache size by depreciating the unecessary "zip-local" package over the already existing "jszip" package, which wasn't being used for compression. It also allowed to maximising the compression ratio which resulted in a 1% compression gain over the legacy method.

  • Improved the deposit modal UI disclaimer about account recovery.

  • Resolved event caching detection issues, as the array.indexOf query was giving false positives since the bool condition only enforced !== 0. When in actually an incorrect query returns -1, decision was to replace it with array.includes.

  • Resolved RPC fetching conflicts, as the lastBlock reference from getEventsFromCache and getEventsFromDBincorrectly indexed the last value in the array as the last synced event. This was resolved by forcing sorting events in ascending order.

* Reduced event cache size by depreciating the unecessary "zip-local" package over the already existing "jszip" package, which wasn't being used for compression. It also allowed to maximising the compression ratio which resulted in a 1% compression gain over the legacy method. * Improved the deposit modal UI disclaimer about account recovery. ![](https://i.imgur.com/s7ut8pE.png) * Resolved event caching detection issues, as the `array.indexOf` query was giving false positives since the bool condition only enforced `!== 0`. When in actually an incorrect query returns `-1`, decision was to replace it with `array.includes`. * Resolved RPC fetching conflicts, as the `lastBlock` reference from `getEventsFromCache` and `getEventsFromDB`incorrectly indexed the last value in the array as the last synced event. This was resolved by forcing sorting events in ascending order.

Closed, too messy history.

Closed, too messy history.

Pull request closed

Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tornadocash/classic-ui#2
No description provided.