tornadocash/tornado-cli
3
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

1. Modify the subgraph of config.js, delete unused chains, and add ensSubdomainKey to each chain #3

Merged
Theo merged 1 commits from nanli777torn/tornado-cli:master into master 2025-03-20 20:16:50 +03:00
Conversation 2 Commits 1 Files Changed 5 +356 -116
nanli777torn commented 2025-03-19 04:03:21 +03:00
Contributor
  1. Modify cli.js to support subgraph use
  2. Add relayerslist to allow users to obtain relayers data
2. Modify cli.js to support subgraph use 3. Add relayerslist to allow users to obtain relayers data
nanli777torn added 1 commit 2025-03-19 04:03:22 +03:00 
2. Modify cli.js to support subgraph use
3. Add relayerslist to allow users to obtain relayers data
Theo commented 2025-03-19 20:55:43 +03:00
Owner

Good first PR, Nanli, thanks for participation in Tornado Cash development! But there are some problems by design and that I found with my tests:

  1. CLI is designed as one-file program for easy code review by end users. I recommend to move relayerlist.js functionality to main file and add comments on English.
  2. Default RPCs still aren't working, if you fix the subgraphs, you may want to update it also.
  3. Your subgraph has strict limits and users cannot interact with it through TOR or blacklisted VPNs.

I can fix all these issues myself, or I can leave it for you, if you want to improve your coding skills. Please, let me know about your decision.

Good first PR, Nanli, thanks for participation in Tornado Cash development! But there are some problems by design and that I found with my tests: 1. CLI is designed as one-file program for easy code review by end users. I recommend to move `relayerlist.js` functionality to main file and add comments on English. 2. Default RPCs still aren't working, if you fix the subgraphs, you may want to update it also. 3. Your subgraph has strict limits and users cannot interact with it through TOR or blacklisted VPNs. I can fix all these issues myself, or I can leave it for you, if you want to improve your coding skills. Please, let me know about your decision.
nanli777torn commented 2025-03-20 05:03:50 +03:00
Author
Contributor

I don’t have that much time to research TOR or blacklist VPNs right now.

So modifying the code is up to you.

But I will learn from your modified code.

I don’t have that much time to research TOR or blacklist VPNs right now. So modifying the code is up to you. But I will learn from your modified code.
Theo merged commit cf530416a0 into master 2025-03-20 20:16:50 +03:00
Sign in to join this conversation.
No Reviewers
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: tornadocash/tornado-cli#3
No description provided.
Delete Branch "nanli777torn/tornado-cli:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?