core/vm: dedup config check in markdown logger (#21655)

* core/vm: dedup config check

* review feedback: reuse buffer
This commit is contained in:
Guillaume Ballet 2020-10-08 14:03:24 +02:00 committed by GitHub
parent 5e86e4ed29
commit 43cd31ea9f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -322,20 +322,21 @@ func (t *mdLogger) CaptureStart(from common.Address, to common.Address, create b
func (t *mdLogger) CaptureState(env *EVM, pc uint64, op OpCode, gas, cost uint64, memory *Memory, stack *Stack, rStack *ReturnStack, rData []byte, contract *Contract, depth int, err error) error { func (t *mdLogger) CaptureState(env *EVM, pc uint64, op OpCode, gas, cost uint64, memory *Memory, stack *Stack, rStack *ReturnStack, rData []byte, contract *Contract, depth int, err error) error {
fmt.Fprintf(t.out, "| %4d | %10v | %3d |", pc, op, cost) fmt.Fprintf(t.out, "| %4d | %10v | %3d |", pc, op, cost)
if !t.cfg.DisableStack { // format stack if !t.cfg.DisableStack {
// format stack
var a []string var a []string
for _, elem := range stack.data { for _, elem := range stack.data {
a = append(a, fmt.Sprintf("%d", elem)) a = append(a, fmt.Sprintf("%d", elem))
} }
b := fmt.Sprintf("[%v]", strings.Join(a, ",")) b := fmt.Sprintf("[%v]", strings.Join(a, ","))
fmt.Fprintf(t.out, "%10v |", b) fmt.Fprintf(t.out, "%10v |", b)
}
if !t.cfg.DisableStack { // format return stack // format return stack
var a []string a = a[:0]
for _, elem := range rStack.data { for _, elem := range rStack.data {
a = append(a, fmt.Sprintf("%2d", elem)) a = append(a, fmt.Sprintf("%2d", elem))
} }
b := fmt.Sprintf("[%v]", strings.Join(a, ",")) b = fmt.Sprintf("[%v]", strings.Join(a, ","))
fmt.Fprintf(t.out, "%10v |", b) fmt.Fprintf(t.out, "%10v |", b)
} }
fmt.Fprintln(t.out, "") fmt.Fprintln(t.out, "")