tornadocontrib/bsc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

eth/protocols: add Withdrawals check before broadcastBlock

Browse Source
This commit is contained in:
buddh0 2024-09-04 16:39:15 +08:00
parent d141ff06c3
commit 5289ecdfe2
1 changed files with 4 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
eth/handler.go
View File

@ -320,23 +320,12 @@ func newHandler(config *handlerConfig) (*handler, error) {
} }
broadcastBlockWithCheck := func(block *types.Block, propagate bool) { broadcastBlockWithCheck := func(block *types.Block, propagate bool) {
// All the block fetcher activities should be disabled if propagate {
// after the transition. Print the warning log. if !(block.Header().WithdrawalsHash == nil && block.Withdrawals() == nil) &&
if h.merger.PoSFinalized() { !(block.Header().EmptyWithdrawalsHash() && block.Withdrawals() != nil && len(block.Withdrawals()) == 0) {
log.Warn("Unexpected validation activity", "hash", block.Hash(), "number", block.Number()) log.Error("Propagated block has invalid withdrawals")
return
}
// Reject all the PoS style headers in the first place. No matter
// the chain has finished the transition or not, the PoS headers
// should only come from the trusted consensus layer instead of
// p2p network.
if beacon, ok := h.chain.Engine().(*beacon.Beacon); ok {
if beacon.IsPoSHeader(block.Header()) {
log.Warn("unexpected post-merge header")
return return
} }
}
if propagate {
if err := core.IsDataAvailable(h.chain, block); err != nil { if err := core.IsDataAvailable(h.chain, block); err != nil {
log.Error("Propagating block with invalid sidecars", "number", block.Number(), "hash", block.Hash(), "err", err) log.Error("Propagating block with invalid sidecars", "number", block.Number(), "hash", block.Hash(), "err", err)
return return