From 863fdea026818c976d8bba2a35c2e1ca7f4323da Mon Sep 17 00:00:00 2001 From: buddho Date: Wed, 10 Jul 2024 14:46:11 +0800 Subject: [PATCH] core: avoid to cache block before wroten into db (#2566) --- core/blockchain.go | 9 --------- 1 file changed, 9 deletions(-) diff --git a/core/blockchain.go b/core/blockchain.go index f6f9a22c8..a3998306b 100644 --- a/core/blockchain.go +++ b/core/blockchain.go @@ -657,13 +657,6 @@ func (bc *BlockChain) cacheDiffLayer(diffLayer *types.DiffLayer, diffLayerCh cha } } -func (bc *BlockChain) cacheBlock(hash common.Hash, block *types.Block) { - bc.blockCache.Add(hash, block) - if bc.chainConfig.IsCancun(block.Number(), block.Time()) { - bc.sidecarsCache.Add(hash, block.Sidecars()) - } -} - // empty returns an indicator whether the blockchain is empty. // Note, it's a special case that we connect a non-empty ancient // database with an empty node, so that we can plugin the ancient @@ -2282,8 +2275,6 @@ func (bc *BlockChain) insertChain(chain types.Blocks, setHead bool) (int, error) vtime := time.Since(vstart) proctime := time.Since(start) // processing + validation - bc.cacheBlock(block.Hash(), block) - // Update the metrics touched during block processing and validation accountReadTimer.Update(statedb.AccountReads) // Account reads are complete(in processing) storageReadTimer.Update(statedb.StorageReads) // Storage reads are complete(in processing)