Compare commits

...

3 Commits

Author SHA1 Message Date
Larry
48aaee69e9 Merge pull request #1474 from brilliant-lx/fix_waitgroup_master
release: prepare for release v1.1.23
2023-04-17 11:40:38 +08:00
larry.lx
dbe1f20bad release: prepare for release v1.1.23 2023-04-16 18:52:17 +08:00
Larry
9d4f94fa45 fix: panic on using WaitGroup after it is freed (#1464) 2023-04-16 15:37:40 +08:00
3 changed files with 9 additions and 3 deletions

View File

@@ -1,4 +1,8 @@
# Changelog # Changelog
## v1.1.23
BUGFIX
* [\#1464](https://github.com/bnb-chain/bsc/pull/1464) fix: panic on using WaitGroup after it is freed
## v1.1.22 ## v1.1.22
FEATURE FEATURE
* [\#1361](https://github.com/bnb-chain/bsc/pull/1361) cmd/faucet: merge ipfaucet2 branch to develop * [\#1361](https://github.com/bnb-chain/bsc/pull/1361) cmd/faucet: merge ipfaucet2 branch to develop

View File

@@ -1546,18 +1546,20 @@ func (bc *BlockChain) writeBlockWithState(block *types.Block, receipts []*types.
} }
} }
// Garbage collect anything below our required write retention // Garbage collect anything below our required write retention
wg2 := sync.WaitGroup{}
for !bc.triegc.Empty() { for !bc.triegc.Empty() {
root, number := bc.triegc.Pop() root, number := bc.triegc.Pop()
if uint64(-number) > chosen { if uint64(-number) > chosen {
bc.triegc.Push(root, number) bc.triegc.Push(root, number)
break break
} }
wg.Add(1) wg2.Add(1)
go func() { go func() {
triedb.Dereference(root.(common.Hash)) triedb.Dereference(root.(common.Hash))
wg.Done() wg2.Done()
}() }()
} }
wg2.Wait()
} }
} }
return nil return nil

View File

@@ -23,7 +23,7 @@ import (
const ( const (
VersionMajor = 1 // Major version component of the current release VersionMajor = 1 // Major version component of the current release
VersionMinor = 1 // Minor version component of the current release VersionMinor = 1 // Minor version component of the current release
VersionPatch = 22 // Patch version component of the current release VersionPatch = 23 // Patch version component of the current release
VersionMeta = "" // Version metadata to append to the version string VersionMeta = "" // Version metadata to append to the version string
) )