bsc/eth
gary rong b9df7ecdc3
all: seperate consensus error and evm internal error (#20830)
* all: seperate consensus error and evm internal error

There are actually two types of error will be returned when
a tranaction/message call is executed: (a) consensus error
(b) evm internal error. The former should be converted to
a consensus issue, e.g. The sender doesn't enough asset to
purchase the gas it specifies. The latter is allowed since
evm itself is a blackbox and internal error is allowed to happen.

This PR emphasizes the difference by introducing a executionResult
structure. The evm error is embedded inside. So if any error
returned, it indicates consensus issue happens.

And also this PR improve the `EstimateGas` API to return the concrete
revert reason if the transaction always fails

* all: polish

* accounts/abi/bind/backends: add tests

* accounts/abi/bind/backends, internal: cleanup error message

* all: address comments

* core: fix lint

* accounts, core, eth, internal: address comments

* accounts, internal: resolve revert reason if possible

* accounts, internal: address comments
2020-04-22 11:25:36 +03:00
..
downloader build: upgrade to golangci-lint 1.24.0 (#20901) 2020-04-08 11:07:29 +03:00
fetcher eth/fetcher: add missing timer.Stop calls (#20861) 2020-04-02 12:32:45 +02:00
filters all: simplify and fix database iteration with prefix/start (#20808) 2020-04-15 14:08:53 +03:00
gasprice cmd, core, eth, miner, params: configurable gas floor and ceil 2018-08-29 12:40:12 +03:00
tracers all: seperate consensus error and evm internal error (#20830) 2020-04-22 11:25:36 +03:00
api_backend.go internal/ethapi: don't set sender-balance to maxuint, fixes #16999 (#20783) 2020-03-23 18:21:23 +01:00
api_test.go eth: add debug_accountRange API (#19645) 2020-03-31 12:08:44 +02:00
api_tracer.go all: seperate consensus error and evm internal error (#20830) 2020-04-22 11:25:36 +03:00
api.go eth: add debug_accountRange API (#19645) 2020-03-31 12:08:44 +02:00
backend.go cmd, core: remove override muir glacier and override istanbul (#20942) 2020-04-20 12:46:38 +03:00
bloombits.go eth: improve shutdown synchronization (#20695) 2020-03-27 15:03:20 +02:00
config.go cmd, core: remove override muir glacier and override istanbul (#20942) 2020-04-20 12:46:38 +03:00
discovery.go cmd/geth: enable DNS discovery by default (#20660) 2020-02-13 15:38:30 +02:00
gen_config.go cmd, core: remove override muir glacier and override istanbul (#20942) 2020-04-20 12:46:38 +03:00
handler_test.go all: simplify and fix database iteration with prefix/start (#20808) 2020-04-15 14:08:53 +03:00
handler.go eth: improve shutdown synchronization (#20695) 2020-03-27 15:03:20 +02:00
helper_test.go eth: improve shutdown synchronization (#20695) 2020-03-27 15:03:20 +02:00
peer.go eth: fix transaction announce/broadcast goroutine leak 2020-03-13 23:47:15 +02:00
protocol_test.go eth: improve shutdown synchronization (#20695) 2020-03-27 15:03:20 +02:00
protocol.go eth: rework tx fetcher to use O(1) ops + manage network requests 2020-02-13 15:27:15 +02:00
sync_test.go eth: improve shutdown synchronization (#20695) 2020-03-27 15:03:20 +02:00
sync.go eth: improve shutdown synchronization (#20695) 2020-03-27 15:03:20 +02:00