bsc/p2p/discover
Felix Lange f0c6f92140
p2p/discover, p2p/enode: rework endpoint proof handling, packet logging (#18963)
This change resolves multiple issues around handling of endpoint proofs.
The proof is now done separately for each IP and completing the proof
requires a matching ping hash.

Also remove waitping because it's equivalent to sleep. waitping was
slightly more efficient, but that may cause issues with findnode if
packets are reordered and the remote end sees findnode before pong.

Logging of received packets was hitherto done after handling the packet,
which meant that sent replies were logged before the packet that
generated them. This change splits up packet handling into 'preverify'
and 'handle'. The error from 'preverify' is logged, but 'handle' happens
after the message is logged. This fixes the order. Packet logs now
contain the node ID.
2019-01-29 17:39:20 +01:00
..
node.go p2p/discover, p2p/enode: rework endpoint proof handling, packet logging (#18963) 2019-01-29 17:39:20 +01:00
ntp.go p2p, p2p/discover, p2p/nat: rework logging using context keys 2017-02-28 10:20:29 +01:00
table_test.go p2p/discover, p2p/enode: rework endpoint proof handling, packet logging (#18963) 2019-01-29 17:39:20 +01:00
table_util_test.go p2p/discover, p2p/enode: rework endpoint proof handling, packet logging (#18963) 2019-01-29 17:39:20 +01:00
table.go p2p/discover, p2p/enode: rework endpoint proof handling, packet logging (#18963) 2019-01-29 17:39:20 +01:00
udp_test.go p2p/discover, p2p/enode: rework endpoint proof handling, packet logging (#18963) 2019-01-29 17:39:20 +01:00
udp.go p2p/discover, p2p/enode: rework endpoint proof handling, packet logging (#18963) 2019-01-29 17:39:20 +01:00