bsc/accounts
Marius van der Wijden f3f1e59eea
accounts/abi: simplify reflection logic (#21058)
* accounts/abi: simplified reflection logic

* accounts/abi: simplified reflection logic

* accounts/abi: removed unpack

* accounts/abi: removed comments

* accounts/abi: removed uneccessary complications

* accounts/abi: minor changes in error messages

* accounts/abi: removed unnused code

* accounts/abi: fixed indexed argument unpacking

* accounts/abi: removed superfluous test cases

This commit removes two test cases. The first one is trivially invalid as we have the same
test cases as passing in packing_test.go L375. The second one passes now,
because we don't need the mapArgNamesToStructFields in unpack_atomic anymore.
Checking for purely underscored arg names generally should not be something we do
as the abi/contract is generally out of the control of the user.

* accounts/abi: removed comments, debug println

* accounts/abi: added commented out code

* accounts/abi: addressed comments

* accounts/abi: remove unnecessary dst.CanSet check

* accounts/abi: added dst.CanSet checks
2020-05-13 17:50:18 +02:00
..
abi accounts/abi: simplify reflection logic (#21058) 2020-05-13 17:50:18 +02:00
external accounts/external: convert signature v value to 0/1 (#20997) 2020-05-01 13:52:41 +02:00
keystore accounts/keystore: fix double import race (#20915) 2020-04-22 12:52:29 +03:00
scwallet build: upgrade to golangci-lint 1.24.0 (#20901) 2020-04-08 11:07:29 +03:00
usbwallet accounts/usbwallet: fix staticcheck warnings (#20372) 2019-11-29 11:47:14 +01:00
accounts_test.go all: update author list and licenses 2019-07-22 12:17:27 +03:00
accounts.go accounts/external: convert signature v value to 0/1 (#20997) 2020-05-01 13:52:41 +02:00
errors.go all: replace passPHRASE with passWORD in user interactions (#19932) 2019-08-12 12:00:38 +03:00
hd_test.go accounts: refactor API for generalized USB wallets 2017-08-09 13:26:07 +03:00
hd.go accounts: switch Ledger derivation path to canonical one 2019-04-10 13:09:08 +03:00
manager.go accounts: add walletsNoLock to avoid double read lock (#20655) 2020-02-12 15:20:50 +01:00
sort.go accounts, console: frendly card errors, support pin unblock 2019-04-08 13:19:37 +02:00
url_test.go all: update author list and licenses 2019-07-22 12:17:27 +03:00
url.go accounts: add unit tests for URL (#17182) 2018-07-18 11:32:49 +03:00