tornadocontrib/git-arr
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
cacf2ee2cc
git-arr/views/tree.html

58 lines
1.6 KiB
HTML
Raw Normal View History

Initial commit Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
2012-09-16 13:17:56 +03:00
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
% if not dirname.raw:
views: fix broken URLs involving hierarchical branch names Git branch names can be hierarchical (for example, "wip/parser/fix"), however, git-arr does not take this into account when formulating URLs on branch, tree, and blobs pages. These URLs are dysfunctional because it is assumed incorrectly that a single "../" is sufficient to climb over the branch name when computing relative paths to resources higher in the hierarchy. This problem manifests as failure to load static resources (stylesheet, etc.), broken links to commits on branch pages, and malfunctioning breadcrumb trails. Fix this problem by computing the the proper number of "../" based upon the branch name, rather than assuming that a single "../" will work unconditionally. (This is analogous to the treatment already given to hierarchical pathnames in tree and blob views.) Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
2014-12-31 11:50:08 +02:00
% reltree = './'
Initial commit Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
2012-09-16 13:17:56 +03:00
% else:
views: fix broken URLs involving hierarchical branch names Git branch names can be hierarchical (for example, "wip/parser/fix"), however, git-arr does not take this into account when formulating URLs on branch, tree, and blobs pages. These URLs are dysfunctional because it is assumed incorrectly that a single "../" is sufficient to climb over the branch name when computing relative paths to resources higher in the hierarchy. This problem manifests as failure to load static resources (stylesheet, etc.), broken links to commits on branch pages, and malfunctioning breadcrumb trails. Fix this problem by computing the the proper number of "../" based upon the branch name, rather than assuming that a single "../" will work unconditionally. (This is analogous to the treatment already given to hierarchical pathnames in tree and blob views.) Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
2014-12-31 11:50:08 +02:00
% reltree = '../' * (len(dirname.split('/')) - 1)
Initial commit Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
2012-09-16 13:17:56 +03:00
% end
tree: pass branch name to view explicitly Passing the branch name into the view indirectly via Repo.new_in_branch() increases cognitive burden, thus outweighing whatever minor convenience (if any) is gained by doing so. The code is easier to reason about when the branch name is passed to the view directly. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
2015-01-14 09:46:32 +02:00
% relroot = reltree + '../' * (len(branch.split('/')) - 1)
Initial commit Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
2012-09-16 13:17:56 +03:00
<title>git &raquo; {{repo.name}} &raquo;
views/tree: signify root directory in page title The page title in a root tree displays as "git >> repo >> branch >>", which looks odd and fails to convey the fact that the page represents a tree. Appending a '/' (for example "git >> repo >> branch >> /") makes it more obvious that the page shows a tree, in general, and the root tree, in particular. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
2015-01-24 00:14:25 +02:00
{{branch}} &raquo; {{dirname.unicode if dirname.unicode else '/'}}</title>
Initial commit Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
2012-09-16 13:17:56 +03:00
<link rel="stylesheet" type="text/css"
href="{{relroot}}../../../../../static/git-arr.css"/>
<meta http-equiv="content-type" content="text/html; charset=utf-8"/>
</head>
<body class="tree">
<h1><a href="{{relroot}}../../../../../">git</a> &raquo;
<a href="{{relroot}}../../../">{{repo.name}}</a> &raquo;
tree: pass branch name to view explicitly Passing the branch name into the view indirectly via Repo.new_in_branch() increases cognitive burden, thus outweighing whatever minor convenience (if any) is gained by doing so. The code is easier to reason about when the branch name is passed to the view directly. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
2015-01-14 09:46:32 +02:00
<a href="{{reltree}}../">{{branch}}</a> &raquo;
views: fix broken URLs involving hierarchical branch names Git branch names can be hierarchical (for example, "wip/parser/fix"), however, git-arr does not take this into account when formulating URLs on branch, tree, and blobs pages. These URLs are dysfunctional because it is assumed incorrectly that a single "../" is sufficient to climb over the branch name when computing relative paths to resources higher in the hierarchy. This problem manifests as failure to load static resources (stylesheet, etc.), broken links to commits on branch pages, and malfunctioning breadcrumb trails. Fix this problem by computing the the proper number of "../" based upon the branch name, rather than assuming that a single "../" will work unconditionally. (This is analogous to the treatment already given to hierarchical pathnames in tree and blob views.) Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
2014-12-31 11:50:08 +02:00
<a href="{{reltree}}">tree</a>
Initial commit Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
2012-09-16 13:17:56 +03:00
</h1>
<h3>
tree: pass branch name to view explicitly Passing the branch name into the view indirectly via Repo.new_in_branch() increases cognitive burden, thus outweighing whatever minor convenience (if any) is gained by doing so. The code is easier to reason about when the branch name is passed to the view directly. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
2015-01-14 09:46:32 +02:00
<a href="{{reltree}}">[{{branch}}]</a> /
views: fix broken URLs involving hierarchical branch names Git branch names can be hierarchical (for example, "wip/parser/fix"), however, git-arr does not take this into account when formulating URLs on branch, tree, and blobs pages. These URLs are dysfunctional because it is assumed incorrectly that a single "../" is sufficient to climb over the branch name when computing relative paths to resources higher in the hierarchy. This problem manifests as failure to load static resources (stylesheet, etc.), broken links to commits on branch pages, and malfunctioning breadcrumb trails. Fix this problem by computing the the proper number of "../" based upon the branch name, rather than assuming that a single "../" will work unconditionally. (This is analogous to the treatment already given to hierarchical pathnames in tree and blob views.) Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
2014-12-31 11:50:08 +02:00
% base = smstr(reltree)
Initial commit Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
2012-09-16 13:17:56 +03:00
% for c in dirname.split('/'):
Fix one-line 'if' termination in tree, blob templates The missing '% end' template keyword to these one-line if statements was causing bottle 0.12.7 to incorrectly indent the following line, leading to an IndentationError at runtime when the blob and tree templates are compiled. Signed-off-by: Vanya Sergeev <vsergeev@gmail.com>
2014-06-30 09:02:18 +03:00
% if not c.raw:
% continue
% end
Initial commit Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
2012-09-16 13:17:56 +03:00
<a href="{{base.url}}{{c.url}}/">{{c.unicode}}</a> /
% base += c + '/'
% end
</h3>
<table class="nice ls">
views/tree.html: Fix lambda syntax Some versions of bottle.py don't deal well with the "if" inside the lambda, so work around it by just using comparison and simplifying the function. Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
2014-07-29 01:33:43 +03:00
% key_func = lambda (t, n, s): (t != 'tree', n.raw)
Initial commit Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
2012-09-16 13:17:56 +03:00
% for type, name, size in sorted(tree.ls(dirname.raw), key = key_func):
<tr class="{{type}}">
% if type == "blob":
<td class="name"><a href="./f={{name.url}}.html">
{{!name.html}}</a></td>
<td class="size">{{size}}</td>
% elif type == "tree":
<td class="name">
<a class="explicit" href="./{{name.url}}/">
{{!name.html}}/</a></td>
% end
</tr>
% end
</table>
</body>
</html>
Reference in New Issue Copy Permalink