From 7f2f67629f1d6b7c5046ae43c1a293137c89b4d3 Mon Sep 17 00:00:00 2001 From: Eric Sunshine Date: Thu, 1 Jan 2015 16:41:09 -0500 Subject: [PATCH] views: branch/paginate: teach "next" link to respect 'max_pages' Pagination link "next" does not respect 'max_pages', thus it incorrectly remains enabled on the final page capped by 'max_pages'. When clicked, the user is taken to a "404 Page not found" error page, which makes for a poor user experience. Fix this problem by teaching the "next" link to respect 'max_pages'. (As a side-effect, this also causes 'serve' mode to respect 'max_pages', which was not previously the case. This change of behavior is appropriate since it brings 'serve' mode, which is intended primarily for testing, more in line with 'generate' mode.) Signed-off-by: Eric Sunshine Signed-off-by: Alberto Bertogli --- views/branch.html | 1 + 1 file changed, 1 insertion(+) diff --git a/views/branch.html b/views/branch.html index a49150e..1cc011d 100644 --- a/views/branch.html +++ b/views/branch.html @@ -30,6 +30,7 @@ % if more: % commits = commits[:-1] % end +% more = more and offset + 1 < repo.info.max_pages % include paginate more = more, offset = offset