tornadocontrib/git-arr
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

branch: pass branch name view explicitly

Browse Source 
Passing the branch name into the view indirectly via
Repo.new_in_branch() increases cognitive burden, thus outweighing
whatever minor convenience (if any) is gained by doing so. The code is
easier to reason about when the branch name is passed to the view
directly.

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
This commit is contained in:
Eric Sunshine 2015-01-14 02:46:34 -05:00 committed by Alberto Bertogli
parent 37e731fc2e
commit 89a637660f
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
git-arr
View File

@ -263,7 +263,7 @@ def tree(repo, bname, dirname = ''):
@bottle.view('branch') @bottle.view('branch')
@with_utils @with_utils
def branch(repo, bname, offset = 0): def branch(repo, bname, offset = 0):
return dict(repo = repo.new_in_branch(bname), offset = offset) return dict(repo = repo, branch = bname, offset = offset)
@bottle.route('/static/<path:path>') @bottle.route('/static/<path:path>')
def static(path): def static(path):

8
views/branch.html
View File

@ -3,9 +3,9 @@
<html xmlns="http://www.w3.org/1999/xhtml"> <html xmlns="http://www.w3.org/1999/xhtml">
<head> <head>
% relroot = '../' * (len(repo.branch.split('/')) - 1) % relroot = '../' * (len(branch.split('/')) - 1)
<title>git &raquo; {{repo.name}} &raquo; {{repo.branch}}</title> <title>git &raquo; {{repo.name}} &raquo; {{branch}}</title>
<link rel="stylesheet" type="text/css" href="{{relroot}}../../../../static/git-arr.css"/> <link rel="stylesheet" type="text/css" href="{{relroot}}../../../../static/git-arr.css"/>
<meta http-equiv="content-type" content="text/html; charset=utf-8"/> <meta http-equiv="content-type" content="text/html; charset=utf-8"/>
</head> </head>
@ -13,14 +13,14 @@
<body class="branch"> <body class="branch">
<h1><a href="{{relroot}}../../../../">git</a> &raquo; <h1><a href="{{relroot}}../../../../">git</a> &raquo;
<a href="{{relroot}}../../">{{repo.name}}</a> &raquo; <a href="{{relroot}}../../">{{repo.name}}</a> &raquo;
<a href="./">{{repo.branch}}</a> <a href="./">{{branch}}</a>
</h1> </h1>
<p> <p>
<a class="explicit" href="t/">Browse current source tree</a> <a class="explicit" href="t/">Browse current source tree</a>
</p> </p>
% commits = repo.commits("refs/heads/" + repo.branch, % commits = repo.commits("refs/heads/" + branch,
% limit = repo.info.commits_per_page + 1, % limit = repo.info.commits_per_page + 1,
% offset = repo.info.commits_per_page * offset) % offset = repo.info.commits_per_page * offset)
% commits = list(commits) % commits = list(commits)