tornadocontrib/git-arr
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused/unnecessary code

Browse Source 
This patch removes some code that is unused and/or unnecessary. Most of
it is left over from previous situations, but is no longer needed.
This commit is contained in:
Alberto Bertogli 2020-05-25 02:04:55 +01:00
parent aee18d0edd
commit e2155f6b33
1 changed files with 3 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
git.py
View File

@ -64,17 +64,15 @@ def run_git(
class GitCommand(object): class GitCommand(object):
"""Convenient way of invoking git.""" """Convenient way of invoking git."""
def __init__(self, path: str, cmd: str, *args, **kwargs): def __init__(self, path: str, cmd: str):
self._override = True self._override = True
self._path = path self._path = path
self._cmd = cmd self._cmd = cmd
self._args: List[str] = list(args) self._args: List[str] = []
self._kwargs: Dict[str, str] = {} self._kwargs: Dict[str, str] = {}
self._stdin_buf: Optional[bytes] = None self._stdin_buf: Optional[bytes] = None
self._raw = False self._raw = False
self._override = False self._override = False
for k, v in kwargs:
self.__setattr__(k, v)
def __setattr__(self, k, v): def __setattr__(self, k, v):
if k == "_override" or self._override: if k == "_override" or self._override:
@ -93,11 +91,9 @@ class GitCommand(object):
self._raw = b self._raw = b
self._override = False self._override = False
def stdin(self, s: Union[str, bytes]): def stdin(self, s: bytes):
"""Sets the contents we will send in stdin.""" """Sets the contents we will send in stdin."""
self._override = True self._override = True
if isinstance(s, str):
s = s.encode("utf8")
self._stdin_buf = s self._stdin_buf = s
self._override = False self._override = False
@ -136,9 +132,6 @@ class smstr:
self.url = urllib.request.pathname2url(s) self.url = urllib.request.pathname2url(s)
self.html = self._to_html() self.html = self._to_html()
def __cmp__(self, other):
return cmp(self.raw, other.raw)
# Note we don't define __repr__() or __str__() to prevent accidental # Note we don't define __repr__() or __str__() to prevent accidental
# misuse. It does mean that some uses become more annoying, so it's a # misuse. It does mean that some uses become more annoying, so it's a
# tradeoff that may change in the future. # tradeoff that may change in the future.
@ -236,10 +229,6 @@ class Repo:
for obj_id, _, ref in refs: for obj_id, _, ref in refs:
yield ref[len("refs/tags/") :], obj_id yield ref[len("refs/tags/") :], obj_id
def tag_names(self):
"""Get the names of the tags."""
return (name for name, _ in self.tags())
def commit_ids(self, ref, limit=None): def commit_ids(self, ref, limit=None):
"""Generate commit ids.""" """Generate commit ids."""
cmd = self.cmd("rev-list") cmd = self.cmd("rev-list")