7f2f67629f
Pagination link "next" does not respect 'max_pages', thus it incorrectly remains enabled on the final page capped by 'max_pages'. When clicked, the user is taken to a "404 Page not found" error page, which makes for a poor user experience. Fix this problem by teaching the "next" link to respect 'max_pages'. (As a side-effect, this also causes 'serve' mode to respect 'max_pages', which was not previously the case. This change of behavior is appropriate since it brings 'serve' mode, which is intended primarily for testing, more in line with 'generate' mode.) Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
48 lines
1.3 KiB
HTML
48 lines
1.3 KiB
HTML
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
|
|
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
|
|
<html xmlns="http://www.w3.org/1999/xhtml">
|
|
<head>
|
|
<title>git » {{repo.name}} » {{repo.branch}}</title>
|
|
<link rel="stylesheet" type="text/css" href="../../../../static/git-arr.css"/>
|
|
<meta http-equiv="content-type" content="text/html; charset=utf-8"/>
|
|
</head>
|
|
|
|
<body class="branch">
|
|
<h1><a href="../../../../">git</a> »
|
|
<a href="../../">{{repo.name}}</a> »
|
|
<a href="./">{{repo.branch}}</a>
|
|
</h1>
|
|
|
|
<p>
|
|
<a class="explicit" href="t/">Browse current source tree</a>
|
|
</p>
|
|
|
|
% commits = repo.commits("refs/heads/" + repo.branch,
|
|
% limit = repo.info.commits_per_page + 1,
|
|
% offset = repo.info.commits_per_page * offset)
|
|
% commits = list(commits)
|
|
|
|
% if len(commits) == 0:
|
|
% abort(404, "No more commits")
|
|
% end
|
|
|
|
% more = len(commits) > repo.info.commits_per_page
|
|
% if more:
|
|
% commits = commits[:-1]
|
|
% end
|
|
% more = more and offset + 1 < repo.info.max_pages
|
|
|
|
% include paginate more = more, offset = offset
|
|
|
|
% kwargs = dict(repo=repo, commits=commits,
|
|
% shorten=shorten, repo_root="../..")
|
|
% include commit-list **kwargs
|
|
|
|
<p/>
|
|
|
|
% include paginate more = more, offset = offset
|
|
|
|
</body>
|
|
</html>
|
|
|