2015-10-05 19:37:56 +03:00
|
|
|
// Copyright 2015 The go-ethereum Authors
|
|
|
|
// This file is part of the go-ethereum library.
|
|
|
|
//
|
|
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
|
|
// (at your option) any later version.
|
|
|
|
//
|
|
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
// GNU Lesser General Public License for more details.
|
|
|
|
//
|
|
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
|
|
|
|
package state
|
|
|
|
|
|
|
|
import (
|
|
|
|
"bytes"
|
|
|
|
"math/big"
|
|
|
|
"testing"
|
|
|
|
|
|
|
|
"github.com/ethereum/go-ethereum/common"
|
2018-09-24 15:57:49 +03:00
|
|
|
"github.com/ethereum/go-ethereum/core/rawdb"
|
2015-12-28 15:20:37 +02:00
|
|
|
"github.com/ethereum/go-ethereum/crypto"
|
2015-10-05 19:37:56 +03:00
|
|
|
"github.com/ethereum/go-ethereum/ethdb"
|
2019-05-13 15:28:01 +03:00
|
|
|
"github.com/ethereum/go-ethereum/ethdb/memorydb"
|
2015-10-05 19:37:56 +03:00
|
|
|
"github.com/ethereum/go-ethereum/trie"
|
|
|
|
)
|
|
|
|
|
|
|
|
// testAccount is the data associated with an account used by the state tests.
|
|
|
|
type testAccount struct {
|
|
|
|
address common.Address
|
|
|
|
balance *big.Int
|
|
|
|
nonce uint64
|
|
|
|
code []byte
|
|
|
|
}
|
|
|
|
|
|
|
|
// makeTestState create a sample test state to test node-wise reconstruction.
|
2018-02-05 19:40:32 +03:00
|
|
|
func makeTestState() (Database, common.Hash, []*testAccount) {
|
2015-10-05 19:37:56 +03:00
|
|
|
// Create an empty state
|
2018-09-24 15:57:49 +03:00
|
|
|
db := NewDatabase(rawdb.NewMemoryDatabase())
|
2015-10-13 12:04:25 +03:00
|
|
|
state, _ := New(common.Hash{}, db)
|
2015-10-05 19:37:56 +03:00
|
|
|
|
|
|
|
// Fill it with some arbitrary data
|
|
|
|
accounts := []*testAccount{}
|
2015-12-28 15:20:37 +02:00
|
|
|
for i := byte(0); i < 96; i++ {
|
2015-10-05 19:37:56 +03:00
|
|
|
obj := state.GetOrNewStateObject(common.BytesToAddress([]byte{i}))
|
|
|
|
acc := &testAccount{address: common.BytesToAddress([]byte{i})}
|
|
|
|
|
|
|
|
obj.AddBalance(big.NewInt(int64(11 * i)))
|
|
|
|
acc.balance = big.NewInt(int64(11 * i))
|
|
|
|
|
|
|
|
obj.SetNonce(uint64(42 * i))
|
|
|
|
acc.nonce = uint64(42 * i)
|
|
|
|
|
|
|
|
if i%3 == 0 {
|
2016-10-01 15:44:53 +03:00
|
|
|
obj.SetCode(crypto.Keccak256Hash([]byte{i, i, i, i, i}), []byte{i, i, i, i, i})
|
2015-10-05 19:37:56 +03:00
|
|
|
acc.code = []byte{i, i, i, i, i}
|
|
|
|
}
|
2016-10-04 13:36:02 +03:00
|
|
|
state.updateStateObject(obj)
|
2015-10-05 19:37:56 +03:00
|
|
|
accounts = append(accounts, acc)
|
|
|
|
}
|
2018-02-05 19:40:32 +03:00
|
|
|
root, _ := state.Commit(false)
|
2015-10-05 19:37:56 +03:00
|
|
|
|
|
|
|
// Return the generated state
|
2018-02-05 19:40:32 +03:00
|
|
|
return db, root, accounts
|
2015-10-05 19:37:56 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
// checkStateAccounts cross references a reconstructed state with an expected
|
|
|
|
// account array.
|
|
|
|
func checkStateAccounts(t *testing.T, db ethdb.Database, root common.Hash, accounts []*testAccount) {
|
2015-12-28 15:20:37 +02:00
|
|
|
// Check root availability and state contents
|
2017-06-27 16:57:06 +03:00
|
|
|
state, err := New(root, NewDatabase(db))
|
2015-12-28 15:20:37 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("failed to create state trie at %x: %v", root, err)
|
|
|
|
}
|
|
|
|
if err := checkStateConsistency(db, root); err != nil {
|
|
|
|
t.Fatalf("inconsistent state trie at %x: %v", root, err)
|
|
|
|
}
|
|
|
|
for i, acc := range accounts {
|
2015-10-05 19:37:56 +03:00
|
|
|
if balance := state.GetBalance(acc.address); balance.Cmp(acc.balance) != 0 {
|
|
|
|
t.Errorf("account %d: balance mismatch: have %v, want %v", i, balance, acc.balance)
|
|
|
|
}
|
|
|
|
if nonce := state.GetNonce(acc.address); nonce != acc.nonce {
|
|
|
|
t.Errorf("account %d: nonce mismatch: have %v, want %v", i, nonce, acc.nonce)
|
|
|
|
}
|
2017-01-06 18:44:20 +03:00
|
|
|
if code := state.GetCode(acc.address); !bytes.Equal(code, acc.code) {
|
2015-10-05 19:37:56 +03:00
|
|
|
t.Errorf("account %d: code mismatch: have %x, want %x", i, code, acc.code)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-06-27 16:57:06 +03:00
|
|
|
// checkTrieConsistency checks that all nodes in a (sub-)trie are indeed present.
|
|
|
|
func checkTrieConsistency(db ethdb.Database, root common.Hash) error {
|
|
|
|
if v, _ := db.Get(root[:]); v == nil {
|
|
|
|
return nil // Consider a non existent state consistent.
|
|
|
|
}
|
2018-02-05 19:40:32 +03:00
|
|
|
trie, err := trie.New(root, trie.NewDatabase(db))
|
2017-06-27 16:57:06 +03:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
it := trie.NodeIterator(nil)
|
|
|
|
for it.Next(true) {
|
|
|
|
}
|
|
|
|
return it.Error()
|
|
|
|
}
|
|
|
|
|
|
|
|
// checkStateConsistency checks that all data of a state root is present.
|
2016-02-16 12:37:00 +02:00
|
|
|
func checkStateConsistency(db ethdb.Database, root common.Hash) error {
|
2015-12-28 15:20:37 +02:00
|
|
|
// Create and iterate a state trie rooted in a sub-node
|
|
|
|
if _, err := db.Get(root.Bytes()); err != nil {
|
2017-06-27 16:57:06 +03:00
|
|
|
return nil // Consider a non existent state consistent.
|
2015-12-28 15:20:37 +02:00
|
|
|
}
|
2017-06-27 16:57:06 +03:00
|
|
|
state, err := New(root, NewDatabase(db))
|
2015-12-28 15:20:37 +02:00
|
|
|
if err != nil {
|
2016-02-16 12:37:00 +02:00
|
|
|
return err
|
2015-12-28 15:20:37 +02:00
|
|
|
}
|
2016-02-16 12:37:00 +02:00
|
|
|
it := NewNodeIterator(state)
|
|
|
|
for it.Next() {
|
2015-12-28 15:20:37 +02:00
|
|
|
}
|
2016-02-16 12:37:00 +02:00
|
|
|
return it.Error
|
2015-12-28 15:20:37 +02:00
|
|
|
}
|
|
|
|
|
2015-10-05 19:37:56 +03:00
|
|
|
// Tests that an empty state is not scheduled for syncing.
|
|
|
|
func TestEmptyStateSync(t *testing.T) {
|
|
|
|
empty := common.HexToHash("56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421")
|
2019-05-13 15:28:01 +03:00
|
|
|
if req := NewStateSync(empty, rawdb.NewMemoryDatabase(), trie.NewSyncBloom(1, memorydb.New())).Missing(1); len(req) != 0 {
|
2015-10-05 19:37:56 +03:00
|
|
|
t.Errorf("content requested for empty state: %v", req)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Tests that given a root hash, a state can sync iteratively on a single thread,
|
|
|
|
// requesting retrieval tasks and returning all of them in one go.
|
|
|
|
func TestIterativeStateSyncIndividual(t *testing.T) { testIterativeStateSync(t, 1) }
|
|
|
|
func TestIterativeStateSyncBatched(t *testing.T) { testIterativeStateSync(t, 100) }
|
|
|
|
|
|
|
|
func testIterativeStateSync(t *testing.T, batch int) {
|
|
|
|
// Create a random state to copy
|
2018-02-05 19:40:32 +03:00
|
|
|
srcDb, srcRoot, srcAccounts := makeTestState()
|
2015-10-05 19:37:56 +03:00
|
|
|
|
|
|
|
// Create a destination state and sync with the scheduler
|
2018-09-24 15:57:49 +03:00
|
|
|
dstDb := rawdb.NewMemoryDatabase()
|
2019-05-13 15:28:01 +03:00
|
|
|
sched := NewStateSync(srcRoot, dstDb, trie.NewSyncBloom(1, dstDb))
|
2015-10-05 19:37:56 +03:00
|
|
|
|
|
|
|
queue := append([]common.Hash{}, sched.Missing(batch)...)
|
|
|
|
for len(queue) > 0 {
|
|
|
|
results := make([]trie.SyncResult, len(queue))
|
|
|
|
for i, hash := range queue {
|
2018-02-05 19:40:32 +03:00
|
|
|
data, err := srcDb.TrieDB().Node(hash)
|
2015-10-05 19:37:56 +03:00
|
|
|
if err != nil {
|
2018-02-05 19:40:32 +03:00
|
|
|
t.Fatalf("failed to retrieve node data for %x", hash)
|
2015-10-05 19:37:56 +03:00
|
|
|
}
|
2016-04-15 12:06:57 +03:00
|
|
|
results[i] = trie.SyncResult{Hash: hash, Data: data}
|
2015-10-05 19:37:56 +03:00
|
|
|
}
|
eth/downloader: separate state sync from queue (#14460)
* eth/downloader: separate state sync from queue
Scheduling of state node downloads hogged the downloader queue lock when
new requests were scheduled. This caused timeouts for other requests.
With this change, state sync is fully independent of all other downloads
and doesn't involve the queue at all.
State sync is started and checked on in processContent. This is slightly
awkward because processContent doesn't have a select loop. Instead, the
queue is closed by an auxiliary goroutine when state sync fails. We
tried several alternatives to this but settled on the current approach
because it's the least amount of change overall.
Handling of the pivot block has changed slightly: the queue previously
prevented import of pivot block receipts before the state of the pivot
block was available. In this commit, the receipt will be imported before
the state. This causes an annoyance where the pivot block is committed
as fast block head even when state downloads fail. Stay tuned for more
updates in this area ;)
* eth/downloader: remove cancelTimeout channel
* eth/downloader: retry state requests on timeout
* eth/downloader: improve comment
* eth/downloader: mark peers idle when state sync is done
* eth/downloader: move pivot block splitting to processContent
This change also ensures that pivot block receipts aren't imported
before the pivot block itself.
* eth/downloader: limit state node retries
* eth/downloader: improve state node error handling and retry check
* eth/downloader: remove maxStateNodeRetries
It fails the sync too much.
* eth/downloader: remove last use of cancelCh in statesync.go
Fixes TestDeliverHeadersHang*Fast and (hopefully)
the weird cancellation behaviour at the end of fast sync.
* eth/downloader: fix leak in runStateSync
* eth/downloader: don't run processFullSyncContent in LightSync mode
* eth/downloader: improve comments
* eth/downloader: fix vet, megacheck
* eth/downloader: remove unrequested tasks anyway
* eth/downloader, trie: various polishes around duplicate items
This commit explicitly tracks duplicate and unexpected state
delieveries done against a trie Sync structure, also adding
there to import info logs.
The commit moves the db batch used to commit trie changes one
level deeper so its flushed after every node insertion. This
is needed to avoid a lot of duplicate retrievals caused by
inconsistencies between Sync internals and database. A better
approach is to track not-yet-written states in trie.Sync and
flush on commit, but I'm focuing on correctness first now.
The commit fixes a regression around pivot block fail count.
The counter previously was reset to 1 if and only if a sync
cycle progressed (inserted at least 1 entry to the database).
The current code reset it already if a node was delivered,
which is not stong enough, because unless it ends up written
to disk, an attacker can just loop and attack ad infinitum.
The commit also fixes a regression around state deliveries
and timeouts. The old downloader tracked if a delivery is
stale (none of the deliveries were requestedt), in which
case it didn't mark the node idle and did not send further
requests, since it signals a past timeout. The current code
did mark it idle even on stale deliveries, which eventually
caused two requests to be in flight at the same time, making
the deliveries always stale and mass duplicating retrievals
between multiple peers.
* eth/downloader: fix state request leak
This commit fixes the hang seen sometimes while doing the state
sync. The cause of the hang was a rare combination of events:
request state data from peer, peer drops and reconnects almost
immediately. This caused a new download task to be assigned to
the peer, overwriting the old one still waiting for a timeout,
which in turned leaked the requests out, never to be retried.
The fix is to ensure that a task assignment moves any pending
one back into the retry queue.
The commit also fixes a regression with peer dropping due to
stalls. The current code considered a peer stalling if they
timed out delivering 1 item. However, the downloader never
requests only one, the minimum is 2 (attempt to fine tune
estimated latency/bandwidth). The fix is simply to drop if
a timeout is detected at 2 items.
Apart from the above bugfixes, the commit contains some code
polishes I made while debugging the hang.
* core, eth, trie: support batched trie sync db writes
* trie: rename SyncMemCache to syncMemBatch
2017-06-22 15:26:03 +03:00
|
|
|
if _, index, err := sched.Process(results); err != nil {
|
2015-10-07 12:14:30 +03:00
|
|
|
t.Fatalf("failed to process result #%d: %v", index, err)
|
2015-10-05 19:37:56 +03:00
|
|
|
}
|
eth/downloader: separate state sync from queue (#14460)
* eth/downloader: separate state sync from queue
Scheduling of state node downloads hogged the downloader queue lock when
new requests were scheduled. This caused timeouts for other requests.
With this change, state sync is fully independent of all other downloads
and doesn't involve the queue at all.
State sync is started and checked on in processContent. This is slightly
awkward because processContent doesn't have a select loop. Instead, the
queue is closed by an auxiliary goroutine when state sync fails. We
tried several alternatives to this but settled on the current approach
because it's the least amount of change overall.
Handling of the pivot block has changed slightly: the queue previously
prevented import of pivot block receipts before the state of the pivot
block was available. In this commit, the receipt will be imported before
the state. This causes an annoyance where the pivot block is committed
as fast block head even when state downloads fail. Stay tuned for more
updates in this area ;)
* eth/downloader: remove cancelTimeout channel
* eth/downloader: retry state requests on timeout
* eth/downloader: improve comment
* eth/downloader: mark peers idle when state sync is done
* eth/downloader: move pivot block splitting to processContent
This change also ensures that pivot block receipts aren't imported
before the pivot block itself.
* eth/downloader: limit state node retries
* eth/downloader: improve state node error handling and retry check
* eth/downloader: remove maxStateNodeRetries
It fails the sync too much.
* eth/downloader: remove last use of cancelCh in statesync.go
Fixes TestDeliverHeadersHang*Fast and (hopefully)
the weird cancellation behaviour at the end of fast sync.
* eth/downloader: fix leak in runStateSync
* eth/downloader: don't run processFullSyncContent in LightSync mode
* eth/downloader: improve comments
* eth/downloader: fix vet, megacheck
* eth/downloader: remove unrequested tasks anyway
* eth/downloader, trie: various polishes around duplicate items
This commit explicitly tracks duplicate and unexpected state
delieveries done against a trie Sync structure, also adding
there to import info logs.
The commit moves the db batch used to commit trie changes one
level deeper so its flushed after every node insertion. This
is needed to avoid a lot of duplicate retrievals caused by
inconsistencies between Sync internals and database. A better
approach is to track not-yet-written states in trie.Sync and
flush on commit, but I'm focuing on correctness first now.
The commit fixes a regression around pivot block fail count.
The counter previously was reset to 1 if and only if a sync
cycle progressed (inserted at least 1 entry to the database).
The current code reset it already if a node was delivered,
which is not stong enough, because unless it ends up written
to disk, an attacker can just loop and attack ad infinitum.
The commit also fixes a regression around state deliveries
and timeouts. The old downloader tracked if a delivery is
stale (none of the deliveries were requestedt), in which
case it didn't mark the node idle and did not send further
requests, since it signals a past timeout. The current code
did mark it idle even on stale deliveries, which eventually
caused two requests to be in flight at the same time, making
the deliveries always stale and mass duplicating retrievals
between multiple peers.
* eth/downloader: fix state request leak
This commit fixes the hang seen sometimes while doing the state
sync. The cause of the hang was a rare combination of events:
request state data from peer, peer drops and reconnects almost
immediately. This caused a new download task to be assigned to
the peer, overwriting the old one still waiting for a timeout,
which in turned leaked the requests out, never to be retried.
The fix is to ensure that a task assignment moves any pending
one back into the retry queue.
The commit also fixes a regression with peer dropping due to
stalls. The current code considered a peer stalling if they
timed out delivering 1 item. However, the downloader never
requests only one, the minimum is 2 (attempt to fine tune
estimated latency/bandwidth). The fix is simply to drop if
a timeout is detected at 2 items.
Apart from the above bugfixes, the commit contains some code
polishes I made while debugging the hang.
* core, eth, trie: support batched trie sync db writes
* trie: rename SyncMemCache to syncMemBatch
2017-06-22 15:26:03 +03:00
|
|
|
if index, err := sched.Commit(dstDb); err != nil {
|
|
|
|
t.Fatalf("failed to commit data #%d: %v", index, err)
|
|
|
|
}
|
2015-10-05 19:37:56 +03:00
|
|
|
queue = append(queue[:0], sched.Missing(batch)...)
|
|
|
|
}
|
|
|
|
// Cross check that the two states are in sync
|
|
|
|
checkStateAccounts(t, dstDb, srcRoot, srcAccounts)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Tests that the trie scheduler can correctly reconstruct the state even if only
|
|
|
|
// partial results are returned, and the others sent only later.
|
|
|
|
func TestIterativeDelayedStateSync(t *testing.T) {
|
|
|
|
// Create a random state to copy
|
2018-02-05 19:40:32 +03:00
|
|
|
srcDb, srcRoot, srcAccounts := makeTestState()
|
2015-10-05 19:37:56 +03:00
|
|
|
|
|
|
|
// Create a destination state and sync with the scheduler
|
2018-09-24 15:57:49 +03:00
|
|
|
dstDb := rawdb.NewMemoryDatabase()
|
2019-05-13 15:28:01 +03:00
|
|
|
sched := NewStateSync(srcRoot, dstDb, trie.NewSyncBloom(1, dstDb))
|
2015-10-05 19:37:56 +03:00
|
|
|
|
|
|
|
queue := append([]common.Hash{}, sched.Missing(0)...)
|
|
|
|
for len(queue) > 0 {
|
|
|
|
// Sync only half of the scheduled nodes
|
|
|
|
results := make([]trie.SyncResult, len(queue)/2+1)
|
|
|
|
for i, hash := range queue[:len(results)] {
|
2018-02-05 19:40:32 +03:00
|
|
|
data, err := srcDb.TrieDB().Node(hash)
|
2015-10-05 19:37:56 +03:00
|
|
|
if err != nil {
|
2018-02-05 19:40:32 +03:00
|
|
|
t.Fatalf("failed to retrieve node data for %x", hash)
|
2015-10-05 19:37:56 +03:00
|
|
|
}
|
2016-04-15 12:06:57 +03:00
|
|
|
results[i] = trie.SyncResult{Hash: hash, Data: data}
|
2015-10-05 19:37:56 +03:00
|
|
|
}
|
eth/downloader: separate state sync from queue (#14460)
* eth/downloader: separate state sync from queue
Scheduling of state node downloads hogged the downloader queue lock when
new requests were scheduled. This caused timeouts for other requests.
With this change, state sync is fully independent of all other downloads
and doesn't involve the queue at all.
State sync is started and checked on in processContent. This is slightly
awkward because processContent doesn't have a select loop. Instead, the
queue is closed by an auxiliary goroutine when state sync fails. We
tried several alternatives to this but settled on the current approach
because it's the least amount of change overall.
Handling of the pivot block has changed slightly: the queue previously
prevented import of pivot block receipts before the state of the pivot
block was available. In this commit, the receipt will be imported before
the state. This causes an annoyance where the pivot block is committed
as fast block head even when state downloads fail. Stay tuned for more
updates in this area ;)
* eth/downloader: remove cancelTimeout channel
* eth/downloader: retry state requests on timeout
* eth/downloader: improve comment
* eth/downloader: mark peers idle when state sync is done
* eth/downloader: move pivot block splitting to processContent
This change also ensures that pivot block receipts aren't imported
before the pivot block itself.
* eth/downloader: limit state node retries
* eth/downloader: improve state node error handling and retry check
* eth/downloader: remove maxStateNodeRetries
It fails the sync too much.
* eth/downloader: remove last use of cancelCh in statesync.go
Fixes TestDeliverHeadersHang*Fast and (hopefully)
the weird cancellation behaviour at the end of fast sync.
* eth/downloader: fix leak in runStateSync
* eth/downloader: don't run processFullSyncContent in LightSync mode
* eth/downloader: improve comments
* eth/downloader: fix vet, megacheck
* eth/downloader: remove unrequested tasks anyway
* eth/downloader, trie: various polishes around duplicate items
This commit explicitly tracks duplicate and unexpected state
delieveries done against a trie Sync structure, also adding
there to import info logs.
The commit moves the db batch used to commit trie changes one
level deeper so its flushed after every node insertion. This
is needed to avoid a lot of duplicate retrievals caused by
inconsistencies between Sync internals and database. A better
approach is to track not-yet-written states in trie.Sync and
flush on commit, but I'm focuing on correctness first now.
The commit fixes a regression around pivot block fail count.
The counter previously was reset to 1 if and only if a sync
cycle progressed (inserted at least 1 entry to the database).
The current code reset it already if a node was delivered,
which is not stong enough, because unless it ends up written
to disk, an attacker can just loop and attack ad infinitum.
The commit also fixes a regression around state deliveries
and timeouts. The old downloader tracked if a delivery is
stale (none of the deliveries were requestedt), in which
case it didn't mark the node idle and did not send further
requests, since it signals a past timeout. The current code
did mark it idle even on stale deliveries, which eventually
caused two requests to be in flight at the same time, making
the deliveries always stale and mass duplicating retrievals
between multiple peers.
* eth/downloader: fix state request leak
This commit fixes the hang seen sometimes while doing the state
sync. The cause of the hang was a rare combination of events:
request state data from peer, peer drops and reconnects almost
immediately. This caused a new download task to be assigned to
the peer, overwriting the old one still waiting for a timeout,
which in turned leaked the requests out, never to be retried.
The fix is to ensure that a task assignment moves any pending
one back into the retry queue.
The commit also fixes a regression with peer dropping due to
stalls. The current code considered a peer stalling if they
timed out delivering 1 item. However, the downloader never
requests only one, the minimum is 2 (attempt to fine tune
estimated latency/bandwidth). The fix is simply to drop if
a timeout is detected at 2 items.
Apart from the above bugfixes, the commit contains some code
polishes I made while debugging the hang.
* core, eth, trie: support batched trie sync db writes
* trie: rename SyncMemCache to syncMemBatch
2017-06-22 15:26:03 +03:00
|
|
|
if _, index, err := sched.Process(results); err != nil {
|
2015-10-07 12:14:30 +03:00
|
|
|
t.Fatalf("failed to process result #%d: %v", index, err)
|
2015-10-05 19:37:56 +03:00
|
|
|
}
|
eth/downloader: separate state sync from queue (#14460)
* eth/downloader: separate state sync from queue
Scheduling of state node downloads hogged the downloader queue lock when
new requests were scheduled. This caused timeouts for other requests.
With this change, state sync is fully independent of all other downloads
and doesn't involve the queue at all.
State sync is started and checked on in processContent. This is slightly
awkward because processContent doesn't have a select loop. Instead, the
queue is closed by an auxiliary goroutine when state sync fails. We
tried several alternatives to this but settled on the current approach
because it's the least amount of change overall.
Handling of the pivot block has changed slightly: the queue previously
prevented import of pivot block receipts before the state of the pivot
block was available. In this commit, the receipt will be imported before
the state. This causes an annoyance where the pivot block is committed
as fast block head even when state downloads fail. Stay tuned for more
updates in this area ;)
* eth/downloader: remove cancelTimeout channel
* eth/downloader: retry state requests on timeout
* eth/downloader: improve comment
* eth/downloader: mark peers idle when state sync is done
* eth/downloader: move pivot block splitting to processContent
This change also ensures that pivot block receipts aren't imported
before the pivot block itself.
* eth/downloader: limit state node retries
* eth/downloader: improve state node error handling and retry check
* eth/downloader: remove maxStateNodeRetries
It fails the sync too much.
* eth/downloader: remove last use of cancelCh in statesync.go
Fixes TestDeliverHeadersHang*Fast and (hopefully)
the weird cancellation behaviour at the end of fast sync.
* eth/downloader: fix leak in runStateSync
* eth/downloader: don't run processFullSyncContent in LightSync mode
* eth/downloader: improve comments
* eth/downloader: fix vet, megacheck
* eth/downloader: remove unrequested tasks anyway
* eth/downloader, trie: various polishes around duplicate items
This commit explicitly tracks duplicate and unexpected state
delieveries done against a trie Sync structure, also adding
there to import info logs.
The commit moves the db batch used to commit trie changes one
level deeper so its flushed after every node insertion. This
is needed to avoid a lot of duplicate retrievals caused by
inconsistencies between Sync internals and database. A better
approach is to track not-yet-written states in trie.Sync and
flush on commit, but I'm focuing on correctness first now.
The commit fixes a regression around pivot block fail count.
The counter previously was reset to 1 if and only if a sync
cycle progressed (inserted at least 1 entry to the database).
The current code reset it already if a node was delivered,
which is not stong enough, because unless it ends up written
to disk, an attacker can just loop and attack ad infinitum.
The commit also fixes a regression around state deliveries
and timeouts. The old downloader tracked if a delivery is
stale (none of the deliveries were requestedt), in which
case it didn't mark the node idle and did not send further
requests, since it signals a past timeout. The current code
did mark it idle even on stale deliveries, which eventually
caused two requests to be in flight at the same time, making
the deliveries always stale and mass duplicating retrievals
between multiple peers.
* eth/downloader: fix state request leak
This commit fixes the hang seen sometimes while doing the state
sync. The cause of the hang was a rare combination of events:
request state data from peer, peer drops and reconnects almost
immediately. This caused a new download task to be assigned to
the peer, overwriting the old one still waiting for a timeout,
which in turned leaked the requests out, never to be retried.
The fix is to ensure that a task assignment moves any pending
one back into the retry queue.
The commit also fixes a regression with peer dropping due to
stalls. The current code considered a peer stalling if they
timed out delivering 1 item. However, the downloader never
requests only one, the minimum is 2 (attempt to fine tune
estimated latency/bandwidth). The fix is simply to drop if
a timeout is detected at 2 items.
Apart from the above bugfixes, the commit contains some code
polishes I made while debugging the hang.
* core, eth, trie: support batched trie sync db writes
* trie: rename SyncMemCache to syncMemBatch
2017-06-22 15:26:03 +03:00
|
|
|
if index, err := sched.Commit(dstDb); err != nil {
|
|
|
|
t.Fatalf("failed to commit data #%d: %v", index, err)
|
|
|
|
}
|
2015-10-05 19:37:56 +03:00
|
|
|
queue = append(queue[len(results):], sched.Missing(0)...)
|
|
|
|
}
|
|
|
|
// Cross check that the two states are in sync
|
|
|
|
checkStateAccounts(t, dstDb, srcRoot, srcAccounts)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Tests that given a root hash, a trie can sync iteratively on a single thread,
|
|
|
|
// requesting retrieval tasks and returning all of them in one go, however in a
|
|
|
|
// random order.
|
|
|
|
func TestIterativeRandomStateSyncIndividual(t *testing.T) { testIterativeRandomStateSync(t, 1) }
|
|
|
|
func TestIterativeRandomStateSyncBatched(t *testing.T) { testIterativeRandomStateSync(t, 100) }
|
|
|
|
|
|
|
|
func testIterativeRandomStateSync(t *testing.T, batch int) {
|
|
|
|
// Create a random state to copy
|
2018-02-05 19:40:32 +03:00
|
|
|
srcDb, srcRoot, srcAccounts := makeTestState()
|
2015-10-05 19:37:56 +03:00
|
|
|
|
|
|
|
// Create a destination state and sync with the scheduler
|
2018-09-24 15:57:49 +03:00
|
|
|
dstDb := rawdb.NewMemoryDatabase()
|
2019-05-13 15:28:01 +03:00
|
|
|
sched := NewStateSync(srcRoot, dstDb, trie.NewSyncBloom(1, dstDb))
|
2015-10-05 19:37:56 +03:00
|
|
|
|
|
|
|
queue := make(map[common.Hash]struct{})
|
|
|
|
for _, hash := range sched.Missing(batch) {
|
|
|
|
queue[hash] = struct{}{}
|
|
|
|
}
|
|
|
|
for len(queue) > 0 {
|
|
|
|
// Fetch all the queued nodes in a random order
|
|
|
|
results := make([]trie.SyncResult, 0, len(queue))
|
2017-01-06 17:52:03 +03:00
|
|
|
for hash := range queue {
|
2018-02-05 19:40:32 +03:00
|
|
|
data, err := srcDb.TrieDB().Node(hash)
|
2015-10-05 19:37:56 +03:00
|
|
|
if err != nil {
|
2018-02-05 19:40:32 +03:00
|
|
|
t.Fatalf("failed to retrieve node data for %x", hash)
|
2015-10-05 19:37:56 +03:00
|
|
|
}
|
2016-04-15 12:06:57 +03:00
|
|
|
results = append(results, trie.SyncResult{Hash: hash, Data: data})
|
2015-10-05 19:37:56 +03:00
|
|
|
}
|
|
|
|
// Feed the retrieved results back and queue new tasks
|
eth/downloader: separate state sync from queue (#14460)
* eth/downloader: separate state sync from queue
Scheduling of state node downloads hogged the downloader queue lock when
new requests were scheduled. This caused timeouts for other requests.
With this change, state sync is fully independent of all other downloads
and doesn't involve the queue at all.
State sync is started and checked on in processContent. This is slightly
awkward because processContent doesn't have a select loop. Instead, the
queue is closed by an auxiliary goroutine when state sync fails. We
tried several alternatives to this but settled on the current approach
because it's the least amount of change overall.
Handling of the pivot block has changed slightly: the queue previously
prevented import of pivot block receipts before the state of the pivot
block was available. In this commit, the receipt will be imported before
the state. This causes an annoyance where the pivot block is committed
as fast block head even when state downloads fail. Stay tuned for more
updates in this area ;)
* eth/downloader: remove cancelTimeout channel
* eth/downloader: retry state requests on timeout
* eth/downloader: improve comment
* eth/downloader: mark peers idle when state sync is done
* eth/downloader: move pivot block splitting to processContent
This change also ensures that pivot block receipts aren't imported
before the pivot block itself.
* eth/downloader: limit state node retries
* eth/downloader: improve state node error handling and retry check
* eth/downloader: remove maxStateNodeRetries
It fails the sync too much.
* eth/downloader: remove last use of cancelCh in statesync.go
Fixes TestDeliverHeadersHang*Fast and (hopefully)
the weird cancellation behaviour at the end of fast sync.
* eth/downloader: fix leak in runStateSync
* eth/downloader: don't run processFullSyncContent in LightSync mode
* eth/downloader: improve comments
* eth/downloader: fix vet, megacheck
* eth/downloader: remove unrequested tasks anyway
* eth/downloader, trie: various polishes around duplicate items
This commit explicitly tracks duplicate and unexpected state
delieveries done against a trie Sync structure, also adding
there to import info logs.
The commit moves the db batch used to commit trie changes one
level deeper so its flushed after every node insertion. This
is needed to avoid a lot of duplicate retrievals caused by
inconsistencies between Sync internals and database. A better
approach is to track not-yet-written states in trie.Sync and
flush on commit, but I'm focuing on correctness first now.
The commit fixes a regression around pivot block fail count.
The counter previously was reset to 1 if and only if a sync
cycle progressed (inserted at least 1 entry to the database).
The current code reset it already if a node was delivered,
which is not stong enough, because unless it ends up written
to disk, an attacker can just loop and attack ad infinitum.
The commit also fixes a regression around state deliveries
and timeouts. The old downloader tracked if a delivery is
stale (none of the deliveries were requestedt), in which
case it didn't mark the node idle and did not send further
requests, since it signals a past timeout. The current code
did mark it idle even on stale deliveries, which eventually
caused two requests to be in flight at the same time, making
the deliveries always stale and mass duplicating retrievals
between multiple peers.
* eth/downloader: fix state request leak
This commit fixes the hang seen sometimes while doing the state
sync. The cause of the hang was a rare combination of events:
request state data from peer, peer drops and reconnects almost
immediately. This caused a new download task to be assigned to
the peer, overwriting the old one still waiting for a timeout,
which in turned leaked the requests out, never to be retried.
The fix is to ensure that a task assignment moves any pending
one back into the retry queue.
The commit also fixes a regression with peer dropping due to
stalls. The current code considered a peer stalling if they
timed out delivering 1 item. However, the downloader never
requests only one, the minimum is 2 (attempt to fine tune
estimated latency/bandwidth). The fix is simply to drop if
a timeout is detected at 2 items.
Apart from the above bugfixes, the commit contains some code
polishes I made while debugging the hang.
* core, eth, trie: support batched trie sync db writes
* trie: rename SyncMemCache to syncMemBatch
2017-06-22 15:26:03 +03:00
|
|
|
if _, index, err := sched.Process(results); err != nil {
|
2015-10-07 12:14:30 +03:00
|
|
|
t.Fatalf("failed to process result #%d: %v", index, err)
|
2015-10-05 19:37:56 +03:00
|
|
|
}
|
eth/downloader: separate state sync from queue (#14460)
* eth/downloader: separate state sync from queue
Scheduling of state node downloads hogged the downloader queue lock when
new requests were scheduled. This caused timeouts for other requests.
With this change, state sync is fully independent of all other downloads
and doesn't involve the queue at all.
State sync is started and checked on in processContent. This is slightly
awkward because processContent doesn't have a select loop. Instead, the
queue is closed by an auxiliary goroutine when state sync fails. We
tried several alternatives to this but settled on the current approach
because it's the least amount of change overall.
Handling of the pivot block has changed slightly: the queue previously
prevented import of pivot block receipts before the state of the pivot
block was available. In this commit, the receipt will be imported before
the state. This causes an annoyance where the pivot block is committed
as fast block head even when state downloads fail. Stay tuned for more
updates in this area ;)
* eth/downloader: remove cancelTimeout channel
* eth/downloader: retry state requests on timeout
* eth/downloader: improve comment
* eth/downloader: mark peers idle when state sync is done
* eth/downloader: move pivot block splitting to processContent
This change also ensures that pivot block receipts aren't imported
before the pivot block itself.
* eth/downloader: limit state node retries
* eth/downloader: improve state node error handling and retry check
* eth/downloader: remove maxStateNodeRetries
It fails the sync too much.
* eth/downloader: remove last use of cancelCh in statesync.go
Fixes TestDeliverHeadersHang*Fast and (hopefully)
the weird cancellation behaviour at the end of fast sync.
* eth/downloader: fix leak in runStateSync
* eth/downloader: don't run processFullSyncContent in LightSync mode
* eth/downloader: improve comments
* eth/downloader: fix vet, megacheck
* eth/downloader: remove unrequested tasks anyway
* eth/downloader, trie: various polishes around duplicate items
This commit explicitly tracks duplicate and unexpected state
delieveries done against a trie Sync structure, also adding
there to import info logs.
The commit moves the db batch used to commit trie changes one
level deeper so its flushed after every node insertion. This
is needed to avoid a lot of duplicate retrievals caused by
inconsistencies between Sync internals and database. A better
approach is to track not-yet-written states in trie.Sync and
flush on commit, but I'm focuing on correctness first now.
The commit fixes a regression around pivot block fail count.
The counter previously was reset to 1 if and only if a sync
cycle progressed (inserted at least 1 entry to the database).
The current code reset it already if a node was delivered,
which is not stong enough, because unless it ends up written
to disk, an attacker can just loop and attack ad infinitum.
The commit also fixes a regression around state deliveries
and timeouts. The old downloader tracked if a delivery is
stale (none of the deliveries were requestedt), in which
case it didn't mark the node idle and did not send further
requests, since it signals a past timeout. The current code
did mark it idle even on stale deliveries, which eventually
caused two requests to be in flight at the same time, making
the deliveries always stale and mass duplicating retrievals
between multiple peers.
* eth/downloader: fix state request leak
This commit fixes the hang seen sometimes while doing the state
sync. The cause of the hang was a rare combination of events:
request state data from peer, peer drops and reconnects almost
immediately. This caused a new download task to be assigned to
the peer, overwriting the old one still waiting for a timeout,
which in turned leaked the requests out, never to be retried.
The fix is to ensure that a task assignment moves any pending
one back into the retry queue.
The commit also fixes a regression with peer dropping due to
stalls. The current code considered a peer stalling if they
timed out delivering 1 item. However, the downloader never
requests only one, the minimum is 2 (attempt to fine tune
estimated latency/bandwidth). The fix is simply to drop if
a timeout is detected at 2 items.
Apart from the above bugfixes, the commit contains some code
polishes I made while debugging the hang.
* core, eth, trie: support batched trie sync db writes
* trie: rename SyncMemCache to syncMemBatch
2017-06-22 15:26:03 +03:00
|
|
|
if index, err := sched.Commit(dstDb); err != nil {
|
|
|
|
t.Fatalf("failed to commit data #%d: %v", index, err)
|
|
|
|
}
|
2015-10-05 19:37:56 +03:00
|
|
|
queue = make(map[common.Hash]struct{})
|
|
|
|
for _, hash := range sched.Missing(batch) {
|
|
|
|
queue[hash] = struct{}{}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// Cross check that the two states are in sync
|
|
|
|
checkStateAccounts(t, dstDb, srcRoot, srcAccounts)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Tests that the trie scheduler can correctly reconstruct the state even if only
|
|
|
|
// partial results are returned (Even those randomly), others sent only later.
|
|
|
|
func TestIterativeRandomDelayedStateSync(t *testing.T) {
|
|
|
|
// Create a random state to copy
|
2018-02-05 19:40:32 +03:00
|
|
|
srcDb, srcRoot, srcAccounts := makeTestState()
|
2015-10-05 19:37:56 +03:00
|
|
|
|
|
|
|
// Create a destination state and sync with the scheduler
|
2018-09-24 15:57:49 +03:00
|
|
|
dstDb := rawdb.NewMemoryDatabase()
|
2019-05-13 15:28:01 +03:00
|
|
|
sched := NewStateSync(srcRoot, dstDb, trie.NewSyncBloom(1, dstDb))
|
2015-10-05 19:37:56 +03:00
|
|
|
|
|
|
|
queue := make(map[common.Hash]struct{})
|
|
|
|
for _, hash := range sched.Missing(0) {
|
|
|
|
queue[hash] = struct{}{}
|
|
|
|
}
|
|
|
|
for len(queue) > 0 {
|
|
|
|
// Sync only half of the scheduled nodes, even those in random order
|
|
|
|
results := make([]trie.SyncResult, 0, len(queue)/2+1)
|
2017-01-06 17:52:03 +03:00
|
|
|
for hash := range queue {
|
2015-10-05 19:37:56 +03:00
|
|
|
delete(queue, hash)
|
|
|
|
|
2018-02-05 19:40:32 +03:00
|
|
|
data, err := srcDb.TrieDB().Node(hash)
|
2015-10-05 19:37:56 +03:00
|
|
|
if err != nil {
|
2018-02-05 19:40:32 +03:00
|
|
|
t.Fatalf("failed to retrieve node data for %x", hash)
|
2015-10-05 19:37:56 +03:00
|
|
|
}
|
2016-04-15 12:06:57 +03:00
|
|
|
results = append(results, trie.SyncResult{Hash: hash, Data: data})
|
2015-10-05 19:37:56 +03:00
|
|
|
|
|
|
|
if len(results) >= cap(results) {
|
|
|
|
break
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// Feed the retrieved results back and queue new tasks
|
eth/downloader: separate state sync from queue (#14460)
* eth/downloader: separate state sync from queue
Scheduling of state node downloads hogged the downloader queue lock when
new requests were scheduled. This caused timeouts for other requests.
With this change, state sync is fully independent of all other downloads
and doesn't involve the queue at all.
State sync is started and checked on in processContent. This is slightly
awkward because processContent doesn't have a select loop. Instead, the
queue is closed by an auxiliary goroutine when state sync fails. We
tried several alternatives to this but settled on the current approach
because it's the least amount of change overall.
Handling of the pivot block has changed slightly: the queue previously
prevented import of pivot block receipts before the state of the pivot
block was available. In this commit, the receipt will be imported before
the state. This causes an annoyance where the pivot block is committed
as fast block head even when state downloads fail. Stay tuned for more
updates in this area ;)
* eth/downloader: remove cancelTimeout channel
* eth/downloader: retry state requests on timeout
* eth/downloader: improve comment
* eth/downloader: mark peers idle when state sync is done
* eth/downloader: move pivot block splitting to processContent
This change also ensures that pivot block receipts aren't imported
before the pivot block itself.
* eth/downloader: limit state node retries
* eth/downloader: improve state node error handling and retry check
* eth/downloader: remove maxStateNodeRetries
It fails the sync too much.
* eth/downloader: remove last use of cancelCh in statesync.go
Fixes TestDeliverHeadersHang*Fast and (hopefully)
the weird cancellation behaviour at the end of fast sync.
* eth/downloader: fix leak in runStateSync
* eth/downloader: don't run processFullSyncContent in LightSync mode
* eth/downloader: improve comments
* eth/downloader: fix vet, megacheck
* eth/downloader: remove unrequested tasks anyway
* eth/downloader, trie: various polishes around duplicate items
This commit explicitly tracks duplicate and unexpected state
delieveries done against a trie Sync structure, also adding
there to import info logs.
The commit moves the db batch used to commit trie changes one
level deeper so its flushed after every node insertion. This
is needed to avoid a lot of duplicate retrievals caused by
inconsistencies between Sync internals and database. A better
approach is to track not-yet-written states in trie.Sync and
flush on commit, but I'm focuing on correctness first now.
The commit fixes a regression around pivot block fail count.
The counter previously was reset to 1 if and only if a sync
cycle progressed (inserted at least 1 entry to the database).
The current code reset it already if a node was delivered,
which is not stong enough, because unless it ends up written
to disk, an attacker can just loop and attack ad infinitum.
The commit also fixes a regression around state deliveries
and timeouts. The old downloader tracked if a delivery is
stale (none of the deliveries were requestedt), in which
case it didn't mark the node idle and did not send further
requests, since it signals a past timeout. The current code
did mark it idle even on stale deliveries, which eventually
caused two requests to be in flight at the same time, making
the deliveries always stale and mass duplicating retrievals
between multiple peers.
* eth/downloader: fix state request leak
This commit fixes the hang seen sometimes while doing the state
sync. The cause of the hang was a rare combination of events:
request state data from peer, peer drops and reconnects almost
immediately. This caused a new download task to be assigned to
the peer, overwriting the old one still waiting for a timeout,
which in turned leaked the requests out, never to be retried.
The fix is to ensure that a task assignment moves any pending
one back into the retry queue.
The commit also fixes a regression with peer dropping due to
stalls. The current code considered a peer stalling if they
timed out delivering 1 item. However, the downloader never
requests only one, the minimum is 2 (attempt to fine tune
estimated latency/bandwidth). The fix is simply to drop if
a timeout is detected at 2 items.
Apart from the above bugfixes, the commit contains some code
polishes I made while debugging the hang.
* core, eth, trie: support batched trie sync db writes
* trie: rename SyncMemCache to syncMemBatch
2017-06-22 15:26:03 +03:00
|
|
|
if _, index, err := sched.Process(results); err != nil {
|
2015-10-07 12:14:30 +03:00
|
|
|
t.Fatalf("failed to process result #%d: %v", index, err)
|
2015-10-05 19:37:56 +03:00
|
|
|
}
|
eth/downloader: separate state sync from queue (#14460)
* eth/downloader: separate state sync from queue
Scheduling of state node downloads hogged the downloader queue lock when
new requests were scheduled. This caused timeouts for other requests.
With this change, state sync is fully independent of all other downloads
and doesn't involve the queue at all.
State sync is started and checked on in processContent. This is slightly
awkward because processContent doesn't have a select loop. Instead, the
queue is closed by an auxiliary goroutine when state sync fails. We
tried several alternatives to this but settled on the current approach
because it's the least amount of change overall.
Handling of the pivot block has changed slightly: the queue previously
prevented import of pivot block receipts before the state of the pivot
block was available. In this commit, the receipt will be imported before
the state. This causes an annoyance where the pivot block is committed
as fast block head even when state downloads fail. Stay tuned for more
updates in this area ;)
* eth/downloader: remove cancelTimeout channel
* eth/downloader: retry state requests on timeout
* eth/downloader: improve comment
* eth/downloader: mark peers idle when state sync is done
* eth/downloader: move pivot block splitting to processContent
This change also ensures that pivot block receipts aren't imported
before the pivot block itself.
* eth/downloader: limit state node retries
* eth/downloader: improve state node error handling and retry check
* eth/downloader: remove maxStateNodeRetries
It fails the sync too much.
* eth/downloader: remove last use of cancelCh in statesync.go
Fixes TestDeliverHeadersHang*Fast and (hopefully)
the weird cancellation behaviour at the end of fast sync.
* eth/downloader: fix leak in runStateSync
* eth/downloader: don't run processFullSyncContent in LightSync mode
* eth/downloader: improve comments
* eth/downloader: fix vet, megacheck
* eth/downloader: remove unrequested tasks anyway
* eth/downloader, trie: various polishes around duplicate items
This commit explicitly tracks duplicate and unexpected state
delieveries done against a trie Sync structure, also adding
there to import info logs.
The commit moves the db batch used to commit trie changes one
level deeper so its flushed after every node insertion. This
is needed to avoid a lot of duplicate retrievals caused by
inconsistencies between Sync internals and database. A better
approach is to track not-yet-written states in trie.Sync and
flush on commit, but I'm focuing on correctness first now.
The commit fixes a regression around pivot block fail count.
The counter previously was reset to 1 if and only if a sync
cycle progressed (inserted at least 1 entry to the database).
The current code reset it already if a node was delivered,
which is not stong enough, because unless it ends up written
to disk, an attacker can just loop and attack ad infinitum.
The commit also fixes a regression around state deliveries
and timeouts. The old downloader tracked if a delivery is
stale (none of the deliveries were requestedt), in which
case it didn't mark the node idle and did not send further
requests, since it signals a past timeout. The current code
did mark it idle even on stale deliveries, which eventually
caused two requests to be in flight at the same time, making
the deliveries always stale and mass duplicating retrievals
between multiple peers.
* eth/downloader: fix state request leak
This commit fixes the hang seen sometimes while doing the state
sync. The cause of the hang was a rare combination of events:
request state data from peer, peer drops and reconnects almost
immediately. This caused a new download task to be assigned to
the peer, overwriting the old one still waiting for a timeout,
which in turned leaked the requests out, never to be retried.
The fix is to ensure that a task assignment moves any pending
one back into the retry queue.
The commit also fixes a regression with peer dropping due to
stalls. The current code considered a peer stalling if they
timed out delivering 1 item. However, the downloader never
requests only one, the minimum is 2 (attempt to fine tune
estimated latency/bandwidth). The fix is simply to drop if
a timeout is detected at 2 items.
Apart from the above bugfixes, the commit contains some code
polishes I made while debugging the hang.
* core, eth, trie: support batched trie sync db writes
* trie: rename SyncMemCache to syncMemBatch
2017-06-22 15:26:03 +03:00
|
|
|
if index, err := sched.Commit(dstDb); err != nil {
|
|
|
|
t.Fatalf("failed to commit data #%d: %v", index, err)
|
|
|
|
}
|
2015-10-05 19:37:56 +03:00
|
|
|
for _, hash := range sched.Missing(0) {
|
|
|
|
queue[hash] = struct{}{}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// Cross check that the two states are in sync
|
|
|
|
checkStateAccounts(t, dstDb, srcRoot, srcAccounts)
|
|
|
|
}
|
2015-12-28 15:20:37 +02:00
|
|
|
|
|
|
|
// Tests that at any point in time during a sync, only complete sub-tries are in
|
|
|
|
// the database.
|
|
|
|
func TestIncompleteStateSync(t *testing.T) {
|
|
|
|
// Create a random state to copy
|
2018-02-05 19:40:32 +03:00
|
|
|
srcDb, srcRoot, srcAccounts := makeTestState()
|
2017-06-27 16:57:06 +03:00
|
|
|
|
2018-02-05 19:40:32 +03:00
|
|
|
checkTrieConsistency(srcDb.TrieDB().DiskDB().(ethdb.Database), srcRoot)
|
2015-12-28 15:20:37 +02:00
|
|
|
|
|
|
|
// Create a destination state and sync with the scheduler
|
2018-09-24 15:57:49 +03:00
|
|
|
dstDb := rawdb.NewMemoryDatabase()
|
2019-05-13 15:28:01 +03:00
|
|
|
sched := NewStateSync(srcRoot, dstDb, trie.NewSyncBloom(1, dstDb))
|
2015-12-28 15:20:37 +02:00
|
|
|
|
|
|
|
added := []common.Hash{}
|
|
|
|
queue := append([]common.Hash{}, sched.Missing(1)...)
|
|
|
|
for len(queue) > 0 {
|
|
|
|
// Fetch a batch of state nodes
|
|
|
|
results := make([]trie.SyncResult, len(queue))
|
|
|
|
for i, hash := range queue {
|
2018-02-05 19:40:32 +03:00
|
|
|
data, err := srcDb.TrieDB().Node(hash)
|
2015-12-28 15:20:37 +02:00
|
|
|
if err != nil {
|
2018-02-05 19:40:32 +03:00
|
|
|
t.Fatalf("failed to retrieve node data for %x", hash)
|
2015-12-28 15:20:37 +02:00
|
|
|
}
|
2016-04-15 12:06:57 +03:00
|
|
|
results[i] = trie.SyncResult{Hash: hash, Data: data}
|
2015-12-28 15:20:37 +02:00
|
|
|
}
|
|
|
|
// Process each of the state nodes
|
eth/downloader: separate state sync from queue (#14460)
* eth/downloader: separate state sync from queue
Scheduling of state node downloads hogged the downloader queue lock when
new requests were scheduled. This caused timeouts for other requests.
With this change, state sync is fully independent of all other downloads
and doesn't involve the queue at all.
State sync is started and checked on in processContent. This is slightly
awkward because processContent doesn't have a select loop. Instead, the
queue is closed by an auxiliary goroutine when state sync fails. We
tried several alternatives to this but settled on the current approach
because it's the least amount of change overall.
Handling of the pivot block has changed slightly: the queue previously
prevented import of pivot block receipts before the state of the pivot
block was available. In this commit, the receipt will be imported before
the state. This causes an annoyance where the pivot block is committed
as fast block head even when state downloads fail. Stay tuned for more
updates in this area ;)
* eth/downloader: remove cancelTimeout channel
* eth/downloader: retry state requests on timeout
* eth/downloader: improve comment
* eth/downloader: mark peers idle when state sync is done
* eth/downloader: move pivot block splitting to processContent
This change also ensures that pivot block receipts aren't imported
before the pivot block itself.
* eth/downloader: limit state node retries
* eth/downloader: improve state node error handling and retry check
* eth/downloader: remove maxStateNodeRetries
It fails the sync too much.
* eth/downloader: remove last use of cancelCh in statesync.go
Fixes TestDeliverHeadersHang*Fast and (hopefully)
the weird cancellation behaviour at the end of fast sync.
* eth/downloader: fix leak in runStateSync
* eth/downloader: don't run processFullSyncContent in LightSync mode
* eth/downloader: improve comments
* eth/downloader: fix vet, megacheck
* eth/downloader: remove unrequested tasks anyway
* eth/downloader, trie: various polishes around duplicate items
This commit explicitly tracks duplicate and unexpected state
delieveries done against a trie Sync structure, also adding
there to import info logs.
The commit moves the db batch used to commit trie changes one
level deeper so its flushed after every node insertion. This
is needed to avoid a lot of duplicate retrievals caused by
inconsistencies between Sync internals and database. A better
approach is to track not-yet-written states in trie.Sync and
flush on commit, but I'm focuing on correctness first now.
The commit fixes a regression around pivot block fail count.
The counter previously was reset to 1 if and only if a sync
cycle progressed (inserted at least 1 entry to the database).
The current code reset it already if a node was delivered,
which is not stong enough, because unless it ends up written
to disk, an attacker can just loop and attack ad infinitum.
The commit also fixes a regression around state deliveries
and timeouts. The old downloader tracked if a delivery is
stale (none of the deliveries were requestedt), in which
case it didn't mark the node idle and did not send further
requests, since it signals a past timeout. The current code
did mark it idle even on stale deliveries, which eventually
caused two requests to be in flight at the same time, making
the deliveries always stale and mass duplicating retrievals
between multiple peers.
* eth/downloader: fix state request leak
This commit fixes the hang seen sometimes while doing the state
sync. The cause of the hang was a rare combination of events:
request state data from peer, peer drops and reconnects almost
immediately. This caused a new download task to be assigned to
the peer, overwriting the old one still waiting for a timeout,
which in turned leaked the requests out, never to be retried.
The fix is to ensure that a task assignment moves any pending
one back into the retry queue.
The commit also fixes a regression with peer dropping due to
stalls. The current code considered a peer stalling if they
timed out delivering 1 item. However, the downloader never
requests only one, the minimum is 2 (attempt to fine tune
estimated latency/bandwidth). The fix is simply to drop if
a timeout is detected at 2 items.
Apart from the above bugfixes, the commit contains some code
polishes I made while debugging the hang.
* core, eth, trie: support batched trie sync db writes
* trie: rename SyncMemCache to syncMemBatch
2017-06-22 15:26:03 +03:00
|
|
|
if _, index, err := sched.Process(results); err != nil {
|
2015-12-28 15:20:37 +02:00
|
|
|
t.Fatalf("failed to process result #%d: %v", index, err)
|
|
|
|
}
|
eth/downloader: separate state sync from queue (#14460)
* eth/downloader: separate state sync from queue
Scheduling of state node downloads hogged the downloader queue lock when
new requests were scheduled. This caused timeouts for other requests.
With this change, state sync is fully independent of all other downloads
and doesn't involve the queue at all.
State sync is started and checked on in processContent. This is slightly
awkward because processContent doesn't have a select loop. Instead, the
queue is closed by an auxiliary goroutine when state sync fails. We
tried several alternatives to this but settled on the current approach
because it's the least amount of change overall.
Handling of the pivot block has changed slightly: the queue previously
prevented import of pivot block receipts before the state of the pivot
block was available. In this commit, the receipt will be imported before
the state. This causes an annoyance where the pivot block is committed
as fast block head even when state downloads fail. Stay tuned for more
updates in this area ;)
* eth/downloader: remove cancelTimeout channel
* eth/downloader: retry state requests on timeout
* eth/downloader: improve comment
* eth/downloader: mark peers idle when state sync is done
* eth/downloader: move pivot block splitting to processContent
This change also ensures that pivot block receipts aren't imported
before the pivot block itself.
* eth/downloader: limit state node retries
* eth/downloader: improve state node error handling and retry check
* eth/downloader: remove maxStateNodeRetries
It fails the sync too much.
* eth/downloader: remove last use of cancelCh in statesync.go
Fixes TestDeliverHeadersHang*Fast and (hopefully)
the weird cancellation behaviour at the end of fast sync.
* eth/downloader: fix leak in runStateSync
* eth/downloader: don't run processFullSyncContent in LightSync mode
* eth/downloader: improve comments
* eth/downloader: fix vet, megacheck
* eth/downloader: remove unrequested tasks anyway
* eth/downloader, trie: various polishes around duplicate items
This commit explicitly tracks duplicate and unexpected state
delieveries done against a trie Sync structure, also adding
there to import info logs.
The commit moves the db batch used to commit trie changes one
level deeper so its flushed after every node insertion. This
is needed to avoid a lot of duplicate retrievals caused by
inconsistencies between Sync internals and database. A better
approach is to track not-yet-written states in trie.Sync and
flush on commit, but I'm focuing on correctness first now.
The commit fixes a regression around pivot block fail count.
The counter previously was reset to 1 if and only if a sync
cycle progressed (inserted at least 1 entry to the database).
The current code reset it already if a node was delivered,
which is not stong enough, because unless it ends up written
to disk, an attacker can just loop and attack ad infinitum.
The commit also fixes a regression around state deliveries
and timeouts. The old downloader tracked if a delivery is
stale (none of the deliveries were requestedt), in which
case it didn't mark the node idle and did not send further
requests, since it signals a past timeout. The current code
did mark it idle even on stale deliveries, which eventually
caused two requests to be in flight at the same time, making
the deliveries always stale and mass duplicating retrievals
between multiple peers.
* eth/downloader: fix state request leak
This commit fixes the hang seen sometimes while doing the state
sync. The cause of the hang was a rare combination of events:
request state data from peer, peer drops and reconnects almost
immediately. This caused a new download task to be assigned to
the peer, overwriting the old one still waiting for a timeout,
which in turned leaked the requests out, never to be retried.
The fix is to ensure that a task assignment moves any pending
one back into the retry queue.
The commit also fixes a regression with peer dropping due to
stalls. The current code considered a peer stalling if they
timed out delivering 1 item. However, the downloader never
requests only one, the minimum is 2 (attempt to fine tune
estimated latency/bandwidth). The fix is simply to drop if
a timeout is detected at 2 items.
Apart from the above bugfixes, the commit contains some code
polishes I made while debugging the hang.
* core, eth, trie: support batched trie sync db writes
* trie: rename SyncMemCache to syncMemBatch
2017-06-22 15:26:03 +03:00
|
|
|
if index, err := sched.Commit(dstDb); err != nil {
|
|
|
|
t.Fatalf("failed to commit data #%d: %v", index, err)
|
|
|
|
}
|
2015-12-28 15:20:37 +02:00
|
|
|
for _, result := range results {
|
|
|
|
added = append(added, result.Hash)
|
|
|
|
}
|
2017-06-27 16:57:06 +03:00
|
|
|
// Check that all known sub-tries added so far are complete or missing entirely.
|
|
|
|
checkSubtries:
|
|
|
|
for _, hash := range added {
|
2015-12-28 15:20:37 +02:00
|
|
|
for _, acc := range srcAccounts {
|
2017-06-27 16:57:06 +03:00
|
|
|
if hash == crypto.Keccak256Hash(acc.code) {
|
|
|
|
continue checkSubtries // skip trie check of code nodes.
|
2015-12-28 15:20:37 +02:00
|
|
|
}
|
|
|
|
}
|
2017-06-27 16:57:06 +03:00
|
|
|
// Can't use checkStateConsistency here because subtrie keys may have odd
|
|
|
|
// length and crash in LeafKey.
|
|
|
|
if err := checkTrieConsistency(dstDb, hash); err != nil {
|
|
|
|
t.Fatalf("state inconsistent: %v", err)
|
2015-12-28 15:20:37 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
// Fetch the next batch to retrieve
|
|
|
|
queue = append(queue[:0], sched.Missing(1)...)
|
|
|
|
}
|
|
|
|
// Sanity check that removing any node from the database is detected
|
|
|
|
for _, node := range added[1:] {
|
|
|
|
key := node.Bytes()
|
|
|
|
value, _ := dstDb.Get(key)
|
|
|
|
|
|
|
|
dstDb.Delete(key)
|
|
|
|
if err := checkStateConsistency(dstDb, added[0]); err == nil {
|
|
|
|
t.Fatalf("trie inconsistency not caught, missing: %x", key)
|
|
|
|
}
|
|
|
|
dstDb.Put(key, value)
|
|
|
|
}
|
|
|
|
}
|