tornadocontrib/go-ethereum
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

usbwallet: check error returned by driver close (#18057)

Browse Source 
Although current two implementations(ledgerDriver, trezorDriver) of interface driver.Close do not actually return any error. Instead, they only return nil.
But since the declaration of Close function returns error, it is better to check the returned error in case in future some new implementation of Close function returns error and we may forget to modify the function which invokes Close function at that time.
This commit is contained in:
Corey Lin 2019-03-07 18:13:06 +08:00 committed by Péter Szilágyi
parent 5f94f8c7e7
commit 2fa9e99fc1
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
accounts/usbwallet/wallet.go
View File

@ -274,9 +274,7 @@ func (w *wallet) close() error {
w.device = nil w.device = nil
w.accounts, w.paths = nil, nil w.accounts, w.paths = nil, nil
w.driver.Close() return w.driver.Close()
return nil
} }
// Accounts implements accounts.Wallet, returning the list of accounts pinned to // Accounts implements accounts.Wallet, returning the list of accounts pinned to