tornadocontrib/go-ethereum
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

metrics: fix flaky Example metrics test (#16222)

Browse Source 
* metrics: add sleep to test in order to get predictable output

* metrics: relax constraints on timer test
This commit is contained in:
Anton Evangelatov 2018-03-01 18:55:31 +01:00 committed by Péter Szilágyi
parent 5a150e1b77
commit 3ca3fffdf0
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
metrics/metrics_test.go
View File

@ -6,6 +6,7 @@ import (
"log" "log"
"sync" "sync"
"testing" "testing"
"time"
) )
const FANOUT = 128 const FANOUT = 128
@ -114,7 +115,7 @@ func Example() {
// Threadsafe registration // Threadsafe registration
t := GetOrRegisterTimer("db.get.latency", nil) t := GetOrRegisterTimer("db.get.latency", nil)
t.Time(func() {}) t.Time(func() { time.Sleep(10 * time.Millisecond) })
t.Update(1) t.Update(1)
fmt.Println(c.Count()) fmt.Println(c.Count())

4
metrics/timer_test.go
View File

@ -47,8 +47,8 @@ func TestTimerStop(t *testing.T) {
func TestTimerFunc(t *testing.T) { func TestTimerFunc(t *testing.T) {
tm := NewTimer() tm := NewTimer()
tm.Time(func() { time.Sleep(50e6) }) tm.Time(func() { time.Sleep(50e6) })
if max := tm.Max(); 45e6 > max || max > 55e6 { if max := tm.Max(); 35e6 > max || max > 95e6 {
t.Errorf("tm.Max(): 45e6 > %v || %v > 55e6\n", max, max) t.Errorf("tm.Max(): 35e6 > %v || %v > 95e6\n", max, max)
} }
} }