tornadocontrib/go-ethereum
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

signer/core: always pad clique header extra data with space for sealer's signature (#24941)

Browse Source 
* signer/core: always pad clique header extra data with space for sealer's signature

* capitalize comment
This commit is contained in:
jwasinger 2022-05-23 22:18:03 -10:00 committed by GitHub
parent 94c8de0217
commit 3ff479bc94
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
signer/core/signed_data.go
View File

@ -147,13 +147,11 @@ func (api *SignerAPI) determineSignatureFormat(ctx context.Context, contentType
if err := rlp.DecodeBytes(cliqueData, header); err != nil { if err := rlp.DecodeBytes(cliqueData, header); err != nil {
return nil, useEthereumV, err return nil, useEthereumV, err
} }
// The incoming clique header is already truncated, sent to us with a extradata already shortened // Add space in the extradata to put the signature
if len(header.Extra) < 65 { newExtra := make([]byte, len(header.Extra)+65)
// Need to add it back, to get a suitable length for hashing copy(newExtra, header.Extra)
newExtra := make([]byte, len(header.Extra)+65) header.Extra = newExtra
copy(newExtra, header.Extra)
header.Extra = newExtra
}
// Get back the rlp data, encoded by us // Get back the rlp data, encoded by us
sighash, cliqueRlp, err := cliqueHeaderHashAndRlp(header) sighash, cliqueRlp, err := cliqueHeaderHashAndRlp(header)
if err != nil { if err != nil {