tornadocontrib/go-ethereum
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ethclient: don't crash if server returns null uncle header

Browse Source 
It should never return null for a known uncle, but even if it does
we can't just crash.
This commit is contained in:
Felix Lange 2016-11-29 13:57:46 +01:00
parent 2dcf75a722
commit 4cb29bde2e
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ethclient/ethclient.go
View File

@ -123,6 +123,9 @@ func (ec *Client) getBlock(ctx context.Context, method string, args ...interface
if reqs[i].Error != nil { if reqs[i].Error != nil {
return nil, reqs[i].Error return nil, reqs[i].Error
} }
if uncles[i] == nil {
return nil, fmt.Errorf("got null header for uncle %d of block %x", i, body.Hash[:])
}
} }
} }
return types.NewBlockWithHeader(head).WithBody(body.Transactions, uncles), nil return types.NewBlockWithHeader(head).WithBody(body.Transactions, uncles), nil