tornadocontrib/go-ethereum
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #140 from ethereum/add-missing-link-prop

Browse Source 
fix: adds missing legacyBehavior prop [Fixes #98]
This commit is contained in:
Corwin Smith 2022-12-09 03:53:38 +01:00 committed by GitHub
commit 4dee3f52f1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
12 changed files with 21 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/components/UI/ButtonLinkSecondary.tsx
View File

@ -18,7 +18,7 @@ export const ButtonLinkSecondary: React.FC<Props> = ({ href, children, ...restPr
<Text textStyle='home-section-link-label'>{children}</Text> <Text textStyle='home-section-link-label'>{children}</Text>
</Link> </Link>
) : ( ) : (
<NextLink href={href.toString()} passHref {...restProps}> <NextLink href={href.toString()} passHref legacyBehavior {...restProps}>
<Link variant='button-link-secondary'> <Link variant='button-link-secondary'>
<Text textStyle='home-section-link-label'>{children}</Text> <Text textStyle='home-section-link-label'>{children}</Text>
</Link> </Link>

2
src/components/UI/Header.tsx
View File

@ -27,7 +27,7 @@ export const Header: FC = () => {
borderColor='primary' borderColor='primary'
flexGrow={2} flexGrow={2}
> >
<NextLink href={'/'} passHref> <NextLink href={'/'} passHref legacyBehavior>
<Link _hover={{ textDecoration: 'none' }}> <Link _hover={{ textDecoration: 'none' }}>
<Text textStyle='header-font' whiteSpace='nowrap'> <Text textStyle='header-font' whiteSpace='nowrap'>
go-ethereum go-ethereum

4
src/components/UI/HeaderButtons.tsx
View File

@ -25,7 +25,7 @@ export const HeaderButtons: FC<Props> = ({ close }) => {
return ( return (
<Flex direction={{ base: 'column', md: 'row' }}> <Flex direction={{ base: 'column', md: 'row' }}>
{/* DOWNLOADS */} {/* DOWNLOADS */}
<NextLink href={DOWNLOADS_PAGE} passHref> <NextLink href={DOWNLOADS_PAGE} passHref legacyBehavior>
<Link _hover={{ textDecoration: 'none' }} onClick={close}> <Link _hover={{ textDecoration: 'none' }} onClick={close}>
<Stack {...menuItemStyles}> <Stack {...menuItemStyles}>
<Text textStyle={{ base: 'header-mobile-button', md: 'header-button' }}>downloads</Text> <Text textStyle={{ base: 'header-mobile-button', md: 'header-button' }}>downloads</Text>
@ -34,7 +34,7 @@ export const HeaderButtons: FC<Props> = ({ close }) => {
</NextLink> </NextLink>
{/* DOCUMENTATION */} {/* DOCUMENTATION */}
<NextLink href={DOCS_PAGE} passHref> <NextLink href={DOCS_PAGE} passHref legacyBehavior>
<Link _hover={{ textDecoration: 'none' }} onClick={close}> <Link _hover={{ textDecoration: 'none' }} onClick={close}>
<Stack {...menuItemStyles}> <Stack {...menuItemStyles}>
<Text textStyle={{ base: 'header-mobile-button', md: 'header-button' }}> <Text textStyle={{ base: 'header-mobile-button', md: 'header-button' }}>

6
src/components/UI/docs/Breadcrumbs.tsx
View File

@ -16,7 +16,11 @@ export const Breadcrumbs: FC = () => {
{pathSplit.map((path: string, idx: number) => { {pathSplit.map((path: string, idx: number) => {
return ( return (
<BreadcrumbItem key={path}> <BreadcrumbItem key={path}>
<NextLink href={`/${pathSplit.slice(0, idx + 1).join('/')}`} passHref> <NextLink
href={`/${pathSplit.slice(0, idx + 1).join('/')}`}
passHref
legacyBehavior
>
<BreadcrumbLink color={idx + 1 === pathSplit.length ? 'body' : 'primary'}> <BreadcrumbLink color={idx + 1 === pathSplit.length ? 'body' : 'primary'}>
{path} {path}
</BreadcrumbLink> </BreadcrumbLink>

2
src/components/UI/docs/DocsLinks.tsx
View File

@ -52,7 +52,7 @@ export const DocsLinks: FC<Props> = ({ navLinks }) => {
_groupHover={{ background: 'primary', color: 'bg', textDecoration: 'none' }} _groupHover={{ background: 'primary', color: 'bg', textDecoration: 'none' }}
> >
{to ? ( {to ? (
<NextLink href={to} passHref> <NextLink href={to} passHref legacyBehavior>
<Link textDecoration='none !important'> <Link textDecoration='none !important'>
<Text <Text
textStyle='docs-nav-dropdown' textStyle='docs-nav-dropdown'

2
src/components/UI/docs/DocumentNav.tsx
View File

@ -27,7 +27,7 @@ export const DocumentNav: FC<Props> = ({ content }) => {
<Divider borderColor='primary' my={`4 !important`} /> <Divider borderColor='primary' my={`4 !important`} />
{parsedHeadings.map((heading, idx) => { {parsedHeadings.map((heading, idx) => {
return ( return (
<NextLink key={`${idx} ${heading?.title}`} href={`#${heading?.headingId}`}> <NextLink key={`${idx} ${heading?.title}`} href={`#${heading?.headingId}`} legacyBehavior>
<Link m={0} textDecoration='none !important'> <Link m={0} textDecoration='none !important'>
<Text <Text
color={activeHash === heading?.headingId ? 'body' : 'primary'} color={activeHash === heading?.headingId ? 'body' : 'primary'}

2
src/components/UI/docs/LinksList.tsx
View File

@ -24,7 +24,7 @@ export const LinksList: FC<LinksListProps> = ({ links }) => {
_hover={{ background: 'primary', color: 'bg' }} _hover={{ background: 'primary', color: 'bg' }}
data-group data-group
> >
<NextLink href={to} passHref key={id}> <NextLink href={to} passHref key={id} legacyBehavior>
<Link textDecoration='none !important'> <Link textDecoration='none !important'>
<Text <Text
textStyle='docs-nav-links' textStyle='docs-nav-links'

2
src/components/UI/docs/MDComponents.tsx
View File

@ -35,7 +35,7 @@ const MDComponents = {
{children} {children}
</Link> </Link>
) : ( ) : (
<NextLink href={href} passHref> <NextLink href={href} passHref legacyBehavior>
<Link variant='light'>{children}</Link> <Link variant='light'>{children}</Link>
</NextLink> </NextLink>
); );

2
src/components/UI/downloads/DownloadsHero.tsx
View File

@ -82,7 +82,7 @@ export const DownloadsHero: FC<DownloadsHero> = ({
const { name, buildURL, Svg, ariaLabel } = DOWNLOAD_HEADER_BUTTONS[key]; const { name, buildURL, Svg, ariaLabel } = DOWNLOAD_HEADER_BUTTONS[key];
return ( return (
<NextLink key={key} href={buildURL} passHref> <NextLink key={key} href={buildURL} passHref legacyBehavior>
<Button as='a' variant='downloadsHeader' width={{ base: '100%' }} h={16} data-group> <Button as='a' variant='downloadsHeader' width={{ base: '100%' }} h={16} data-group>
<HStack spacing={4}> <HStack spacing={4}>
<Stack alignItems='center'> <Stack alignItems='center'>

4
src/components/UI/homepage/HomeHero.tsx
View File

@ -36,7 +36,7 @@ export const HomeHero: FC = () => {
alignItems={{ base: 'center', md: 'flex-start' }} alignItems={{ base: 'center', md: 'flex-start' }}
> >
<Flex direction='column' alignItems='center' mr={{ md: 6 }}> <Flex direction='column' alignItems='center' mr={{ md: 6 }}>
<NextLink href={DOWNLOADS_PAGE} passHref> <NextLink href={DOWNLOADS_PAGE} passHref legacyBehavior>
<Button variant='primary' as='a' mb={1} data-group> <Button variant='primary' as='a' mb={1} data-group>
<Text textStyle='homepage-primary-label'>Download</Text> <Text textStyle='homepage-primary-label'>Download</Text>
</Button> </Button>
@ -48,7 +48,7 @@ export const HomeHero: FC = () => {
</Flex> </Flex>
<Flex direction='column' alignItems='center'> <Flex direction='column' alignItems='center'>
<NextLink href={DOCS_PAGE} passHref> <NextLink href={DOCS_PAGE} passHref legacyBehavior>
<Button variant='primary' as='a' mb={1} data-group> <Button variant='primary' as='a' mb={1} data-group>
<Text textStyle='homepage-primary-label'>Documentation</Text> <Text textStyle='homepage-primary-label'>Documentation</Text>
</Button> </Button>

6
src/components/UI/homepage/QuickLinks.tsx
View File

@ -28,7 +28,7 @@ export const QuickLinks: FC = () => {
</Stack> </Stack>
</GridItem> </GridItem>
<GridItem borderBottom='2px solid' borderColor='primary'> <GridItem borderBottom='2px solid' borderColor='primary'>
<NextLink href={`${DOCS_PAGE}/getting-started`} passHref> <NextLink href={`${DOCS_PAGE}/getting-started`} passHref legacyBehavior>
<Link _hover={{ textDecoration: 'none' }}> <Link _hover={{ textDecoration: 'none' }}>
<Stack <Stack
data-group data-group
@ -66,7 +66,7 @@ export const QuickLinks: FC = () => {
</Stack> </Stack>
</GridItem> </GridItem>
<GridItem borderBottom='2px solid' borderColor='primary'> <GridItem borderBottom='2px solid' borderColor='primary'>
<NextLink href={FAQ_PAGE} passHref> <NextLink href={FAQ_PAGE} passHref legacyBehavior>
<Link _hover={{ textDecoration: 'none' }}> <Link _hover={{ textDecoration: 'none' }}>
<Stack <Stack
data-group data-group
@ -104,7 +104,7 @@ export const QuickLinks: FC = () => {
</Stack> </Stack>
</GridItem> </GridItem>
<GridItem> <GridItem>
<NextLink href={CONTRIBUTING_PAGE} passHref> <NextLink href={CONTRIBUTING_PAGE} passHref legacyBehavior>
<Link _hover={{ textDecoration: 'none' }}> <Link _hover={{ textDecoration: 'none' }}>
<Stack <Stack
data-group data-group

4
src/components/layouts/Footer.tsx
View File

@ -43,7 +43,7 @@ export const Footer: FC = () => {
borderColor='primary' borderColor='primary'
p={4} p={4}
> >
<NextLink href={DOWNLOADS_PAGE} passHref> <NextLink href={DOWNLOADS_PAGE} passHref legacyBehavior>
<Link _hover={{ textDecoration: 'none' }}> <Link _hover={{ textDecoration: 'none' }}>
<Text textStyle='footer-link-label'>DOWNLOADS</Text> <Text textStyle='footer-link-label'>DOWNLOADS</Text>
</Link> </Link>
@ -61,7 +61,7 @@ export const Footer: FC = () => {
borderColor='primary' borderColor='primary'
p={4} p={4}
> >
<NextLink href={DOCS_PAGE} passHref> <NextLink href={DOCS_PAGE} passHref legacyBehavior>
<Link _hover={{ textDecoration: 'none' }}> <Link _hover={{ textDecoration: 'none' }}>
<Text textStyle='footer-link-label'>DOCUMENTATION</Text> <Text textStyle='footer-link-label'>DOCUMENTATION</Text>
</Link> </Link>