Omit replies for notification requests
When Id is missing, the client does not want a response
This commit is contained in:
parent
f7fdb4dfbe
commit
5c6540452a
25
rpc/http.go
25
rpc/http.go
@ -87,7 +87,9 @@ func JSONRPC(pipe *xeth.XEth) http.Handler {
|
|||||||
var reqSingle RpcRequest
|
var reqSingle RpcRequest
|
||||||
if err := json.Unmarshal(body, &reqSingle); err == nil {
|
if err := json.Unmarshal(body, &reqSingle); err == nil {
|
||||||
response := RpcResponse(api, &reqSingle)
|
response := RpcResponse(api, &reqSingle)
|
||||||
send(w, &response)
|
if reqSingle.Id != nil {
|
||||||
|
send(w, &response)
|
||||||
|
}
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -96,11 +98,28 @@ func JSONRPC(pipe *xeth.XEth) http.Handler {
|
|||||||
if err := json.Unmarshal(body, &reqBatch); err == nil {
|
if err := json.Unmarshal(body, &reqBatch); err == nil {
|
||||||
// Build response batch
|
// Build response batch
|
||||||
resBatch := make([]*interface{}, len(reqBatch))
|
resBatch := make([]*interface{}, len(reqBatch))
|
||||||
|
resCount := 0
|
||||||
|
|
||||||
for i, request := range reqBatch {
|
for i, request := range reqBatch {
|
||||||
response := RpcResponse(api, &request)
|
response := RpcResponse(api, &request)
|
||||||
resBatch[i] = response
|
// this leaves nil entries in the response batch for later removal
|
||||||
|
if request.Id != nil {
|
||||||
|
resBatch[i] = response
|
||||||
|
resCount = resCount + 1
|
||||||
|
}
|
||||||
}
|
}
|
||||||
send(w, resBatch)
|
|
||||||
|
// make response omitting nil entries
|
||||||
|
respBatchComp := make([]*interface{}, resCount)
|
||||||
|
resCount = resCount - 1
|
||||||
|
for _, v := range resBatch {
|
||||||
|
if v != nil {
|
||||||
|
respBatchComp[resCount] = v
|
||||||
|
resCount = resCount - 1
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
send(w, respBatchComp)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user