tornadocontrib/go-ethereum
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #20762 from karalabe/fix-txprop-leak

Browse Source 
eth: fix transaction announce/broadcast goroutine leak
This commit is contained in:
Péter Szilágyi 2020-03-14 13:52:46 +02:00 committed by GitHub
commit 68b4b74682
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
eth/peer.go
View File

@ -157,7 +157,7 @@ func (p *peer) broadcastTransactions() {
var ( var (
queue []common.Hash // Queue of hashes to broadcast as full transactions queue []common.Hash // Queue of hashes to broadcast as full transactions
done chan struct{} // Non-nil if background broadcaster is running done chan struct{} // Non-nil if background broadcaster is running
fail = make(chan error) // Channel used to receive network error fail = make(chan error, 1) // Channel used to receive network error
) )
for { for {
// If there's no in-flight broadcast running, check if a new one is needed // If there's no in-flight broadcast running, check if a new one is needed
@ -219,7 +219,7 @@ func (p *peer) announceTransactions() {
var ( var (
queue []common.Hash // Queue of hashes to announce as transaction stubs queue []common.Hash // Queue of hashes to announce as transaction stubs
done chan struct{} // Non-nil if background announcer is running done chan struct{} // Non-nil if background announcer is running
fail = make(chan error) // Channel used to receive network error fail = make(chan error, 1) // Channel used to receive network error
) )
for { for {
// If there's no in-flight announce running, check if a new one is needed // If there's no in-flight announce running, check if a new one is needed