tornadocontrib/go-ethereum
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

event: move type fixation logic into Feed.init (#27249)

Browse Source 
This is a minor optimization/refactoring of Feed.

---------

Co-authored-by: Felix Lange <fjl@twurst.com>
This commit is contained in:
Seungbae Yu 2023-05-30 23:34:32 +09:00 committed by GitHub
parent 560dceb58e
commit 8013a494fe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
event/feed.go
View File

@ -57,7 +57,8 @@ func (e feedTypeError) Error() string {
return "event: wrong type in " + e.op + " got " + e.got.String() + ", want " + e.want.String() return "event: wrong type in " + e.op + " got " + e.got.String() + ", want " + e.want.String()
} }
func (f *Feed) init() { func (f *Feed) init(etype reflect.Type) {
f.etype = etype
f.removeSub = make(chan interface{}) f.removeSub = make(chan interface{})
f.sendLock = make(chan struct{}, 1) f.sendLock = make(chan struct{}, 1)
f.sendLock <- struct{}{} f.sendLock <- struct{}{}
@ -70,8 +71,6 @@ func (f *Feed) init() {
// The channel should have ample buffer space to avoid blocking other subscribers. // The channel should have ample buffer space to avoid blocking other subscribers.
// Slow subscribers are not dropped. // Slow subscribers are not dropped.
func (f *Feed) Subscribe(channel interface{}) Subscription { func (f *Feed) Subscribe(channel interface{}) Subscription {
f.once.Do(f.init)
chanval := reflect.ValueOf(channel) chanval := reflect.ValueOf(channel)
chantyp := chanval.Type() chantyp := chanval.Type()
if chantyp.Kind() != reflect.Chan || chantyp.ChanDir()&reflect.SendDir == 0 { if chantyp.Kind() != reflect.Chan || chantyp.ChanDir()&reflect.SendDir == 0 {
@ -79,11 +78,13 @@ func (f *Feed) Subscribe(channel interface{}) Subscription {
} }
sub := &feedSub{feed: f, channel: chanval, err: make(chan error, 1)} sub := &feedSub{feed: f, channel: chanval, err: make(chan error, 1)}
f.mu.Lock() f.once.Do(func() { f.init(chantyp.Elem()) })
defer f.mu.Unlock() if f.etype != chantyp.Elem() {
if !f.typecheck(chantyp.Elem()) {
panic(feedTypeError{op: "Subscribe", got: chantyp, want: reflect.ChanOf(reflect.SendDir, f.etype)}) panic(feedTypeError{op: "Subscribe", got: chantyp, want: reflect.ChanOf(reflect.SendDir, f.etype)})
} }
f.mu.Lock()
defer f.mu.Unlock()
// Add the select case to the inbox. // Add the select case to the inbox.
// The next Send will add it to f.sendCases. // The next Send will add it to f.sendCases.
cas := reflect.SelectCase{Dir: reflect.SelectSend, Chan: chanval} cas := reflect.SelectCase{Dir: reflect.SelectSend, Chan: chanval}
@ -91,15 +92,6 @@ func (f *Feed) Subscribe(channel interface{}) Subscription {
return sub return sub
} }
// note: callers must hold f.mu
func (f *Feed) typecheck(typ reflect.Type) bool {
if f.etype == nil {
f.etype = typ
return true
}
return f.etype == typ
}
func (f *Feed) remove(sub *feedSub) { func (f *Feed) remove(sub *feedSub) {
// Delete from inbox first, which covers channels // Delete from inbox first, which covers channels
// that have not been added to f.sendCases yet. // that have not been added to f.sendCases yet.
@ -128,19 +120,17 @@ func (f *Feed) remove(sub *feedSub) {
func (f *Feed) Send(value interface{}) (nsent int) { func (f *Feed) Send(value interface{}) (nsent int) {
rvalue := reflect.ValueOf(value) rvalue := reflect.ValueOf(value)
f.once.Do(f.init) f.once.Do(func() { f.init(rvalue.Type()) })
if f.etype != rvalue.Type() {
panic(feedTypeError{op: "Send", got: rvalue.Type(), want: f.etype})
}
<-f.sendLock <-f.sendLock
// Add new cases from the inbox after taking the send lock. // Add new cases from the inbox after taking the send lock.
f.mu.Lock() f.mu.Lock()
f.sendCases = append(f.sendCases, f.inbox...) f.sendCases = append(f.sendCases, f.inbox...)
f.inbox = nil f.inbox = nil
if !f.typecheck(rvalue.Type()) {
f.sendLock <- struct{}{}
f.mu.Unlock()
panic(feedTypeError{op: "Send", got: rvalue.Type(), want: f.etype})
}
f.mu.Unlock() f.mu.Unlock()
// Set the sent value on all channels. // Set the sent value on all channels.