tornadocontrib/go-ethereum
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

internal/debug: use pprof goroutine writer for debug_stacks (#16892)

Browse Source 
* debug: Use pprof goroutine writer in debug.Stacks() to ensure all goroutines are captured.

* Up to 64MB limit, previous code only captured first 1MB of goroutines.

* internal/debug: simplify stacks handler

* fix typo

* fix pointer receiver
This commit is contained in:
Ryan Schneider 2018-06-14 09:58:44 -04:00 committed by Péter Szilágyi
parent ec192f18b4
commit 897ea01d5f
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
internal/debug/api.go
View File

@ -21,6 +21,7 @@
package debug package debug
import ( import (
"bytes"
"errors" "errors"
"io" "io"
"os" "os"
@ -190,9 +191,9 @@ func (*HandlerT) WriteMemProfile(file string) error {
// Stacks returns a printed representation of the stacks of all goroutines. // Stacks returns a printed representation of the stacks of all goroutines.
func (*HandlerT) Stacks() string { func (*HandlerT) Stacks() string {
buf := make([]byte, 1024*1024) buf := new(bytes.Buffer)
buf = buf[:runtime.Stack(buf, true)] pprof.Lookup("goroutine").WriteTo(buf, 2)
return string(buf) return buf.String()
} }
// FreeOSMemory returns unused memory to the OS. // FreeOSMemory returns unused memory to the OS.