tornadocontrib/go-ethereum
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rpc: fix subscription buffer documentation and test (#19747)

Browse Source 
This PR updates a comment about the maximum client subscription buffer
to reflect changes made previously, and fixes a test that wouldn't fail
when wantError == true but execution did not return an error.
This commit is contained in:
Rob Mulholand 2019-06-24 05:43:18 -05:00 committed by Felix Lange
parent 92a90d7578
commit 98099d6fa7
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
rpc/client.go
View File

@ -412,7 +412,7 @@ func (c *Client) ShhSubscribe(ctx context.Context, channel interface{}, args ...
// The context argument cancels the RPC request that sets up the subscription but has no // The context argument cancels the RPC request that sets up the subscription but has no
// effect on the subscription after Subscribe has returned. // effect on the subscription after Subscribe has returned.
// //
// Slow subscribers will be dropped eventually. Client buffers up to 8000 notifications // Slow subscribers will be dropped eventually. Client buffers up to 20000 notifications
// before considering the subscriber dead. The subscription Err channel will receive // before considering the subscriber dead. The subscription Err channel will receive
// ErrSubscriptionQueueOverflow. Use a sufficiently large buffer on the channel or ensure // ErrSubscriptionQueueOverflow. Use a sufficiently large buffer on the channel or ensure
// that the channel usually has at least one reader to prevent this issue. // that the channel usually has at least one reader to prevent this issue.

5
rpc/client_test.go
View File

@ -374,10 +374,13 @@ func TestClientNotificationStorm(t *testing.T) {
return return
} }
} }
if wantError {
t.Fatalf("didn't get expected error")
}
} }
doTest(8000, false) doTest(8000, false)
doTest(10000, true) doTest(21000, true)
} }
func TestClientHTTP(t *testing.T) { func TestClientHTTP(t *testing.T) {