Felix Lange
04c6369a09
p2p, p2p/discover: track bootstrap state in p2p/discover
...
This change simplifies the dial scheduling logic because it
no longer needs to track whether the discovery table has been
bootstrapped.
2015-12-17 23:38:54 +01:00
Péter Szilágyi
abb53644c6
p2p: always allow dynamic dials if network not disabled
2015-12-03 11:45:35 +02:00
Péter Szilágyi
e46ab3bdcd
eth, p2p, rpc/api: polish protocol info gathering
2015-10-28 12:44:15 +02:00
Jeffrey Wilcke
e2d44814a5
Merge pull request #1694 from obscuren/hide-fdtrack
...
fdtrack: hide message
2015-08-19 13:50:54 -07:00
Jeffrey Wilcke
269c5c7107
Revert "fdtrack: temporary hack for tracking file descriptor usage"
...
This reverts commit 5c949d3b3ba81ea0563575b19a7b148aeac4bf61.
2015-08-19 21:46:01 +02:00
Felix Lange
edccc7ae34
p2p: continue listening after temporary errors
2015-08-19 14:39:04 +02:00
Felix Lange
5c949d3b3b
fdtrack: temporary hack for tracking file descriptor usage
...
Package fdtrack logs statistics about open file descriptors.
This should help identify the source of #1549 .
2015-08-04 03:10:27 +02:00
Felix Lange
bfbcfbe4a9
all: fix license headers one more time
...
I forgot to update one instance of "go-ethereum" in commit 3f047be5a.
2015-07-23 18:35:11 +02:00
Felix Lange
3f047be5aa
all: update license headers to distiguish GPL/LGPL
...
All code outside of cmd/ is licensed as LGPL. The headers
now reflect this by calling the whole work "the go-ethereum library".
2015-07-22 18:51:45 +02:00
Felix Lange
bdae4fd573
all: add some godoc synopsis comments
2015-07-07 14:12:45 +02:00
Felix Lange
ea54283b30
all: update license information
2015-07-07 14:12:44 +02:00
Péter Szilágyi
6994a3daaa
p2p: instrument P2P networking layer
2015-06-24 18:33:33 +03:00
Felix Lange
6fb810adaa
p2p: throttle all discovery lookups
...
Lookup calls would spin out of control when network connectivity was
lost. The throttling that was in place only took effect when the table
returned zero results, which doesn't happen very often.
The new throttling should not have a negative impact when the host is
online. Lookups against the network take some time and dials for all
results must complete or hit the cache before a new one is started. This
usually takes longer than four seconds, leaving online lookups
unaffected.
Fixes #1296
2015-06-22 01:07:58 +02:00
Felix Lange
3239aca69b
p2p: bump global write timeout to 20s
...
The previous value of 5 seconds causes timeouts for legitimate messages
if large messages are sent.
2015-06-09 17:07:10 +02:00
Péter Szilágyi
68898a4d6b
p2p: fix Self() panic if listening is disabled
2015-05-26 19:16:05 +03:00
Péter Szilágyi
e1a0ee8fc5
cmd/geth, cmd/utils, eth, p2p: pass and honor a no discovery flag
2015-05-26 19:07:24 +03:00
Péter Szilágyi
278183c7e7
eth, p2p: start the p2p server even if maxpeers == 0
2015-05-26 17:49:37 +03:00
Felix Lange
9e1fd70b50
p2p: decrease frameReadTimeout to 30s
...
This detects hanging connections sooner. We send a ping every 15s and
other implementation have similar limits.
2015-05-25 01:17:14 +02:00
Felix Lange
1440f9a37a
p2p: new dialer, peer management without locks
...
The most visible change is event-based dialing, which should be an
improvement over the timer-based system that we have at the moment.
The dialer gets a chance to compute new tasks whenever peers change or
dials complete. This is better than checking peers on a timer because
dials happen faster. The dialer can now make more precise decisions
about whom to dial based on the peer set and we can test those
decisions without actually opening any sockets.
Peer management is easier to test because the tests can inject
connections at checkpoints (after enc handshake, after protocol
handshake).
Most of the handshake stuff is now part of the RLPx code. It could be
exported or move to its own package because it is no longer entangled
with Server logic.
2015-05-25 01:17:14 +02:00
Felix Lange
dbdc5fd4b3
p2p: delete Server.Broadcast
2015-05-25 01:17:14 +02:00
Felix Lange
7efeb4bd96
p2p: bump maxAcceptConns and defaultDialTimout
...
On the test network, we've seen that it becomes harder to connect
if the queues are so short.
2015-05-14 03:48:28 +02:00
Felix Lange
d4f0a67323
p2p: drop connections with no matching protocols
2015-05-08 16:09:55 +02:00
Felix Lange
9c0f36c46d
p2p: use maxDialingConns instead of maxAcceptConns as dial limit
2015-05-08 16:09:55 +02:00
Felix Lange
914e57e49b
p2p: fix disconnect at capacity
...
With the introduction of static/trusted nodes, the peer count
can go above MaxPeers. Update the capacity check to handle this.
While here, decouple the trusted nodes check from the handshake
by passing a function instead.
2015-05-08 16:09:54 +02:00
Péter Szilágyi
4d5a719f25
cmd, eth, p2p: introduce pending peer cli arg, add tests
2015-05-07 15:30:56 +03:00
Péter Szilágyi
af93217775
p2p: reduce the concurrent handshakes to 10/10 in/out
2015-05-07 15:22:09 +03:00
Péter Szilágyi
2060bc8bac
p2p: fix dial throttling race condition
2015-05-07 15:22:08 +03:00
Péter Szilágyi
29fef349ef
p2p: fix a dialing race in the throttler
2015-05-07 15:22:08 +03:00
Péter Szilágyi
3953bf0031
p2p: limit the outbound dialing too
2015-05-07 15:22:08 +03:00
Jeffrey Wilcke
a0cb1945ae
Merge pull request #866 from fjl/p2p-last-minute
...
Last minute p2p fixes
2015-05-06 14:49:52 -07:00
Felix Lange
3e2a928caa
p2p: stop dialing at half the maximum peer count
2015-05-06 23:44:51 +02:00
obscuren
062fa049d0
fixed merge issue
2015-05-06 22:54:21 +02:00
Péter Szilágyi
4accc187d5
eth, p2p: add trusted node list beside static list
2015-05-04 13:59:51 +03:00
Péter Szilágyi
54db54931e
p2p: add static node dialing test
2015-05-04 13:08:42 +03:00
Péter Szilágyi
e82ddd9198
p2p: correct a leftover trusted -> static
2015-04-30 19:34:33 +03:00
Péter Szilágyi
413ace37d3
eth, p2p: rename trusted nodes to static, drop inbound extra slots
2015-04-30 19:32:48 +03:00
Péter Szilágyi
701591b403
cmd, eth, p2p: fix review issues enumerated by Felix
2015-04-30 16:15:29 +03:00
Péter Szilágyi
1528dbc171
p2p: add trust check to handshake, test privileged connectivity
...
Conflicts:
p2p/server_test.go
2015-04-30 16:06:47 +03:00
Péter Szilágyi
14f32a0c3a
p2p: reduce the severity of a debug log
2015-04-30 16:04:09 +03:00
Péter Szilágyi
de0549fabb
cmd/geth, cmd/mist, cmd/utils, eth, p2p: support trusted peers
2015-04-30 16:03:10 +03:00
Felix Lange
fc747ef4a6
p2p/discover: new endpoint format
...
This commit changes the discovery protocol to use the new "v4" endpoint
format, which allows for separate UDP and TCP ports and makes it
possible to discover the UDP address after NAT.
2015-04-30 14:57:33 +02:00
Péter Szilágyi
8646365b42
cmd/bootnode, eth, p2p, p2p/discover: use a fancier db design
2015-04-24 18:04:41 +03:00
Péter Szilágyi
6def110c37
cmd/bootnode, eth, p2p, p2p/discover: clean up the seeder and mesh into eth.
2015-04-24 11:33:55 +03:00
Péter Szilágyi
5f735d6fce
cmd, eth, p2p, p2p/discover: init and clean up the seed cache
2015-04-24 11:23:20 +03:00
Felix Lange
635b66acdc
p2p: return zero node from Self if the server is not running
...
This helps with fixing the tests for cmd/geth to run without networking.
2015-04-22 12:31:19 +02:00
Felix Lange
5528abc795
p2p: fix the dial timer
...
The dial timer was not reset properly when the peer count reached
MaxPeers.
2015-04-17 08:17:01 +02:00
obscuren
474aa924ca
p2p: added limiter function to limit package broadcasting
2015-04-14 12:47:31 +02:00
Felix Lange
b9929d289d
p2p: fix unsynchronized map access during Server shutdown
...
removePeer can be called even after listenLoop and dialLoop have returned.
2015-04-13 17:37:32 +02:00
Felix Lange
c5332537f5
p2p: limit number of lingering inbound pre-handshake connections
...
This is supposed to apply some back pressure so Server is not accepting
more connections than it can actually handle. The current limit is 50.
This doesn't really need to be configurable, but we'll see how it
behaves in our test nodes and adjust accordingly.
2015-04-10 17:24:41 +02:00
Felix Lange
56977c225e
p2p: use RLock instead of Lock for pre-dial checks
2015-04-10 17:23:09 +02:00
Felix Lange
b3c058a9e4
p2p: improve disconnect signaling at handshake time
...
As of this commit, p2p will disconnect nodes directly after the
encryption handshake if too many peer connections are active.
Errors in the protocol handshake packet are now handled more politely
by sending a disconnect packet before closing the connection.
2015-04-10 16:57:56 +02:00
Felix Lange
145330fdf2
p2p: properly decrement peer wait group counter for setup errors
2015-04-10 13:26:27 +02:00
Felix Lange
22d1f0faf1
p2p: improve peer selection logic
...
This commit introduces a new (temporary) peer selection
strategy based on random lookups.
While we're here, also implement the TODOs in dialLoop.
2015-04-10 13:26:27 +02:00
obscuren
688d118c7e
Updated logging
2015-04-07 14:57:04 +02:00
Felix Lange
5ba51594c7
p2p: use package rlp to encode messages
...
Message encoding functions have been renamed to catch any uses.
The switch to the new encoder can cause subtle incompatibilities.
If there are any users outside of our tree, they will at least be
alerted that there was a change.
NewMsg no longer exists. The replacements for EncodeMsg are called
Send and SendItems.
2015-03-19 15:11:02 +01:00
zelig
b3e133dd15
Merge branch 'frontier/js' into frontier/nodeadmin.js
2015-03-16 22:50:29 +07:00
obscuren
b523441361
Moved ethutil => common
2015-03-16 11:27:38 +01:00
zelig
e150832734
p2p: server>discover table Self=Node exported
2015-03-15 13:38:41 +07:00
Taylor Gerring
485e37e889
Move MakeName to ethutil
2015-03-11 14:29:07 -05:00
Felix Lange
215c763d53
eth, p2p: delete p2p.Blacklist
...
It is unused and untested right now. We can
bring it back later if required.
2015-03-04 16:54:36 +01:00
Felix Lange
22659a7fea
p2p: restore read/write timeouts
...
They got lost in the transition to rlpxFrameRW.
2015-03-04 16:42:00 +01:00
Felix Lange
7964f30dcb
p2p: msg.Payload contains list data
...
With RLPx frames, the message code is contained in the
frame and is no longer part of the encoded data.
EncodeMsg, Msg.Decode have been updated to match.
Code that decodes RLP directly from Msg.Payload will need
to change.
2015-03-04 12:27:24 +01:00
Felix Lange
736e632215
p2p: use RLPx frames for messaging
2015-03-04 12:27:23 +01:00
Felix Lange
3719db352a
p2p: emit JSON connect/disconnect events
2015-02-19 17:09:33 +01:00
Felix Lange
dd871e791c
p2p: initialize Server.ourHandshake before accepting connections
2015-02-19 17:08:18 +01:00
Felix Lange
73f94f3755
p2p: disable encryption handshake
...
The diff is a bit bigger than expected because the protocol handshake
logic has moved out of Peer. This is necessary because the protocol
handshake will have custom framing in the final protocol.
2015-02-19 16:54:53 +01:00
obscuren
09e53367a2
Use a mutex write-lock for a write operation
2015-02-15 02:13:24 +01:00
Felix Lange
5cc1256fd6
p2p: ensure we don't dial ourself
...
addPeer doesn't allow self connects, but we can avoid opening
connections in the first place.
2015-02-13 15:06:47 +01:00
Felix Lange
7101f44998
p2p: add I/O timeout for encrytion handshake
2015-02-13 15:06:47 +01:00
Felix Lange
22ee366ed6
p2p: fix goroutine leak for invalid peers
...
The deflect logic called Disconnect on the peer, but the peer never ran
and wouldn't process the disconnect request.
2015-02-13 15:06:46 +01:00
Felix Lange
170eb3ac68
p2p/discover: map listening port using configured mechanism
2015-02-13 11:39:32 +01:00
Felix Lange
d0a2e655c9
cmd/ethereum, cmd/mist, eth, p2p: use package p2p/nat
...
This deletes the old NAT implementation.
2015-02-13 11:39:31 +01:00
Felix Lange
028775a086
cmd/ethereum, cmd/mist: add flag for discovery bootstrap nodes
2015-02-07 00:52:49 +01:00
Felix Lange
2cf4fed11b
cmd/mist, eth, javascript, p2p: use Node URLs for peer suggestions
2015-02-07 00:46:56 +01:00
Felix Lange
e34d134102
p2p: fixes for actual connections
...
The unit test hooks were turned on 'in production'.
2015-02-07 00:43:52 +01:00
Felix Lange
8564eb9f7e
p2p/discover: add node URL functions, distinguish TCP/UDP ports
...
The discovery RPC protocol does not yet distinguish TCP and UDP ports.
But it can't hurt to do so in our internal model.
2015-02-07 00:12:23 +01:00
Felix Lange
5bdc115943
p2p: integrate p2p/discover
...
Overview of changes:
- ClientIdentity has been removed, use discover.NodeID
- Server now requires a private key to be set (instead of public key)
- Server performs the encryption handshake before launching Peer
- Dial logic takes peers from discover table
- Encryption handshake code has been cleaned up a bit
- baseProtocol is gone because we don't exchange peers anymore
- Some parts of baseProtocol have moved into Peer instead
2015-02-06 00:00:36 +01:00
obscuren
8d1637f567
Moved connection errors to DebugDetail level
2015-01-19 11:21:46 +01:00
obscuren
6abf8ef78f
Merge
2015-01-05 17:10:42 +01:00
Felix Lange
aa3b91b802
p2p: fix call to Server.removePeer (might help with #209 )
2014-12-15 22:36:59 +01:00
obscuren
56dac74f71
made mist in a compilable, workable state using the new refactored packages
2014-12-15 13:00:29 +01:00
Felix Lange
59b63caf5e
p2p: API cleanup and PoC 7 compatibility
...
Whoa, one more big commit. I didn't manage to untangle the
changes while working towards compatibility.
2014-11-21 21:52:45 +01:00
Felix Lange
f38052c499
p2p: rework protocol API
2014-11-21 21:52:45 +01:00
Felix Lange
f3473312ba
all: fix rename breakage
2014-10-31 18:52:58 +01:00
zelig
771fbcc02e
initial commit of p2p package
2014-10-23 16:57:54 +01:00