9298074633
This PR attempts to fix a strange test-failure (timeout) observed on a windows-32 platform. https://ci.appveyor.com/project/ethereum/go-ethereum/builds/51174391/job/d8ascanwwltrlqd5 A goroutine is stuck trying to deliver a response: ``` goroutine 9632 [select, 29 minutes]: github.com/ethereum/go-ethereum/eth/protocols/eth.(*Peer).dispatchResponse(0x314f100, 0x3e5f6d0, 0x3acbb84) C:/projects/go-ethereum/eth/protocols/eth/dispatcher.go:172 +0x2a5 github.com/ethereum/go-ethereum/eth/protocols/eth.handleBlockHeaders({0x12abe68, 0x30021b8}, {0x12a815c, 0x40b41c0}, 0x314f100) C:/projects/go-ethereum/eth/protocols/eth/handlers.go:301 +0x173 github.com/ethereum/go-ethereum/eth/protocols/eth.handleMessage({0x12abe68, 0x30021b8}, 0x314f100) C:/projects/go-ethereum/eth/protocols/eth/handler.go:205 +0x4f6 github.com/ethereum/go-ethereum/eth/protocols/eth.Handle({0x12abe68, 0x30021b8}, 0x314f100) C:/projects/go-ethereum/eth/protocols/eth/handler.go:149 +0x33 github.com/ethereum/go-ethereum/eth.testSnapSyncDisabling.func1(0x314f100) C:/projects/go-ethereum/eth/sync_test.go:65 +0x33 github.com/ethereum/go-ethereum/eth.(*handler).runEthPeer(0x30021b8, 0x314f100, 0x427f648) C:/projects/go-ethereum/eth/handler.go:355 +0xe65 created by github.com/ethereum/go-ethereum/eth.testSnapSyncDisabling in goroutine 11 C:/projects/go-ethereum/eth/sync_test.go:64 +0x54f FAIL github.com/ethereum/go-ethereum/eth 1800.138s ``` --------- Co-authored-by: Gary Rong <garyrong0905@gmail.com>
97 lines
3.6 KiB
Go
97 lines
3.6 KiB
Go
// Copyright 2015 The go-ethereum Authors
|
|
// This file is part of the go-ethereum library.
|
|
//
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Lesser General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package eth
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/ethereum/go-ethereum/eth/ethconfig"
|
|
"github.com/ethereum/go-ethereum/eth/protocols/eth"
|
|
"github.com/ethereum/go-ethereum/eth/protocols/snap"
|
|
"github.com/ethereum/go-ethereum/p2p"
|
|
"github.com/ethereum/go-ethereum/p2p/enode"
|
|
)
|
|
|
|
// Tests that snap sync is disabled after a successful sync cycle.
|
|
func TestSnapSyncDisabling68(t *testing.T) { testSnapSyncDisabling(t, eth.ETH68, snap.SNAP1) }
|
|
|
|
// Tests that snap sync gets disabled as soon as a real block is successfully
|
|
// imported into the blockchain.
|
|
func testSnapSyncDisabling(t *testing.T, ethVer uint, snapVer uint) {
|
|
t.Parallel()
|
|
|
|
// Create an empty handler and ensure it's in snap sync mode
|
|
empty := newTestHandler()
|
|
if !empty.handler.snapSync.Load() {
|
|
t.Fatalf("snap sync disabled on pristine blockchain")
|
|
}
|
|
defer empty.close()
|
|
|
|
// Create a full handler and ensure snap sync ends up disabled
|
|
full := newTestHandlerWithBlocks(1024)
|
|
if full.handler.snapSync.Load() {
|
|
t.Fatalf("snap sync not disabled on non-empty blockchain")
|
|
}
|
|
defer full.close()
|
|
|
|
// Sync up the two handlers via both `eth` and `snap`
|
|
caps := []p2p.Cap{{Name: "eth", Version: ethVer}, {Name: "snap", Version: snapVer}}
|
|
|
|
emptyPipeEth, fullPipeEth := p2p.MsgPipe()
|
|
defer emptyPipeEth.Close()
|
|
defer fullPipeEth.Close()
|
|
|
|
emptyPeerEth := eth.NewPeer(ethVer, p2p.NewPeer(enode.ID{1}, "", caps), emptyPipeEth, empty.txpool)
|
|
fullPeerEth := eth.NewPeer(ethVer, p2p.NewPeer(enode.ID{2}, "", caps), fullPipeEth, full.txpool)
|
|
defer emptyPeerEth.Close()
|
|
defer fullPeerEth.Close()
|
|
|
|
go empty.handler.runEthPeer(emptyPeerEth, func(peer *eth.Peer) error {
|
|
return eth.Handle((*ethHandler)(empty.handler), peer)
|
|
})
|
|
go full.handler.runEthPeer(fullPeerEth, func(peer *eth.Peer) error {
|
|
return eth.Handle((*ethHandler)(full.handler), peer)
|
|
})
|
|
|
|
emptyPipeSnap, fullPipeSnap := p2p.MsgPipe()
|
|
defer emptyPipeSnap.Close()
|
|
defer fullPipeSnap.Close()
|
|
|
|
emptyPeerSnap := snap.NewPeer(snapVer, p2p.NewPeer(enode.ID{1}, "", caps), emptyPipeSnap)
|
|
fullPeerSnap := snap.NewPeer(snapVer, p2p.NewPeer(enode.ID{2}, "", caps), fullPipeSnap)
|
|
|
|
go empty.handler.runSnapExtension(emptyPeerSnap, func(peer *snap.Peer) error {
|
|
return snap.Handle((*snapHandler)(empty.handler), peer)
|
|
})
|
|
go full.handler.runSnapExtension(fullPeerSnap, func(peer *snap.Peer) error {
|
|
return snap.Handle((*snapHandler)(full.handler), peer)
|
|
})
|
|
// Wait a bit for the above handlers to start
|
|
time.Sleep(250 * time.Millisecond)
|
|
|
|
// Check that snap sync was disabled
|
|
if err := empty.handler.downloader.BeaconSync(ethconfig.SnapSync, full.chain.CurrentBlock(), nil); err != nil {
|
|
t.Fatal("sync failed:", err)
|
|
}
|
|
time.Sleep(time.Second * 5) // Downloader internally has to wait a timer (3s) to be expired before exiting
|
|
|
|
if empty.handler.snapSync.Load() {
|
|
t.Fatalf("snap sync not disabled after successful synchronisation")
|
|
}
|
|
}
|