9045b79bc2
This PR modifies how the metrics library handles `Enabled`: previously, the package `init` decided whether to serve real metrics or just dummy-types. This has several drawbacks: - During pkg init, we need to determine whether metrics are enabled or not. So we first hacked in a check if certain geth-specific commandline-flags were enabled. Then we added a similar check for geth-env-vars. Then we almost added a very elaborate check for toml-config-file, plus toml parsing. - Using "real" types and dummy types interchangeably means that everything is hidden behind interfaces. This has a performance penalty, and also it just adds a lot of code. This PR removes the interface stuff, uses concrete types, and allows for the setting of Enabled to happen later. It is still assumed that `metrics.Enable()` is invoked early on. The somewhat 'heavy' operations, such as ticking meters and exp-decay, now checks the enable-flag to prevent resource leak. The change may be large, but it's mostly pretty trivial, and from the last time I gutted the metrics, I ensured that we have fairly good test coverage. --------- Co-authored-by: Felix Lange <fjl@twurst.com>
74 lines
1.5 KiB
Go
74 lines
1.5 KiB
Go
package metrics
|
|
|
|
import (
|
|
"sync"
|
|
"testing"
|
|
)
|
|
|
|
func BenchmarkCounterFloat64(b *testing.B) {
|
|
c := NewCounterFloat64()
|
|
b.ResetTimer()
|
|
for i := 0; i < b.N; i++ {
|
|
c.Inc(1.0)
|
|
}
|
|
}
|
|
|
|
func BenchmarkCounterFloat64Parallel(b *testing.B) {
|
|
c := NewCounterFloat64()
|
|
b.ResetTimer()
|
|
var wg sync.WaitGroup
|
|
for i := 0; i < 10; i++ {
|
|
wg.Add(1)
|
|
go func() {
|
|
for i := 0; i < b.N; i++ {
|
|
c.Inc(1.0)
|
|
}
|
|
wg.Done()
|
|
}()
|
|
}
|
|
wg.Wait()
|
|
if have, want := c.Snapshot().Count(), 10.0*float64(b.N); have != want {
|
|
b.Fatalf("have %f want %f", have, want)
|
|
}
|
|
}
|
|
|
|
func TestCounterFloat64(t *testing.T) {
|
|
c := NewCounterFloat64()
|
|
if count := c.Snapshot().Count(); count != 0 {
|
|
t.Errorf("wrong count: %v", count)
|
|
}
|
|
c.Dec(1.0)
|
|
if count := c.Snapshot().Count(); count != -1.0 {
|
|
t.Errorf("wrong count: %v", count)
|
|
}
|
|
snapshot := c.Snapshot()
|
|
c.Dec(2.0)
|
|
if count := c.Snapshot().Count(); count != -3.0 {
|
|
t.Errorf("wrong count: %v", count)
|
|
}
|
|
c.Inc(1.0)
|
|
if count := c.Snapshot().Count(); count != -2.0 {
|
|
t.Errorf("wrong count: %v", count)
|
|
}
|
|
c.Inc(2.0)
|
|
if count := c.Snapshot().Count(); count != 0.0 {
|
|
t.Errorf("wrong count: %v", count)
|
|
}
|
|
if count := snapshot.Count(); count != -1.0 {
|
|
t.Errorf("snapshot count wrong: %v", count)
|
|
}
|
|
c.Inc(1.0)
|
|
c.Clear()
|
|
if count := c.Snapshot().Count(); count != 0.0 {
|
|
t.Errorf("wrong count: %v", count)
|
|
}
|
|
}
|
|
|
|
func TestGetOrRegisterCounterFloat64(t *testing.T) {
|
|
r := NewRegistry()
|
|
NewRegisteredCounterFloat64("foo", r).Inc(47.0)
|
|
if c := GetOrRegisterCounterFloat64("foo", r).Snapshot(); c.Count() != 47.0 {
|
|
t.Fatal(c)
|
|
}
|
|
}
|