9045b79bc2
This PR modifies how the metrics library handles `Enabled`: previously, the package `init` decided whether to serve real metrics or just dummy-types. This has several drawbacks: - During pkg init, we need to determine whether metrics are enabled or not. So we first hacked in a check if certain geth-specific commandline-flags were enabled. Then we added a similar check for geth-env-vars. Then we almost added a very elaborate check for toml-config-file, plus toml parsing. - Using "real" types and dummy types interchangeably means that everything is hidden behind interfaces. This has a performance penalty, and also it just adds a lot of code. This PR removes the interface stuff, uses concrete types, and allows for the setting of Enabled to happen later. It is still assumed that `metrics.Enable()` is invoked early on. The somewhat 'heavy' operations, such as ticking meters and exp-decay, now checks the enable-flag to prevent resource leak. The change may be large, but it's mostly pretty trivial, and from the last time I gutted the metrics, I ensured that we have fairly good test coverage. --------- Co-authored-by: Felix Lange <fjl@twurst.com>
62 lines
1.2 KiB
Go
62 lines
1.2 KiB
Go
package metrics
|
|
|
|
import "testing"
|
|
|
|
func BenchmarkCounter(b *testing.B) {
|
|
c := NewCounter()
|
|
b.ResetTimer()
|
|
for i := 0; i < b.N; i++ {
|
|
c.Inc(1)
|
|
}
|
|
}
|
|
|
|
func TestCounterClear(t *testing.T) {
|
|
c := NewCounter()
|
|
c.Inc(1)
|
|
c.Clear()
|
|
if count := c.Snapshot().Count(); count != 0 {
|
|
t.Errorf("c.Count(): 0 != %v\n", count)
|
|
}
|
|
}
|
|
|
|
func TestCounter(t *testing.T) {
|
|
c := NewCounter()
|
|
if count := c.Snapshot().Count(); count != 0 {
|
|
t.Errorf("wrong count: %v", count)
|
|
}
|
|
c.Dec(1)
|
|
if count := c.Snapshot().Count(); count != -1 {
|
|
t.Errorf("wrong count: %v", count)
|
|
}
|
|
c.Dec(2)
|
|
if count := c.Snapshot().Count(); count != -3 {
|
|
t.Errorf("wrong count: %v", count)
|
|
}
|
|
c.Inc(1)
|
|
if count := c.Snapshot().Count(); count != -2 {
|
|
t.Errorf("wrong count: %v", count)
|
|
}
|
|
c.Inc(2)
|
|
if count := c.Snapshot().Count(); count != 0 {
|
|
t.Errorf("wrong count: %v", count)
|
|
}
|
|
}
|
|
|
|
func TestCounterSnapshot(t *testing.T) {
|
|
c := NewCounter()
|
|
c.Inc(1)
|
|
snapshot := c.Snapshot()
|
|
c.Inc(1)
|
|
if count := snapshot.Count(); count != 1 {
|
|
t.Errorf("c.Count(): 1 != %v\n", count)
|
|
}
|
|
}
|
|
|
|
func TestGetOrRegisterCounter(t *testing.T) {
|
|
r := NewRegistry()
|
|
NewRegisteredCounter("foo", r).Inc(47)
|
|
if c := GetOrRegisterCounter("foo", r).Snapshot(); c.Count() != 47 {
|
|
t.Fatal(c)
|
|
}
|
|
}
|