0703ef62d3
This commit changes the behavior of BitCurve.Add to be more inline with btcd. It fixes two different bugs: 1) When adding a point at infinity to another point, the other point should be returned. While this is undefined behavior, it is better to be more inline with the go standard library. Thus (0,0) + (a, b) = (a,b) 2) Adding the same point to itself produced the point at infinity. This is incorrect, now doubleJacobian is used to correctly calculate it. Thus (a,b) + (a,b) == 2* (a,b) and not (0,0) anymore. The change also adds a differential fuzzer for Add, testing it against btcd. Co-authored-by: Felix Lange <fjl@twurst.com>
24 lines
639 B
Go
24 lines
639 B
Go
// Copyright 2015 Jeffrey Wilcke, Felix Lange, Gustav Simonsson. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be found in
|
|
// the LICENSE file.
|
|
|
|
// +build !gofuzz cgo
|
|
|
|
package secp256k1
|
|
|
|
import "C"
|
|
import "unsafe"
|
|
|
|
// Callbacks for converting libsecp256k1 internal faults into
|
|
// recoverable Go panics.
|
|
|
|
//export secp256k1GoPanicIllegal
|
|
func secp256k1GoPanicIllegal(msg *C.char, data unsafe.Pointer) {
|
|
panic("illegal argument: " + C.GoString(msg))
|
|
}
|
|
|
|
//export secp256k1GoPanicError
|
|
func secp256k1GoPanicError(msg *C.char, data unsafe.Pointer) {
|
|
panic("internal error: " + C.GoString(msg))
|
|
}
|