go-ethereum/eth
Martin Holst Swende 295693759e
core/vm: less allocations for various call variants (#21222)
* core/vm/runtime/tests: add more benchmarks

* core/vm: initial work on improving alloc count for calls to precompiles

name                                  old time/op    new time/op    delta
SimpleLoop/identity-precompile-10M-6     117ms ±75%      43ms ± 1%  -63.09%  (p=0.008 n=5+5)
SimpleLoop/loop-10M-6                   79.6ms ± 4%    70.5ms ± 1%  -11.42%  (p=0.008 n=5+5)

name                                  old alloc/op   new alloc/op   delta
SimpleLoop/identity-precompile-10M-6    24.4MB ± 0%     4.9MB ± 0%  -79.94%  (p=0.008 n=5+5)
SimpleLoop/loop-10M-6                   13.2kB ± 0%    13.2kB ± 0%     ~     (p=0.357 n=5+5)

name                                  old allocs/op  new allocs/op  delta
SimpleLoop/identity-precompile-10M-6      382k ± 0%      153k ± 0%  -59.99%  (p=0.000 n=5+4)
SimpleLoop/loop-10M-6                     40.0 ± 0%      40.0 ± 0%     ~     (all equal)

* core/vm: don't allocate big.int for touch

name                                  old time/op    new time/op    delta
SimpleLoop/identity-precompile-10M-6    43.3ms ± 1%    42.4ms ± 7%     ~     (p=0.151 n=5+5)
SimpleLoop/loop-10M-6                   70.5ms ± 1%    76.7ms ± 1%   +8.67%  (p=0.008 n=5+5)

name                                  old alloc/op   new alloc/op   delta
SimpleLoop/identity-precompile-10M-6    4.90MB ± 0%    2.46MB ± 0%  -49.83%  (p=0.008 n=5+5)
SimpleLoop/loop-10M-6                   13.2kB ± 0%    13.2kB ± 1%     ~     (p=0.571 n=5+5)

name                                  old allocs/op  new allocs/op  delta
SimpleLoop/identity-precompile-10M-6      153k ± 0%       76k ± 0%  -49.98%  (p=0.029 n=4+4)
SimpleLoop/loop-10M-6                     40.0 ± 0%      40.0 ± 0%     ~     (all equal)

* core/vm: reduce allocs in staticcall

name                                  old time/op    new time/op    delta
SimpleLoop/identity-precompile-10M-6    42.4ms ± 7%    37.5ms ± 6%  -11.68%  (p=0.008 n=5+5)
SimpleLoop/loop-10M-6                   76.7ms ± 1%    69.1ms ± 1%   -9.82%  (p=0.008 n=5+5)

name                                  old alloc/op   new alloc/op   delta
SimpleLoop/identity-precompile-10M-6    2.46MB ± 0%    0.02MB ± 0%  -99.35%  (p=0.008 n=5+5)
SimpleLoop/loop-10M-6                   13.2kB ± 1%    13.2kB ± 0%     ~     (p=0.143 n=5+5)

name                                  old allocs/op  new allocs/op  delta
SimpleLoop/identity-precompile-10M-6     76.4k ± 0%      0.1k ± 0%     ~     (p=0.079 n=4+5)
SimpleLoop/loop-10M-6                     40.0 ± 0%      40.0 ± 0%     ~     (all equal)

* trie: better use of hasher keccakState

* core/state/statedb: reduce allocations in getDeletedStateObject

* core/vm: reduce allocations in all call derivates

* core/vm: reduce allocations in call variants

- Make returnstack `uint32`
- Use a `sync.Pool` of `stack`s

* core/vm: fix tests

* core/vm: goimports

* core/vm: tracer fix + staticcall gas fix

* core/vm: add back snapshot to staticcall

* core/vm: review concerns + make returnstack pooled + enable returndata in traces

* core/vm: fix some test tracer method signatures

* core/vm: run gencodec, minor comment polish

Co-authored-by: Péter Szilágyi <peterke@gmail.com>
2020-07-16 15:06:19 +03:00
..
downloader les: historical data garbage collection (#19570) 2020-07-13 11:02:54 +02:00
fetcher core, eth, internal: include read storage entries in structlog output (#21204) 2020-06-10 11:46:13 +02:00
filters all: simplify and fix database iteration with prefix/start (#20808) 2020-04-15 14:08:53 +03:00
gasprice eth/gasprice: lighter gas price oracle for light client (#20409) 2020-07-03 14:50:35 +02:00
tracers core/vm: less allocations for various call variants (#21222) 2020-07-16 15:06:19 +03:00
api_backend.go les: historical data garbage collection (#19570) 2020-07-13 11:02:54 +02:00
api_test.go eth: add debug_accountRange API (#19645) 2020-03-31 12:08:44 +02:00
api_tracer.go eth: returned revert reason in traceTx (#21195) 2020-06-26 12:19:31 +02:00
api.go eth: add debug_accountRange API (#19645) 2020-03-31 12:08:44 +02:00
backend.go les, les/lespay: implement new server pool (#20758) 2020-05-22 13:46:34 +02:00
bloombits.go les: historical data garbage collection (#19570) 2020-07-13 11:02:54 +02:00
config.go les: historical data garbage collection (#19570) 2020-07-13 11:02:54 +02:00
discovery.go cmd/geth: enable DNS discovery by default (#20660) 2020-02-13 15:38:30 +02:00
gen_config.go les: historical data garbage collection (#19570) 2020-07-13 11:02:54 +02:00
handler_test.go eth: increase timeout in TestBroadcastBlock (#21299) 2020-07-08 11:50:26 +02:00
handler.go eth: don't block if transaction broadcast loop fails (#21255) 2020-06-24 13:54:13 +03:00
helper_test.go cmd, core, eth: background transaction indexing (#20302) 2020-05-11 18:58:43 +03:00
peer.go eth: don't block if transaction broadcast loop fails (#21255) 2020-06-24 13:54:13 +03:00
protocol_test.go cmd, core, eth: background transaction indexing (#20302) 2020-05-11 18:58:43 +03:00
protocol.go eth: rework tx fetcher to use O(1) ops + manage network requests 2020-02-13 15:27:15 +02:00
sync_test.go eth: improve shutdown synchronization (#20695) 2020-03-27 15:03:20 +02:00
sync.go eth: interrupt chain insertion on shutdown (#21114) 2020-05-26 21:37:37 +02:00