tornadocontrib/go-ethereum
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
581539c6ee
go-ethereum/rpc
History
Felix Lange 4a37ae510e
rpc: tighter shutdown synchronization in client subscription (#22597) 
This fixes a rare issue where the client subscription forwarding loop
would attempt send on the subscription's channel after Unsubscribe has
returned, leading to a panic if the subscription channel was already
closed by the user. Example:

    sub, _ := client.Subscribe(..., channel, ...)
    sub.Unsubscribe()
    close(channel)

The race occurred because Unsubscribe called quitWithServer to tell the
forwarding loop to stop sending on sub.channel, but did not wait for the
loop to actually come down. This is fixed by adding an additional channel
to track the shutdown, on which Unsubscribe now waits.

Fixes #22322
2021-03-30 20:09:30 +02:00
..
testdata rpc: fix issue with null JSON-RPC messages (#21497) 2020-08-28 16:27:58 +02:00
client_example_test.go rpc: make ExampleClientSubscription work with the geth API (#19483) 2020-04-27 17:25:24 +02:00
client_test.go rpc: tighter shutdown synchronization in client subscription (#22597) 2021-03-30 20:09:30 +02:00
client.go rpc: deprecate Client.ShhSubscribe (#22239) 2021-01-27 10:20:34 +01:00
constants_unix_nocgo.go accounts, p2p, rpc: make CGO_ENABLED=0 build again (#19593) 2019-05-26 01:07:10 +03:00
constants_unix.go accounts, p2p, rpc: make CGO_ENABLED=0 build again (#19593) 2019-05-26 01:07:10 +03:00
doc.go rpc: remove 'exported or builtin' restriction for parameters (#20332) 2019-11-20 10:06:21 +02:00
endpoints.go trie, rpc, cmd/geth: fix tests on 32-bit and windows + minor rpc fixes (#21871) 2020-11-19 22:50:47 +01:00
errors.go internal/ethapi: return revert reason for eth_call (#21083) 2020-06-08 11:09:49 +03:00
handler.go rpc: tighter shutdown synchronization in client subscription (#22597) 2021-03-30 20:09:30 +02:00
http_test.go rpc: add separate size limit for websocket (#22385) 2021-02-26 13:40:35 +01:00
http.go rpc: add SetHeader method to Client (#21392) 2020-08-03 14:08:42 +02:00
inproc.go rpc, p2p/simulations: use github.com/gorilla/websocket (#20289) 2019-11-18 10:40:59 +02:00
ipc_js.go all: update author list and licenses 2019-07-22 12:17:27 +03:00
ipc_unix.go rpc: implement websockets with github.com/gorilla/websocket (#19866) 2019-07-22 13:22:39 +03:00
ipc_windows.go all: import "context" instead of "golang.org/x/net/context" 2017-03-22 20:49:15 +01:00
ipc.go rpc, p2p/simulations: use github.com/gorilla/websocket (#20289) 2019-11-18 10:40:59 +02:00
json.go rpc: fix issue with null JSON-RPC messages (#21497) 2020-08-28 16:27:58 +02:00
metrics.go rpc: metrics for JSON-RPC method calls (#20847) 2020-04-03 12:36:44 +02:00
server_test.go internal/ethapi: return revert reason for eth_call (#21083) 2020-06-08 11:09:49 +03:00
server.go all: fix typos in comments (#21118) 2020-05-25 10:21:28 +02:00
service.go rpc: remove 'exported or builtin' restriction for parameters (#20332) 2019-11-20 10:06:21 +02:00
stdio.go rpc, p2p/simulations: use github.com/gorilla/websocket (#20289) 2019-11-18 10:40:59 +02:00
subscription_test.go all: fix a bunch of inconsequential goroutine leaks (#20667) 2020-04-03 20:07:22 +02:00
subscription.go rpc: tighter shutdown synchronization in client subscription (#22597) 2021-03-30 20:09:30 +02:00
testservice_test.go rpc: add separate size limit for websocket (#22385) 2021-02-26 13:40:35 +01:00
types_test.go internal/ethapi: support block number or hash on state-related methods (#19491) 2019-09-26 10:47:31 +02:00
types.go internal/ethapi: return revert reason for eth_call (#21083) 2020-06-08 11:09:49 +03:00
websocket_test.go rpc: tighter shutdown synchronization in client subscription (#22597) 2021-03-30 20:09:30 +02:00
websocket.go rpc: add separate size limit for websocket (#22385) 2021-02-26 13:40:35 +01:00