5f94f8c7e7
This PR will will break existing UIs, since it changes all calls like ApproveSignTransaction to be on the form ui_approveSignTransaction. This is to make it possible for the UI to reuse the json-rpc library from go-ethereum, which uses this convention. Also, this PR removes some unused structs, after import/export were removed from the external api (so no longer needs internal methods for approval) One more breaking change is introduced, removing passwords from the ApproveSignTxResponse and the likes. This makes the manual interface more like the rulebased interface, and integrates nicely with the credential storage. Thus, the way it worked before, it would be tempting for the UI to implement 'remember password' functionality. The way it is now, it will be easy instead to tell clef to store passwords and use them. If a pw is not found in the credential store, the user is prompted to provide the password.
67 lines
1.8 KiB
Go
67 lines
1.8 KiB
Go
// Copyright 2018 The go-ethereum Authors
|
|
// This file is part of go-ethereum.
|
|
//
|
|
// go-ethereum is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// go-ethereum is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with go-ethereum. If not, see <http://www.gnu.org/licenses/>.
|
|
//
|
|
|
|
package storage
|
|
|
|
type Storage interface {
|
|
// Put stores a value by key. 0-length keys results in no-op
|
|
Put(key, value string)
|
|
// Get returns the previously stored value, or the empty string if it does not exist or key is of 0-length
|
|
Get(key string) string
|
|
}
|
|
|
|
// EphemeralStorage is an in-memory storage that does
|
|
// not persist values to disk. Mainly used for testing
|
|
type EphemeralStorage struct {
|
|
data map[string]string
|
|
namespace string
|
|
}
|
|
|
|
func (s *EphemeralStorage) Put(key, value string) {
|
|
if len(key) == 0 {
|
|
return
|
|
}
|
|
//fmt.Printf("storage: put %v -> %v\n", key, value)
|
|
s.data[key] = value
|
|
}
|
|
|
|
func (s *EphemeralStorage) Get(key string) string {
|
|
if len(key) == 0 {
|
|
return ""
|
|
}
|
|
//fmt.Printf("storage: get %v\n", key)
|
|
if v, exist := s.data[key]; exist {
|
|
return v
|
|
}
|
|
return ""
|
|
}
|
|
|
|
func NewEphemeralStorage() Storage {
|
|
s := &EphemeralStorage{
|
|
data: make(map[string]string),
|
|
}
|
|
return s
|
|
}
|
|
|
|
// NoStorage is a dummy construct which doesn't remember anything you tell it
|
|
type NoStorage struct{}
|
|
|
|
func (s *NoStorage) Put(key, value string) {}
|
|
func (s *NoStorage) Get(key string) string {
|
|
return ""
|
|
}
|