89c6c5bb85
When converting a negative number e.g., -2, the resulting ABI encoding should look as follows: fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe. However, since the check of the type is for an uint instead of an int, it results in the following ABI encoding: 0101010101010101010101010101010101010101010101010101010101010102. The Ethereum ABI (https://github.com/ethereum/wiki/wiki/Ethereum-Contract-ABI) says, that signed integers are stored in two's complement which should be of the form ffffff.... and not 01010101..... for e.g. -1. Thus, I removed the type check in numbers.go as well as the function S256 as I don't think they are correct. Or maybe I'm missing something?
65 lines
1.9 KiB
Go
65 lines
1.9 KiB
Go
// Copyright 2015 The go-ethereum Authors
|
|
// This file is part of the go-ethereum library.
|
|
//
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Lesser General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package abi
|
|
|
|
import (
|
|
"bytes"
|
|
"math/big"
|
|
"reflect"
|
|
"testing"
|
|
)
|
|
|
|
func TestNumberTypes(t *testing.T) {
|
|
ubytes := make([]byte, 32)
|
|
ubytes[31] = 1
|
|
|
|
unsigned := U256(big.NewInt(1))
|
|
if !bytes.Equal(unsigned, ubytes) {
|
|
t.Errorf("expected %x got %x", ubytes, unsigned)
|
|
}
|
|
}
|
|
|
|
func TestPackNumber(t *testing.T) {
|
|
ubytes := make([]byte, 32)
|
|
ubytes[31] = 1
|
|
maxunsigned := []byte{255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255}
|
|
|
|
packed := packNum(reflect.ValueOf(1))
|
|
if !bytes.Equal(packed, ubytes) {
|
|
t.Errorf("expected %x got %x", ubytes, packed)
|
|
}
|
|
packed = packNum(reflect.ValueOf(-1))
|
|
if !bytes.Equal(packed, maxunsigned) {
|
|
t.Errorf("expected %x got %x", maxunsigned, packed)
|
|
}
|
|
|
|
packed = packNum(reflect.ValueOf("string"))
|
|
if packed != nil {
|
|
t.Errorf("expected 'string' to pack to nil. got %x instead", packed)
|
|
}
|
|
}
|
|
|
|
func TestSigned(t *testing.T) {
|
|
if isSigned(reflect.ValueOf(uint(10))) {
|
|
t.Error("signed")
|
|
}
|
|
|
|
if !isSigned(reflect.ValueOf(int(10))) {
|
|
t.Error("not signed")
|
|
}
|
|
}
|