7194c847b6
This change significantly improves the performance of RLPx message reads
and writes. In the previous implementation, reading and writing of
message frames performed multiple reads and writes on the underlying
network connection, and allocated a new []byte buffer for every read.
In the new implementation, reads and writes re-use buffers, and perform
much fewer system calls on the underlying connection. This doubles the
theoretically achievable throughput on a single connection, as shown by
the benchmark result:
name old speed new speed delta
Throughput-8 70.3MB/s ± 0% 155.4MB/s ± 0% +121.11% (p=0.000 n=9+8)
The change also removes support for the legacy, pre-EIP-8 handshake encoding.
As of May 2021, no actively maintained client sends this format.
52 lines
1.4 KiB
Go
52 lines
1.4 KiB
Go
// Copyright 2021 The go-ethereum Authors
|
|
// This file is part of the go-ethereum library.
|
|
//
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Lesser General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package rlpx
|
|
|
|
import (
|
|
"bytes"
|
|
"testing"
|
|
|
|
"github.com/ethereum/go-ethereum/common/hexutil"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestReadBufferReset(t *testing.T) {
|
|
reader := bytes.NewReader(hexutil.MustDecode("0x010202030303040505"))
|
|
var b readBuffer
|
|
|
|
s1, _ := b.read(reader, 1)
|
|
s2, _ := b.read(reader, 2)
|
|
s3, _ := b.read(reader, 3)
|
|
|
|
assert.Equal(t, []byte{1}, s1)
|
|
assert.Equal(t, []byte{2, 2}, s2)
|
|
assert.Equal(t, []byte{3, 3, 3}, s3)
|
|
|
|
b.reset()
|
|
|
|
s4, _ := b.read(reader, 1)
|
|
s5, _ := b.read(reader, 2)
|
|
|
|
assert.Equal(t, []byte{4}, s4)
|
|
assert.Equal(t, []byte{5, 5}, s5)
|
|
|
|
s6, err := b.read(reader, 2)
|
|
|
|
assert.EqualError(t, err, "EOF")
|
|
assert.Nil(t, s6)
|
|
}
|