e38b227ce6
* swarm/storage: increase mget timeout in common_test.go TestDbStoreCorrect_1k sometimes timed out with -race on Travis. --- FAIL: TestDbStoreCorrect_1k (24.63s) common_test.go:194: testStore failed: timed out after 10s * swarm: remove unused vars from TestSnapshotSyncWithServer nodeCount and chunkCount is returned from setupSim and those values we use. * swarm: move race/norace helpers from stream to testutil As we will need to use the flag in other packages, too. * swarm: refactor TestSwarmNetwork case Extract long running test cases for better visibility. * swarm/network: skip TestSyncingViaGlobalSync with -race As panics on Travis. panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x7e351b] * swarm: run TestSwarmNetwork with fewer nodes with -race As otherwise we always get test failure with `network_test.go:374: context deadline exceeded` even with raised `Timeout`. * swarm/network: run TestDeliveryFromNodes with fewer nodes with -race Test on Travis times out with 8 or more nodes if -race flag is present. * swarm/network: smaller node count for discovery tests with -race TestDiscoveryPersistenceSimulationSimAdapters failed on Travis with `-race` flag present. The failure was due to extensive memory usage, coming from the CGO runtime. Using a smaller node count resolves the issue. === RUN TestDiscoveryPersistenceSimulationSimAdapter ==7227==ERROR: ThreadSanitizer failed to allocate 0x80000 (524288) bytes of clock allocator (error code: 12) FATAL: ThreadSanitizer CHECK failed: ./gotsan.cc:6976 "((0 && "unable to mmap")) != (0)" (0x0, 0x0) FAIL github.com/ethereum/go-ethereum/swarm/network/simulations/discovery 804.826s * swarm/network: run TestFileRetrieval with fewer nodes with -race Otherwise we get a failure due to extensive memory usage, as the CGO runtime cannot allocate more bytes. === RUN TestFileRetrieval ==7366==ERROR: ThreadSanitizer failed to allocate 0x80000 (524288) bytes of clock allocator (error code: 12) FATAL: ThreadSanitizer CHECK failed: ./gotsan.cc:6976 "((0 && "unable to mmap")) != (0)" (0x0, 0x0) FAIL github.com/ethereum/go-ethereum/swarm/network/stream 155.165s * swarm/network: run TestRetrieval with fewer nodes with -race Otherwise we get a failure due to extensive memory usage, as the CGO runtime cannot allocate more bytes ("ThreadSanitizer failed to allocate"). * swarm/network: skip flaky TestGetSubscriptionsRPC on Travis w/ -race Test fails a lot with something like: streamer_test.go:1332: Real subscriptions and expected amount don't match; real: 0, expected: 20 * swarm/storage: skip TestDB_SubscribePull* tests on Travis w/ -race Travis just hangs... ok github.com/ethereum/go-ethereum/swarm/storage/feed/lookup 1.307s keepalive keepalive keepalive or panics after a while. Without these tests the race detector job is now stable. Let's invetigate these tests in a separate issue: https://github.com/ethersphere/go-ethereum/issues/1245
361 lines
9.0 KiB
Go
361 lines
9.0 KiB
Go
// Copyright 2018 The go-ethereum Authors
|
|
// This file is part of the go-ethereum library.
|
|
//
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Lesser General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package localstore
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"math/rand"
|
|
"os"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/ethereum/go-ethereum/swarm/storage"
|
|
)
|
|
|
|
// TestDB_collectGarbageWorker tests garbage collection runs
|
|
// by uploading and syncing a number of chunks.
|
|
func TestDB_collectGarbageWorker(t *testing.T) {
|
|
testDB_collectGarbageWorker(t)
|
|
}
|
|
|
|
// TestDB_collectGarbageWorker_multipleBatches tests garbage
|
|
// collection runs by uploading and syncing a number of
|
|
// chunks by having multiple smaller batches.
|
|
func TestDB_collectGarbageWorker_multipleBatches(t *testing.T) {
|
|
// lower the maximal number of chunks in a single
|
|
// gc batch to ensure multiple batches.
|
|
defer func(s int64) { gcBatchSize = s }(gcBatchSize)
|
|
gcBatchSize = 2
|
|
|
|
testDB_collectGarbageWorker(t)
|
|
}
|
|
|
|
// testDB_collectGarbageWorker is a helper test function to test
|
|
// garbage collection runs by uploading and syncing a number of chunks.
|
|
func testDB_collectGarbageWorker(t *testing.T) {
|
|
t.Helper()
|
|
|
|
chunkCount := 150
|
|
|
|
testHookCollectGarbageChan := make(chan int64)
|
|
defer setTestHookCollectGarbage(func(collectedCount int64) {
|
|
testHookCollectGarbageChan <- collectedCount
|
|
})()
|
|
|
|
db, cleanupFunc := newTestDB(t, &Options{
|
|
Capacity: 100,
|
|
})
|
|
defer cleanupFunc()
|
|
|
|
uploader := db.NewPutter(ModePutUpload)
|
|
syncer := db.NewSetter(ModeSetSync)
|
|
|
|
addrs := make([]storage.Address, 0)
|
|
|
|
// upload random chunks
|
|
for i := 0; i < chunkCount; i++ {
|
|
chunk := generateRandomChunk()
|
|
|
|
err := uploader.Put(chunk)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
err = syncer.Set(chunk.Address())
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
addrs = append(addrs, chunk.Address())
|
|
}
|
|
|
|
gcTarget := db.gcTarget()
|
|
|
|
for {
|
|
select {
|
|
case <-testHookCollectGarbageChan:
|
|
case <-time.After(10 * time.Second):
|
|
t.Error("collect garbage timeout")
|
|
}
|
|
gcSize := db.getGCSize()
|
|
if gcSize == gcTarget {
|
|
break
|
|
}
|
|
}
|
|
|
|
t.Run("pull index count", newItemsCountTest(db.pullIndex, int(gcTarget)))
|
|
|
|
t.Run("gc index count", newItemsCountTest(db.gcIndex, int(gcTarget)))
|
|
|
|
t.Run("gc size", newIndexGCSizeTest(db))
|
|
|
|
// the first synced chunk should be removed
|
|
t.Run("get the first synced chunk", func(t *testing.T) {
|
|
_, err := db.NewGetter(ModeGetRequest).Get(addrs[0])
|
|
if err != storage.ErrChunkNotFound {
|
|
t.Errorf("got error %v, want %v", err, storage.ErrChunkNotFound)
|
|
}
|
|
})
|
|
|
|
// last synced chunk should not be removed
|
|
t.Run("get most recent synced chunk", func(t *testing.T) {
|
|
_, err := db.NewGetter(ModeGetRequest).Get(addrs[len(addrs)-1])
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
})
|
|
|
|
// cleanup: drain the last testHookCollectGarbageChan
|
|
// element before calling deferred functions not to block
|
|
// collectGarbageWorker loop, preventing the race in
|
|
// setting testHookCollectGarbage function
|
|
select {
|
|
case <-testHookCollectGarbageChan:
|
|
default:
|
|
}
|
|
}
|
|
|
|
// TestDB_collectGarbageWorker_withRequests is a helper test function
|
|
// to test garbage collection runs by uploading, syncing and
|
|
// requesting a number of chunks.
|
|
func TestDB_collectGarbageWorker_withRequests(t *testing.T) {
|
|
db, cleanupFunc := newTestDB(t, &Options{
|
|
Capacity: 100,
|
|
})
|
|
defer cleanupFunc()
|
|
|
|
uploader := db.NewPutter(ModePutUpload)
|
|
syncer := db.NewSetter(ModeSetSync)
|
|
|
|
testHookCollectGarbageChan := make(chan int64)
|
|
defer setTestHookCollectGarbage(func(collectedCount int64) {
|
|
testHookCollectGarbageChan <- collectedCount
|
|
})()
|
|
|
|
addrs := make([]storage.Address, 0)
|
|
|
|
// upload random chunks just up to the capacity
|
|
for i := 0; i < int(db.capacity)-1; i++ {
|
|
chunk := generateRandomChunk()
|
|
|
|
err := uploader.Put(chunk)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
err = syncer.Set(chunk.Address())
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
addrs = append(addrs, chunk.Address())
|
|
}
|
|
|
|
// request the latest synced chunk
|
|
// to prioritize it in the gc index
|
|
// not to be collected
|
|
_, err := db.NewGetter(ModeGetRequest).Get(addrs[0])
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// upload and sync another chunk to trigger
|
|
// garbage collection
|
|
chunk := generateRandomChunk()
|
|
err = uploader.Put(chunk)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
err = syncer.Set(chunk.Address())
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
addrs = append(addrs, chunk.Address())
|
|
|
|
// wait for garbage collection
|
|
|
|
gcTarget := db.gcTarget()
|
|
|
|
var totalCollectedCount int64
|
|
for {
|
|
select {
|
|
case c := <-testHookCollectGarbageChan:
|
|
totalCollectedCount += c
|
|
case <-time.After(10 * time.Second):
|
|
t.Error("collect garbage timeout")
|
|
}
|
|
gcSize := db.getGCSize()
|
|
if gcSize == gcTarget {
|
|
break
|
|
}
|
|
}
|
|
|
|
wantTotalCollectedCount := int64(len(addrs)) - gcTarget
|
|
if totalCollectedCount != wantTotalCollectedCount {
|
|
t.Errorf("total collected chunks %v, want %v", totalCollectedCount, wantTotalCollectedCount)
|
|
}
|
|
|
|
t.Run("pull index count", newItemsCountTest(db.pullIndex, int(gcTarget)))
|
|
|
|
t.Run("gc index count", newItemsCountTest(db.gcIndex, int(gcTarget)))
|
|
|
|
t.Run("gc size", newIndexGCSizeTest(db))
|
|
|
|
// requested chunk should not be removed
|
|
t.Run("get requested chunk", func(t *testing.T) {
|
|
_, err := db.NewGetter(ModeGetRequest).Get(addrs[0])
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
})
|
|
|
|
// the second synced chunk should be removed
|
|
t.Run("get gc-ed chunk", func(t *testing.T) {
|
|
_, err := db.NewGetter(ModeGetRequest).Get(addrs[1])
|
|
if err != storage.ErrChunkNotFound {
|
|
t.Errorf("got error %v, want %v", err, storage.ErrChunkNotFound)
|
|
}
|
|
})
|
|
|
|
// last synced chunk should not be removed
|
|
t.Run("get most recent synced chunk", func(t *testing.T) {
|
|
_, err := db.NewGetter(ModeGetRequest).Get(addrs[len(addrs)-1])
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
// TestDB_gcSize checks if gcSize has a correct value after
|
|
// database is initialized with existing data.
|
|
func TestDB_gcSize(t *testing.T) {
|
|
dir, err := ioutil.TempDir("", "localstore-stored-gc-size")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(dir)
|
|
baseKey := make([]byte, 32)
|
|
if _, err := rand.Read(baseKey); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
db, err := New(dir, baseKey, nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
uploader := db.NewPutter(ModePutUpload)
|
|
syncer := db.NewSetter(ModeSetSync)
|
|
|
|
count := 100
|
|
|
|
for i := 0; i < count; i++ {
|
|
chunk := generateRandomChunk()
|
|
|
|
err := uploader.Put(chunk)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
err = syncer.Set(chunk.Address())
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
// DB.Close writes gc size to disk, so
|
|
// Instead calling Close, simulate database shutdown
|
|
// without it.
|
|
close(db.close)
|
|
db.updateGCWG.Wait()
|
|
err = db.shed.Close()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
db, err = New(dir, baseKey, nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
t.Run("gc index size", newIndexGCSizeTest(db))
|
|
|
|
t.Run("gc uncounted hashes index count", newItemsCountTest(db.gcUncountedHashesIndex, 0))
|
|
}
|
|
|
|
// setTestHookCollectGarbage sets testHookCollectGarbage and
|
|
// returns a function that will reset it to the
|
|
// value before the change.
|
|
func setTestHookCollectGarbage(h func(collectedCount int64)) (reset func()) {
|
|
current := testHookCollectGarbage
|
|
reset = func() { testHookCollectGarbage = current }
|
|
testHookCollectGarbage = h
|
|
return reset
|
|
}
|
|
|
|
// TestSetTestHookCollectGarbage tests if setTestHookCollectGarbage changes
|
|
// testHookCollectGarbage function correctly and if its reset function
|
|
// resets the original function.
|
|
func TestSetTestHookCollectGarbage(t *testing.T) {
|
|
// Set the current function after the test finishes.
|
|
defer func(h func(collectedCount int64)) { testHookCollectGarbage = h }(testHookCollectGarbage)
|
|
|
|
// expected value for the unchanged function
|
|
original := 1
|
|
// expected value for the changed function
|
|
changed := 2
|
|
|
|
// this variable will be set with two different functions
|
|
var got int
|
|
|
|
// define the original (unchanged) functions
|
|
testHookCollectGarbage = func(_ int64) {
|
|
got = original
|
|
}
|
|
|
|
// set got variable
|
|
testHookCollectGarbage(0)
|
|
|
|
// test if got variable is set correctly
|
|
if got != original {
|
|
t.Errorf("got hook value %v, want %v", got, original)
|
|
}
|
|
|
|
// set the new function
|
|
reset := setTestHookCollectGarbage(func(_ int64) {
|
|
got = changed
|
|
})
|
|
|
|
// set got variable
|
|
testHookCollectGarbage(0)
|
|
|
|
// test if got variable is set correctly to changed value
|
|
if got != changed {
|
|
t.Errorf("got hook value %v, want %v", got, changed)
|
|
}
|
|
|
|
// set the function to the original one
|
|
reset()
|
|
|
|
// set got variable
|
|
testHookCollectGarbage(0)
|
|
|
|
// test if got variable is set correctly to original value
|
|
if got != original {
|
|
t.Errorf("got hook value %v, want %v", got, original)
|
|
}
|
|
}
|