From 56938b6b0127bd889523e9d3b6a062859ed0f65d Mon Sep 17 00:00:00 2001 From: felipe andrade <130432649+felipe-op@users.noreply.github.com> Date: Thu, 25 May 2023 11:04:14 -0700 Subject: [PATCH] normalize latency in ms (#5783) --- proxyd/proxyd/backend.go | 2 +- proxyd/proxyd/metrics.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/proxyd/proxyd/backend.go b/proxyd/proxyd/backend.go index b57c938..8e8db75 100644 --- a/proxyd/proxyd/backend.go +++ b/proxyd/proxyd/backend.go @@ -482,7 +482,7 @@ func (b *Backend) doForward(ctx context.Context, rpcReqs []*RPCReq, isBatch bool } duration := time.Since(start) b.latencySlidingWindow.Add(float64(duration)) - RecordBackendNetworkLatencyAverageSlidingWindow(b, b.latencySlidingWindow.Avg()) + RecordBackendNetworkLatencyAverageSlidingWindow(b, time.Duration(b.latencySlidingWindow.Avg())) sortBatchRPCResponse(rpcReqs, res) return res, nil diff --git a/proxyd/proxyd/metrics.go b/proxyd/proxyd/metrics.go index 3f462cf..884e783 100644 --- a/proxyd/proxyd/metrics.go +++ b/proxyd/proxyd/metrics.go @@ -442,8 +442,8 @@ func RecordConsensusBackendUpdateDelay(b *Backend, delay time.Duration) { consensusUpdateDelayBackend.WithLabelValues(b.Name).Set(float64(delay.Milliseconds())) } -func RecordBackendNetworkLatencyAverageSlidingWindow(b *Backend, avgLatency float64) { - avgLatencyBackend.WithLabelValues(b.Name).Set(avgLatency) +func RecordBackendNetworkLatencyAverageSlidingWindow(b *Backend, avgLatency time.Duration) { + avgLatencyBackend.WithLabelValues(b.Name).Set(float64(avgLatency.Milliseconds())) } func RecordBackendNetworkRequestCountSlidingWindow(b *Backend, count uint) {