tornadocontrib/infra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

improve error metrics

Browse Source
This commit is contained in:
Felipe Andrade 2023-09-06 15:09:03 -07:00
parent a2f166a9a6
commit b5cda060b0
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
op-ufm/op-ufm/pkg/metrics/clients/eth.go
View File

@ -22,7 +22,7 @@ func Dial(providerName string, url string) (*InstrumentedEthClient, error) {
start := time.Now() start := time.Now()
c, err := ethclient.Dial(url) c, err := ethclient.Dial(url)
if err != nil { if err != nil {
metrics.RecordError(providerName, "ethclient.Dial") metrics.RecordErrorDetails(providerName, "ethclient.Dial", err)
return nil, err return nil, err
} }
metrics.RecordRPCLatency(providerName, "ethclient", "Dial", time.Since(start)) metrics.RecordRPCLatency(providerName, "ethclient", "Dial", time.Since(start))
@ -34,7 +34,7 @@ func (i *InstrumentedEthClient) TransactionByHash(ctx context.Context, hash comm
tx, isPending, err := i.c.TransactionByHash(ctx, hash) tx, isPending, err := i.c.TransactionByHash(ctx, hash)
if err != nil { if err != nil {
if !i.ignorableErrors(err) { if !i.ignorableErrors(err) {
metrics.RecordError(i.providerName, "ethclient.TransactionByHash") metrics.RecordErrorDetails(i.providerName, "ethclient.TransactionByHash", err)
} }
return nil, false, err return nil, false, err
} }
@ -46,7 +46,7 @@ func (i *InstrumentedEthClient) PendingNonceAt(ctx context.Context, address stri
start := time.Now() start := time.Now()
nonce, err := i.c.PendingNonceAt(ctx, common.HexToAddress(address)) nonce, err := i.c.PendingNonceAt(ctx, common.HexToAddress(address))
if err != nil { if err != nil {
metrics.RecordError(i.providerName, "ethclient.PendingNonceAt") metrics.RecordErrorDetails(i.providerName, "ethclient.PendingNonceAt", err)
return 0, err return 0, err
} }
metrics.RecordRPCLatency(i.providerName, "ethclient", "PendingNonceAt", time.Since(start)) metrics.RecordRPCLatency(i.providerName, "ethclient", "PendingNonceAt", time.Since(start))
@ -58,7 +58,7 @@ func (i *InstrumentedEthClient) TransactionReceipt(ctx context.Context, txHash c
receipt, err := i.c.TransactionReceipt(ctx, txHash) receipt, err := i.c.TransactionReceipt(ctx, txHash)
if err != nil { if err != nil {
if !i.ignorableErrors(err) { if !i.ignorableErrors(err) {
metrics.RecordError(i.providerName, "ethclient.TransactionReceipt") metrics.RecordErrorDetails(i.providerName, "ethclient.TransactionReceipt", err)
} }
return nil, err return nil, err
} }
@ -71,7 +71,7 @@ func (i *InstrumentedEthClient) SendTransaction(ctx context.Context, tx *types.T
err := i.c.SendTransaction(ctx, tx) err := i.c.SendTransaction(ctx, tx)
if err != nil { if err != nil {
if !i.ignorableErrors(err) { if !i.ignorableErrors(err) {
metrics.RecordError(i.providerName, "ethclient.SendTransaction") metrics.RecordErrorDetails(i.providerName, "ethclient.SendTransaction", err)
} }
return err return err
} }

4
op-ufm/op-ufm/pkg/metrics/clients/signer.go
View File

@ -22,7 +22,7 @@ func NewSignerClient(providerName string, logger log.Logger, endpoint string, tl
start := time.Now() start := time.Now()
c, err := signer.NewSignerClient(logger, endpoint, tlsConfig) c, err := signer.NewSignerClient(logger, endpoint, tlsConfig)
if err != nil { if err != nil {
metrics.RecordError(providerName, "signer.NewSignerClient") metrics.RecordErrorDetails(providerName, "signer.NewSignerClient", err)
return nil, err return nil, err
} }
metrics.RecordRPCLatency(providerName, "signer", "NewSignerClient", time.Since(start)) metrics.RecordRPCLatency(providerName, "signer", "NewSignerClient", time.Since(start))
@ -33,7 +33,7 @@ func (i *InstrumentedSignerClient) SignTransaction(ctx context.Context, chainId
start := time.Now() start := time.Now()
tx, err := i.c.SignTransaction(ctx, chainId, tx) tx, err := i.c.SignTransaction(ctx, chainId, tx)
if err != nil { if err != nil {
metrics.RecordError(i.providerName, "signer.SignTransaction") metrics.RecordErrorDetails(i.providerName, "signer.SignTransaction", err)
return nil, err return nil, err
} }
metrics.RecordRPCLatency(i.providerName, "signer", "SignTransaction", time.Since(start)) metrics.RecordRPCLatency(i.providerName, "signer", "SignTransaction", time.Since(start))